From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-481255-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 100803 invoked by alias); 23 Mar 2015 14:21:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 100774 invoked by uid 48); 23 Mar 2015 14:21:17 -0000
From: "demoonlit at panathenaia dot halfmoon.jp" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/65524] New: gnatbind generates decrementing the unexisting elab-counter into finalize_library
Date: Mon, 23 Mar 2015 14:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ada
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: demoonlit at panathenaia dot halfmoon.jp
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-65524-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-03/txt/msg02399.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65524

            Bug ID: 65524
           Summary: gnatbind generates decrementing the unexisting
                    elab-counter into finalize_library
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: demoonlit at panathenaia dot halfmoon.jp

I found some cases that gnatbind generates decrementing the unexisting
elaboration counter of each package Exxx.

   E142 : Short_Integer; pragma Import (Ada, E142, "system__exn_lli_E");
   ... some Exxx are declared ...

   procedure finalize_library is
   begin
      ...
      E132 := E132 - 1; -- * E132 is not declared in above *
      ...
   end finalize_library;

A cause is a package having _finalize_spec/_finalize_body without
_elabs/_elabb.
I still have not been able to make the minimal example, but have made a patch.

In bindgen.adb, Gen_Elab_Externals refers U.Set_Elab_Entity to generate Exxx.
However, Gen_Finalize_Library does not refer it.

--- a/gcc/ada/bindgen.adb
+++ b/gcc/ada/bindgen.adb
@@ -1434,7 +1434,9 @@ package body Bindgen is
             --  has a finalizer. In that case, this is where we decrement
             --  the elaboration entity.

-            if U.Utype = Is_Body and then Uspec.Has_Finalizer then
+            if U.Utype = Is_Body and then Uspec.Has_Finalizer
+               and then Uspec.Set_Elab_Entity
+            then
                if not Lib_Final_Built then
                   Gen_Header;
                   Lib_Final_Built := True;
@@ -1548,7 +1550,9 @@ package body Bindgen is

             WBI ("      begin");

-            if U.Utype /= Is_Spec then
+            if U.Utype /= Is_Spec
+               and then Uspec.Set_Elab_Entity
+            then
                Set_String ("         E");
                Set_Unit_Number (Unum);
                Set_String (" := E");