[Bug fortran/65532] New: [5 Regression] Unexpected error with legacy code (D1MACH)

[Bug fortran/65532] New: [5 Regression] Unexpected error with legacy code (D1MACH)

[anlauf at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

            Bug ID: 65532
           Summary: [5 Regression] Unexpected error with legacy code
                    (D1MACH)
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: anlauf at gmx dot de

Created attachment 35119
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35119&action=edit
Bug demo.

Dear all,

after updating to trunk rev. 221607, I found a problem which I reduced
to the attached example.

Commenting out the call to d1mach or commenting out in d1mach the
data statements in lines 21-25 makes the error messages disappear.

Here's the error messages I get:

% gfc-trunk -c gfcbug131.f90
gfcbug131.f90:10:23:

     INTEGER :: diver(4)
                       1
Error: Different shape for array assignment at (1) on dimension 1 (4 and 2)
gfcbug131.f90:8:23:

     INTEGER :: large(4)
                       1
Error: Different shape for array assignment at (1) on dimension 1 (4 and 2)
gfcbug131.f90:11:23:

     INTEGER :: LOG10(4)
                       1
Error: Different shape for array assignment at (1) on dimension 1 (4 and 2)
gfcbug131.f90:9:23:

     INTEGER :: right(4)
                       1
Error: Different shape for array assignment at (1) on dimension 1 (4 and 2)
gfcbug131.f90:7:23:

     INTEGER :: small(4)
                       1
Error: Different shape for array assignment at (1) on dimension 1 (4 and 2)

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[anlauf at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

Harald Anlauf <anlauf at gmx dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.9.0
      Known to fail|                            |5.0

--- Comment #1 from Harald Anlauf <anlauf at gmx dot de> ---
I found a workaround by changing the dimension of the arrays in
lines 7-11 to 2 instead of 4 (the original code also supports
dated hardware).

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I suspect r221586: I don't see the errors at r221569.

> I found a workaround by changing the dimension of the arrays in
> lines 7-11 to 2 instead of 4 (the original code also supports
> dated hardware).

Confirmed.

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-03-24
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |5.0
     Ever confirmed|0                           |1

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
It indeed is r221586.

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

--- Comment #4 from Mikael Morin <mikael at gcc dot gnu.org> ---
With r221586, procedure d1mach is resolved more than once.
At the first time resolve_values is called, the problematic variables (diver,
large, etc)  have a NULL sym->value, which is set afterwards in resolve_data.
On the second call, the value is non-null and the error is produced.

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mikael at gcc dot gnu.org

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktkachov at gcc dot gnu.org

--- Comment #5 from ktkachov at gcc dot gnu.org ---
As noted in 64952, this prevents 481.wrf from SPEC2006 being built

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/ml/gcc-
                   |                            |patches/2015-03/msg01272.ht
                   |                            |ml

--- Comment #6 from Mikael Morin <mikael at gcc dot gnu.org> ---
Patch posted:
https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01272.html

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

--- Comment #7 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Wed Mar 25 10:15:46 2015
New Revision: 221657

URL: https://gcc.gnu.org/viewcvs?rev=221657&root=gcc&view=rev
Log:
Fix regression introduced at revision 221586.

    PR fortran/64952
    PR fortran/65532
fortran/
    * gfortran.h (struct gfc_namespace): New field 'types_resolved'.
    * resolve.c (resolve_types): Return early if field 'types_resolved'
    is set.  Set 'types_resolved' at the end.
testsuite/
    * gfortran.dg/data_initialized_3.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/data_initialized_3.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/65532] [5 Regression] Unexpected error with legacy code (D1MACH)

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65532

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Mikael Morin <mikael at gcc dot gnu.org> ---
Fixed.  Closing.