From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54450 invoked by alias); 24 Mar 2015 19:55:35 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 54353 invoked by uid 48); 24 Mar 2015 19:55:30 -0000 From: "manu at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug lto/65536] LTO line number information garbled Date: Tue, 24 Mar 2015 20:22:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: lto X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: manu at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg02650.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D65536 --- Comment #23 from Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez --- (In reply to Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez from comment #15) > (In reply to Jakub Jelinek from comment #14) > > By streaming the line_table directly you'd stream lots of location_t th= at > > are not actually used for anything that is streamed into the LTO. > > I don't understand why the tables would be huge, the string would of co= urse > > use normal LTO section string sharing, and if we stream right now every > > location_t as the triplet, it would mean in case a single location_t is > > never used by more than one tree we'd stream an integer extra to what we > > stream now (just the triplets would be streamed in a different place), = but > > in the more common case where one location_t is used by many trees, we'd > > stream less than what we stream now, due to the additional indirection. >=20 [...] > Of course, if you are really unlucky, each location_t used by LTO may bel= ong > to a different map, thus you cannot remove anything and then it would have > been more efficient to use a file:line:column table. In this worst case, = the > overhead would be approximately sizeof(struct line_map) * number of rows = in > the file:line:column table. In fact, looking at=20 struct GTY(()) line_map_ordinary { const char *to_file; linenum_type to_line; /* An index into the set that gives the line mapping at whose end the current one was included. File(s) at the bottom of the include stack have this set to -1. */ int included_from; /* SYSP is one for a system header, two for a C system header file that therefore needs to be extern "C" protected in C++, and zero otherwise. This field isn't really needed now that it's in cpp_buffer. */ unsigned char sysp; /* Number of the low-order source_location bits used for a column number.= */ unsigned int column_bits : 8; }; If we do not care about sysp and included_from, then even in the worst case= , it will be more efficient to stream out the line_table than the file:line:colu= mn table. And it has the benefit that it is already sorted and the location_t values within trees/gimple can be streamed out directly without calling linemap_lo= okup to get the file:line:column for each of them. And since a location_t takes = 1/3 of space that file:line:column, that would reduce the streamed out data even further. >>From gcc-bugs-return-481507-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Mar 24 19:58:26 2015 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 57995 invoked by alias); 24 Mar 2015 19:58:25 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 57233 invoked by uid 48); 24 Mar 2015 19:58:19 -0000 From: "paolo.carlini at oracle dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/61358] Bogus "duplicate label" error after label used within C++11 lambda Date: Tue, 24 Mar 2015 20:25:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Version: 4.8.1 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: paolo.carlini at oracle dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on cc blocked everconfirmed Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg02651.txt.bz2 Content-length: 543 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61358 Paolo Carlini changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2015-03-24 CC| |paolo.carlini at oracle dot com Blocks| |54367 Ever confirmed|0 |1