From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 446 invoked by alias); 26 Mar 2015 17:04:38 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 128283 invoked by uid 48); 26 Mar 2015 17:04:30 -0000 From: "manu at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug lto/65536] LTO line number information garbled Date: Thu, 26 Mar 2015 17:49:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: lto X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: manu at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg03001.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D65536 --- Comment #45 from Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez --- (In reply to Jan Hubicka from comment #42) > Hi, > I read linemap_line_start and I think I noticed few issues with respect > to overflows and lines being added randomly. I honestly think this is too sensitive for stage3. I'm also not very much in favour for optimizing out-of-order creating of line-maps. That is not the typical case outside LTO and I would argue it should not be the typical cas= e in LTO either. Of course, fixing overflow problems is orthogonal and desirable= and should be submitted as a separate patch. > 1) line_delta is computed as to_line SOURCE_LINE (map, set->highest_line) > I think the last inserted line is not very releavnt. What we care abo= ut > is > the base of the last location and to keep thing dense how much we are > stretching the value range from highest inserted element (inserting in= to > middle > is cheap). My guess is that the motivation here is that, if there is a large gap, it m= eans that we didn't get asked any source_location since a lot of lines ago. thus= it would save a lot of source_locations to simply start a new map now. Of cour= se, this does not work for out-of-order, but why should we pessimize typical us= age for something that should be fixed in LTO? > 2) (line_delta > 10 && line_delta * ORDINARY_MAP_NUMBER_OF_COLUMN_BITS (m= ap) > > 1000) > ORDINARY_MAP_NUMBER_OF_COLUMN_BITS (map) is in range 7... 15, so it ne= ver > gets high enough to make this conditional trigger. I changed it to: I don't understand this. A line_delta of 67 (1000/15) will already trigger = it. > 4) the code deciding whether to do reuse seems worng: > if (line_delta < 0 > || last_line !=3D ORDINARY_MAP_STARTING_LINE_NUMBER (map) > || SOURCE_COLUMN (map, highest) >=3D (1U << column_bits)) >=20 > line_delta really should be base_line_delta, we do not need to give up > when map's line is 1, SOURCE_LINE (map, set->highest_line) is 5 > and we are requested to switch to line 3. If you insert a line out of order without creating a new map, then linemap_position_for_column will return the wrong value. >>From gcc-bugs-return-481858-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Mar 26 17:17:07 2015 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 17334 invoked by alias); 26 Mar 2015 17:17:07 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 17254 invoked by uid 48); 26 Mar 2015 17:16:59 -0000 From: "doko at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug go/65587] C package incomplete/not working for powerpc-linux-gnu Date: Thu, 26 Mar 2015 17:52:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: go X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: doko at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ian at airs dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg03002.txt.bz2 Content-length: 236 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65587 --- Comment #2 from Matthias Klose --- Created attachment 35151 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35151&action=edit output of cgo command