public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/65583] [5 Regression][UBSAN] ICE segfault in inline_edge_summary
Date: Thu, 26 Mar 2015 13:38:00 -0000	[thread overview]
Message-ID: <bug-65583-4-pLjNQS0YEC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65583-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583

--- Comment #9 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #8)
> So, can you try to schedule another
>   NEXT_PASS (pass_rebuild_cgraph_edges);
> right after ubsan pass if that fixes it?
> And then move that right before ubsan and see if it is broken again?

Yup: scheduling the pass after ubsan fixes it, scheduling is before ICEs as
well.  So either simply that, or something like

--- a/gcc/passes.def
+++ b/gcc/passes.def
@@ -57,6 +57,9 @@ along with GCC; see the file COPYING3.  If not see
       NEXT_PASS (pass_init_datastructures);
       NEXT_PASS (pass_build_ssa);
       NEXT_PASS (pass_ubsan);
+      PUSH_INSERT_PASSES_WITHIN (pass_ubsan)
+          NEXT_PASS (pass_rebuild_cgraph_edges);
+      POP_INSERT_PASSES ()
       NEXT_PASS (pass_early_warn_uninitialized);
   POP_INSERT_PASSES ()

(Maybe that PUSH_INSERT_PASSES_WITHIN makes it cheaper for non-ubsan
compilation?)


  parent reply	other threads:[~2015-03-26 13:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 12:49 [Bug sanitizer/65583] New: " burnus at gcc dot gnu.org
2015-03-26 13:03 ` [Bug sanitizer/65583] " mpolacek at gcc dot gnu.org
2015-03-26 13:08 ` mpolacek at gcc dot gnu.org
2015-03-26 13:19 ` rguenth at gcc dot gnu.org
2015-03-26 13:20 ` jakub at gcc dot gnu.org
2015-03-26 13:21 ` rguenth at gcc dot gnu.org
2015-03-26 13:27 ` rguenth at gcc dot gnu.org
2015-03-26 13:31 ` mpolacek at gcc dot gnu.org
2015-03-26 13:31 ` jakub at gcc dot gnu.org
2015-03-26 13:38 ` mpolacek at gcc dot gnu.org [this message]
2015-03-26 13:56 ` jakub at gcc dot gnu.org
2015-03-26 14:44 ` mpolacek at gcc dot gnu.org
2015-03-27  9:55 ` mpolacek at gcc dot gnu.org
2015-03-27  9:55 ` mpolacek at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65583-4-pLjNQS0YEC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).