[Bug c/65586] New: [5 Regression] -fopenmp-simd rejects valid input

[Bug c/65586] New: [5 Regression] -fopenmp-simd rejects valid input

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65586

            Bug ID: 65586
           Summary: [5 Regression] -fopenmp-simd rejects valid input
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Keywords: openmp, rejects-valid
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org

One of the recent GCC changes causes -fopenmp-simd to reject code, which
compiled before (by ignoring it):


gcc -fno-openmp -fopenmp-simd foo.c
foo.c: In function ‘main’:
foo.c:4:17: error: expected end of line before ‘collapse’
 #pragma omp for collapse(1)
                 ^


void foo() { }

int main() {
#pragma omp for collapse(1)
  for (int i = 1; i <= 151; i+=31)
     foo();
}
>From gcc-bugs-return-481855-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Mar 26 16:42:31 2015
Return-Path: <gcc-bugs-return-481855-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 94108 invoked by alias); 26 Mar 2015 16:42:31 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 94030 invoked by uid 48); 26 Mar 2015 16:42:27 -0000
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/65587] New: C package incomplete/not working for powerpc-linux-gnu
Date: Thu, 26 Mar 2015 17:25:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc
Message-ID: <bug-65587-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-03/txt/msg02999.txt.bz2
Content-length: 1917

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide587

            Bug ID: 65587
           Summary: C package incomplete/not working for powerpc-linux-gnu
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: doko at gcc dot gnu.org
                CC: cmang at google dot com

when trying to build github.com/gosexy/gettext/gettext.go on powerpc-linux-gnu,
I get

dist/src/github.com/gosexy/gettext/gettext.go:42:16: unable to find value of
constant C.LC_ALL
dist/src/github.com/gosexy/gettext/gettext.go:46:19: unable to find value of
constant C.LC_ALL
dist/src/github.com/gosexy/gettext/gettext.go:50:18: unable to find value of
constant C.LC_CTYPE
dist/src/github.com/gosexy/gettext/gettext.go:53:21: unable to find value of
constant C.LC_MESSAGES
dist/src/github.com/gosexy/gettext/gettext.go:56:21: unable to find value of
constant C.LC_MONETARY
dist/src/github.com/gosexy/gettext/gettext.go:60:20: unable to find value of
constant C.LC_NUMERIC
dist/src/github.com/gosexy/gettext/gettext.go:63:17: unable to find value of
constant C.LC_TIME
dist/src/github.com/gosexy/gettext/gettext.go:68:13: call of non-function
C.CString
dist/src/github.com/gosexy/gettext/gettext.go:70:9: call of non-function
C.GoString
dist/src/github.com/gosexy/gettext/gettext.go:70:20: call of non-function
C.setlocale
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x14]

goroutine 16 [running]:
main.rewriteRef.pN12_main.Package
    ../../src/gotools/../libgo/go/cmd/cgo/gcc.go:620
main.Translate.pN12_main.Package
    ../../src/gotools/../libgo/go/cmd/cgo/gcc.go:184
main.main
    ../../src/gotools/../libgo/go/cmd/cgo/main.go:287
created by main
    ../../../src/libgo/runtime/go-main.c:42

goroutine 18 [finalizer wait]:

[Bug c/65586] -fopenmp-simd rejects valid input

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65586

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[5 Regression]              |-fopenmp-simd rejects valid
                   |-fopenmp-simd rejects valid |input
                   |input                       |

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
I retraced the regression status: It doesn't seem to compile with GCC 4.9,
either. And I don't know whether it worked with those options before in 5 - I
think I either had both enabled (and optimization) or neither (with -O0 for
debugging.)

[Bug c/65586] -fopenmp-simd rejects valid input

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65586

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-03-26
           Assignee|unassigned at gcc dot gnu.org      |burnus at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Created attachment 35157
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35157&action=edit
Untested draft patch

[Bug c/65586] -fopenmp-simd rejects valid input

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65586

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Comment on attachment 35157
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35157
Untested draft patch

I'd say the C++ parser change is ok, but the C parser change is not, I think
c_parser_skip_until_found will not do
  gcc_assert (parser->in_pragma);
  parser->in_pragma = false;
at the beginning and
  parser->error = false;
at the end.
So, perhaps add (optional?) bool argument to c_parser_skip_to_pragma_eol
whether
it should report the error if not already at CPP_PRAGMA_EOL (the default case),
or whether it should use c_parser_next_token_is/c_parser_consume_token instead?

[Bug c/65586] -fopenmp-simd rejects valid input

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65586

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Fri Mar 27 20:21:52 2015
New Revision: 221744

URL: https://gcc.gnu.org/viewcvs?rev=221744&root=gcc&view=rev
Log:
2015-03-27  Tobias Burnus  <burnus@net-b.de>

        PR c/65586
gcc/c/
        * c-parser.c (c_parser_skip_to_pragma_eol): Optionally, don't
        error out.
        (c_parser_omp_for, c_parser_omp_parallel, c_parser_omp_distribute,
        c_parser_omp_teams, c_parser_omp_target, c_parser_omp_declare):
        Update calls to not error for skipped omp pragmas with -fopenmp-simd.

gcc/cp/
        * parser.c (cp_parser_omp_for, cp_parser_omp_parallel,
        cp_parser_omp_distribute, cp_parser_omp_teams, cp_parser_omp_target,
        cp_parser_omp_declare): Don't show error for skipped omp pragmas
        with -fopenmp-simd.

gcc/testsuite/
        * g++.dg/gomp/openmp-simd-3.C: New.
        * gcc.dg/gomp/openmp-simd-3.c: New.


Added:
    trunk/gcc/testsuite/g++.dg/gomp/openmp-simd-3.C
    trunk/gcc/testsuite/gcc.dg/gomp/openmp-simd-3.c
Modified:
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-parser.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/65586] -fopenmp-simd rejects valid input

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65586

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED on the GCC 5 trunk.