From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112094 invoked by alias); 27 Mar 2015 12:51:32 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 112049 invoked by uid 48); 27 Mar 2015 12:51:29 -0000 From: "manu at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/65598] Fix column location for 'explicit' Date: Fri, 27 Mar 2015 13:15:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Version: 4.9.1 X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: trivial X-Bugzilla-Who: manu at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on cc resolution short_desc everconfirmed Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg03145.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D65598 Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |NEW Last reconfirmed| |2015-03-27 CC| |manu at gcc dot gnu.org Resolution|DUPLICATE |--- Summary|Misleading error message |Fix column location for |for out-of-class definition |'explicit' |of explicit conversion | |operator | Ever confirmed|0 |1 --- Comment #3 from Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez --- (In reply to Jonathan Wakely from comment #1) > GCC 5 says: >=20 > e.cc:6:42: error: =E2=80=98explicit=E2=80=99 outside class declaration > explicit ExplicitTest::operator bool() const > ^ >=20 > (The caret position is a well known issue with all error locations, there= is > work being done to improve things.) I don't think we have a bug open for 'explicit', so this one could be it. I= t is probably an EasyHack ideal for a new contributor. Please consider submittin= g a patch: https://gcc.gnu.org/wiki/GettingStarted#Basics:_Contributing_to_GCC_in_10_e= asy_steps Small patches don't need any copyright assignment! >>From gcc-bugs-return-482002-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Mar 27 12:58:28 2015 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 531 invoked by alias); 27 Mar 2015 12:58:27 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 450 invoked by uid 55); 27 Mar 2015 12:58:23 -0000 From: "hubicka at ucw dot cz" To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/65600] [5 Regression] bost testsuite failure: ICE: Segmentation fault Date: Fri, 27 Mar 2015 13:29:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at ucw dot cz X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg03146.txt.bz2 Content-length: 1347 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65600 --- Comment #2 from Jan Hubicka --- Oops, really hope this is last one of this can of worms :( The problem here is that resolve_speculation assumes the cgraph node exists. I am testing the following: Index: ipa-inline-analysis.c =================================================================== --- ipa-inline-analysis.c (revision 221725) +++ ipa-inline-analysis.c (working copy) @@ -766,15 +766,15 @@ static struct cgraph_edge * redirect_to_unreachable (struct cgraph_edge *e) { struct cgraph_node *callee = !e->inline_failed ? e->callee : NULL; + struct cgraph_node *target = cgraph_node::get_create + (builtin_decl_implicit (BUILT_IN_UNREACHABLE)); if (e->speculative) - e = e->resolve_speculation (builtin_decl_implicit (BUILT_IN_UNREACHABLE)); + e = e->resolve_speculation (target->decl); else if (!e->callee) - e->make_direct (cgraph_node::get_create - (builtin_decl_implicit (BUILT_IN_UNREACHABLE))); + e->make_direct (target); else - e->redirect_callee (cgraph_node::get_create - (builtin_decl_implicit (BUILT_IN_UNREACHABLE))); + e->redirect_callee (target); struct inline_edge_summary *es = inline_edge_summary (e); e->inline_failed = CIF_UNREACHABLE; e->frequency = 0;