[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |vmakarov at gcc dot gnu.org
   Target Milestone|---                         |5.0

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ra
             Target|                            |arm-none-eabi
           Priority|P3                          |P1

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-04-02
                 CC|                            |law at redhat dot com
           Assignee|unassigned at gcc dot gnu.org      |vmakarov at redhat dot com
     Ever confirmed|0                           |1

--- Comment #1 from Jeffrey A. Law <law at redhat dot com> ---
The dumps would seem to indicate LRA is stuck in a loop trying to reload
something.

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #3 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Author: vmakarov
Date: Sat Apr  4 14:35:59 2015
New Revision: 221867

URL: https://gcc.gnu.org/viewcvs?rev=221867&root=gcc&view=rev
Log:
2015-04-04  Vladimir Makarov  <vmakarov@redhat.com>

    PR target/65647
    * lra-int.h (LRA_MAX_REMATERIALIZATION_PASSES): New.  Add its
    value checking.
    (lra_rematerialization_iter): New.
    * lra.c (lra): Initialize lra_rematerialization_iter.
    Stop updating lra_constraint_new_regno_start after switching of
    inheritance and rematerialization.
    * lra-remat.c (lra_rematerialization_iter): New.
    (lra_remat): Add printing pass iteration.  Do rematerialization
    only first LRA_MAX_REMATERIALIZATION_PASSES iterations.

2015-04-04  Vladimir Makarov  <vmakarov@redhat.com>

    PR target/65647
    * gcc.target/arm/pr65647.c: New.


Added:
    trunk/gcc/testsuite/gcc.target/arm/pr65647.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lra-int.h
    trunk/gcc/lra-remat.c
    trunk/gcc/lra.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[yroux at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

Yvan Roux <yroux at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yroux at gcc dot gnu.org

--- Comment #4 from Yvan Roux <yroux at gcc dot gnu.org> ---
I was about to report the same issue which occurs during the build of videolan
x264 build. Vlad patch fixes the issue on trunk, but with that testcase the
problem is also present in 4.9 branch (it occurs this time in ARM mode on armv6
architecture).

To be backported on 4.9 the rematerialization code as to be removed from the
patch, I'll submit the patch on the mailing list.

command line to reproduce the problem:

cc1 -O3 -marm -march=armv6 -std=c99 a.c

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[yroux at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #5 from Yvan Roux <yroux at gcc dot gnu.org> ---
Created attachment 35229
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35229&action=edit
testcase that fails also on 4.9

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[yroux at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #6 from Yvan Roux <yroux at gcc dot gnu.org> ---
Author: yroux
Date: Sun Apr  5 19:06:43 2015
New Revision: 221873

URL: https://gcc.gnu.org/viewcvs?rev=221873&root=gcc&view=rev
Log:
gcc/
2015-04-05  Yvan Roux  <yvan.roux@linaro.org>

    Backport from trunk r221867
    2015-04-04  Vladimir Makarov  <vmakarov@redhat.com>

    PR target/65647
    * lra.c (lra): Stop updating lra_constraint_new_regno_start after switching
    off inheritance.

gcc/testsuite/
2015-04-05  Yvan Roux  <yvan.roux@linaro.org>

    Backport from trunk r221867
    2015-04-04  Vladimir Makarov <vmakarov@redhat.com>

    PR target/65647
    * gcc.target/arm/pr65647.c: New.
    * gcc.target/arm/pr65647-2.c: New.


Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/pr65647-2.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/arm/pr65647.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/lra.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So fixed?

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

James Greenhalgh <jgreenhalgh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jgreenhalgh at gcc dot gnu.org

--- Comment #8 from James Greenhalgh <jgreenhalgh at gcc dot gnu.org> ---
The new testcase fails for ARM targets configured with --with-float-abi=hard .

  .../gcc/testsuite/gcc.target/arm/pr65647.c:26:8: sorry, unimplemented:
Thumb-1 hard-float VFP ABI

The fix would be to add an explicit -mfloat-abi= option to the testcase, but I
can't guess from the bug report whether that should be soft or softfp. Could
somebody please confirm which it should be and patch the testcase on both
branches?

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #9 from Jeffrey A. Law <law at redhat dot com> ---
Either soft or softfp will trigger the failure.  Given that it's just a compile
test, rather than  link & run test, can we just add a -mfloat-abi=soft to the
test and avoid the dg-skip-if?

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P3

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
In any case, a remaining testsuite issue doesn't deserve P1 at this point.

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[terry.guo at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #11 from Terry Guo <terry.guo at arm dot com> ---
(In reply to Jakub Jelinek from comment #10)
> In any case, a remaining testsuite issue doesn't deserve P1 at this point.

If nobody work on this, I will come up with a patch soon.

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[yroux at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #12 from Yvan Roux <yroux at gcc dot gnu.org> ---
> If nobody work on this, I will come up with a patch soon.

Ok Terry, beside the testsuite issue the problem is fixed for me.

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
The issue is fixed, the testsuite bug is a separate issue.

[Bug target/65647] [5 Regression] GCC won't stop when compile for armv6-m

[terry.guo at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65647

--- Comment #14 from Terry Guo <terry.guo at arm dot com> ---
The test case is already updated with -mfloat-abi=soft.