public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/65701] r221530 makes 187.facerec drop with -Ofast -flto
Date: Thu, 09 Apr 2015 04:08:00 -0000	[thread overview]
Message-ID: <bug-65701-4-Ug5hwEhZsZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65701-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65701

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
The profile difference is:

 52.31%  facerec  facerec            [.] MAIN__.lto_priv.3                     
                                                                               
                           �
 16.68%  facerec  facerec            [.] topcostfct.3487.lto_priv.4            
                                                                               
                           �
  8.28%  facerec  facerec            [.] __gaborroutines_MOD_gabortrafo        
                                                                               
                           �
  7.91%  facerec  facerec            [.] cfftb_                                
                                                                               
                           �
  7.20%  facerec  libgfortran.so.3   [.] _gfortrani_cshift0_r4                 
                                                                               
                           �
  2.76%  facerec  facerec            [.] __fft2d_MOD_fft2db                    
                                                                               
                           �
  1.54%  facerec  facerec            [.]
__graphroutines_MOD_graphsimfct.constprop.0                                    
                                                                  �
  0.53%  facerec  libc-2.13.so       [.] __memcpy_ssse3                        
                                                                               
                           �

(mainline) WRT

 59.16%  facerec  facerec            [.] MAIN__.lto_priv.3                     
                                                                               
                           �
 10.95%  facerec  facerec            [.] __gaborroutines_MOD_gabortrafo        
                                                                               
                           �
 10.51%  facerec  facerec            [.] cfftb1_                               
                                                                               
                           �
  9.33%  facerec  libgfortran.so.3   [.] _gfortrani_cshift0_r4                 
                                                                               
                           �
  3.64%  facerec  facerec            [.] __fft2d_MOD_fft2db                    
                                                                               
                           �
  2.07%  facerec  facerec            [.]
__graphroutines_MOD_graphsimfct.constprop.0                                    
                                                                  �
  0.67%  facerec  libc-2.13.so       [.] __memcpy_ssse3                        
                                                                               
                           �
  0.57%  facerec  libgfortran.so.3   [.] _gfortrani_read_radix                 
                                                                               
                           �
  0.43%  facerec  libgcc_s.so.1      [.] __udivti3                             
                                                                               
                           �
  0.36%  facerec  libgfortran.so.3   [.] formatted_transfer                    
                                                                               
                           �
patch reverted. I wonder if we don't want to iline udivti... I suppose the
problem is that we no longer inline topcostfct which we do not inline
because...

not inlinable: localmove.constprop/304 -> topcostfct/208, --param
large-function-growth limit reached

while patched tree suceeds:

Inlining topcostfct size 1393.
 Called once from localmove.constprop 740 insns.
                Accounting size:1132.00, time:12187.80 on predicate:(true)

Bumping the large-function-insns limit up to 4000 makes the function to be
inlined but curiously enough causes further degradation. The profile is now:

66.35%  facerec  facerec            [.] MAIN__.lto_priv.3                      
                                                                               
                          �
  8.93%  facerec  facerec            [.] __gaborroutines_MOD_gabortrafo        
                                                                               
                           �
  8.72%  facerec  facerec            [.] cfftb_                                
                                                                               
                           �
  7.77%  facerec  libgfortran.so.3   [.] _gfortrani_cshift0_r4                 
                                                                               
                           �
  2.96%  facerec  facerec            [.] __fft2d_MOD_fft2db                    
                                                                               
                           �
  1.68%  facerec  facerec            [.]
__graphroutines_MOD_graphsimfct.constprop.0                                    
                                                                  �
  0.55%  facerec  libc-2.13.so       [.] __memcpy_ssse3                        
                                                                               
                           �
  0.47%  facerec  libgfortran.so.3   [.] _gfortrani_read_radix                 
                                                                               
                           �
  0.34%  facerec  libgcc_s.so.1      [.] __udivti3                             
                                                                               
                           �
  0.30%  facerec  libgfortran.so.3   [.] formatted_transfer                    
                                                                               
                           �
  0.22%  facerec  libgfortran.so.3   [.] next_format0                          
                                                                               
                           �
  0.22%  facerec  facerec            [.] cfftf_                                
                                                                               
                           �
  0.20%  facerec  libgfortran.so.3   [.] _gfortrani_read_block_form            
                                                                               
                           �
so basically identical except that mainline inlines cfftb1_ and the patched
tree inlines cfftb_ which is a wrapper. Perhaps the wrapper heuristics may be
generalized for this.
>From gcc-bugs-return-483062-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 09 04:50:22 2015
Return-Path: <gcc-bugs-return-483062-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 45056 invoked by alias); 9 Apr 2015 04:50:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 45005 invoked by uid 48); 9 Apr 2015 04:50:16 -0000
From: "michal.misiaszek at kofinder dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug gcov-profile/43341] pragma pack changes padding in struct gcov_info on 64-bit archs
Date: Thu, 09 Apr 2015 04:50:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: gcov-profile
X-Bugzilla-Version: 4.5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: michal.misiaszek at kofinder dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-43341-4-cbhV8gJfzw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-43341-4@http.gcc.gnu.org/bugzilla/>
References: <bug-43341-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-04/txt/msg00614.txt.bz2
Content-length: 1501

https://gcc.gnu.org/bugzilla/show_bug.cgi?idC341

Michal Misiaszek <michal.misiaszek at kofinder dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michal.misiaszek at kofinder dot c
                   |                            |om

--- Comment #8 from Michal Misiaszek <michal.misiaszek at kofinder dot com> ---
Hi,
I was strglign for last 2 night with my aplication which generated coverage
files for all source files but one. At the end I found out that C++ file was
including .h file. If I commented out .h file then coverage was generated.
Only unusual thing I noticed was #pragma pack(1).
When I removed it the coverage was generated again !
Short search I found this bug. I can reproduce it all the time.
The version of g++ and gcov below
:
michal@ubuntu:~/git/blpr$ g++ --version
g++ (Ubuntu 4.9.1-16ubuntu6) 4.9.1
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

michal@ubuntu:~/git/blpr$ gcov --version
gcov (Ubuntu 4.9.1-16ubuntu6) 4.9.1
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.

Can you somehow patch it ?
Regards
Michal


  parent reply	other threads:[~2015-04-09  4:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 13:41 [Bug ipa/65701] New: " rguenth at gcc dot gnu.org
2015-04-08 13:45 ` [Bug ipa/65701] " rguenth at gcc dot gnu.org
2015-04-08 13:47 ` rguenth at gcc dot gnu.org
2015-04-08 16:37 ` hubicka at gcc dot gnu.org
2015-04-09  0:03 ` hubicka at gcc dot gnu.org
2015-04-09  4:08 ` hubicka at gcc dot gnu.org [this message]
2015-04-09 17:44 ` hubicka at gcc dot gnu.org
2015-04-09 17:56 ` hubicka at gcc dot gnu.org
2015-04-09 18:19 ` hubicka at gcc dot gnu.org
2015-04-09 19:40 ` hubicka at gcc dot gnu.org
2015-04-09 19:45 ` hubicka at gcc dot gnu.org
2015-04-10  9:10 ` rguenth at gcc dot gnu.org
2015-04-10  9:35 ` rguenth at gcc dot gnu.org
2015-04-10 10:09 ` [Bug ipa/65701] [5 Regression] r221530 makes 187.facerec drop with -Ofast -flto on bdver2 rguenth at gcc dot gnu.org
2015-04-10 19:46 ` hubicka at gcc dot gnu.org
2015-04-12 22:42 ` [Bug ipa/65701] [5/6 " hubicka at gcc dot gnu.org
2015-04-15  7:57 ` rguenth at gcc dot gnu.org
2015-05-22  9:09 ` rguenth at gcc dot gnu.org
2015-05-26 11:05 ` [Bug ipa/65701] [5 " rguenth at gcc dot gnu.org
2015-07-16  9:16 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65701-4-Ug5hwEhZsZ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).