[Bug target/65711] New: arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[Bug target/65711] New: arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ludo at gnu dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

            Bug ID: 65711
           Summary: arm*-linux* "link" spec passes '-dynamic-linker' even
                    for '-shared'
           Product: gcc
           Version: 4.9.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ludo at gnu dot org

gcc/config/arm/linux-elf.h defines LINUX_TARGET_LINK_SPEC to (simplified):

  %{!static -dynamic-linker LINKER}

However, '-dynamic-linker' should not be passed when '-shared' is used.  The
correct way appears to be what config/i386/gnu-user.h does, which is:

  %{!static %{!shared -dynamic-linker LINKER}}

I believe the attached patch fixes that.  At least both 4.8.4 and 4.9.2 are
affected.

(Initially discussed in the context of <http://bugs.gnu.org/20102>.)

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ludo at gnu dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

Ludovic Courtès <ludo at gnu dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ludo at gnu dot org

--- Comment #1 from Ludovic Courtès <ludo at gnu dot org> ---
Created attachment 35270
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35270&action=edit
Proposed patch
>From gcc-bugs-return-483082-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 09 08:11:03 2015
Return-Path: <gcc-bugs-return-483082-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 122118 invoked by alias); 9 Apr 2015 08:11:02 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 122054 invoked by uid 48); 9 Apr 2015 08:10:59 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/65702] [5 Regression] ICE (tree check: expected ssa_name, have var_decl in expand_gimple_basic_block, at cfgexpand.c:5506) on arm-linux-gnueabihf
Date: Thu, 09 Apr 2015 08:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: error-recovery, ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-65702-4-TygGHLqOHe@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65702-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65702-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-04/txt/msg00634.txt.bz2
Content-length: 227

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide702

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
If you clear DECL_HARD_REGISTER the decl becomes is_gimple_reg and you are
expected to write it into SSA.

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ludo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #3 from ludo at gcc dot gnu.org ---
Author: ludo
Date: Tue Jun 23 09:06:55 2015
New Revision: 224826

URL: https://gcc.gnu.org/viewcvs?rev=224826&root=gcc&view=rev
Log:
        PR 65711
        * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
        '-dynamic-linker' within %{!shared: ...}.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/linux-elf.h

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ludo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #4 from ludo at gcc dot gnu.org ---
Author: ludo
Date: Tue Jun 23 09:16:14 2015
New Revision: 224828

URL: https://gcc.gnu.org/viewcvs?rev=224828&root=gcc&view=rev
Log:
        PR 65711
        * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
        '-dynamic-linker' within %{!shared: ...}.

Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/arm/linux-elf.h

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ludo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #5 from ludo at gcc dot gnu.org ---
Author: ludo
Date: Tue Jun 23 09:21:44 2015
New Revision: 224829

URL: https://gcc.gnu.org/viewcvs?rev=224829&root=gcc&view=rev
Log:
        PR 65711
        * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
        '-dynamic-linker' within %{!shared: ...}.

Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/arm/linux-elf.h

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ludo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #6 from ludo at gcc dot gnu.org ---
Author: ludo
Date: Tue Jun 23 09:26:54 2015
New Revision: 224830

URL: https://gcc.gnu.org/viewcvs?rev=224830&root=gcc&view=rev
Log:
        PR 65711
        * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
        '-dynamic-linker' within %{!shared: ...}.

Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/arm/linux-elf.h

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.3

--- Comment #7 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed.

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[nsz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #8 from nsz at gcc dot gnu.org ---
Author: nsz
Date: Fri Jul 24 14:27:55 2015
New Revision: 226158

URL: https://gcc.gnu.org/viewcvs?rev=226158&root=gcc&view=rev
Log:
[AArch64] Fix LINUX_TARGET_LINK_SPEC to be consistent with ARM

2015-07-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>

        PR target/65711
        * config/aarch64/aarch64-linux.h (LINUX_TARGET_LINK_SPEC): Move
        -dynamic-linker within %{!static %{!shared, and -rdynamic within
        %{!static.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/aarch64/aarch64-linux.h

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[nsz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #9 from nsz at gcc dot gnu.org ---
Author: nsz
Date: Fri Jul 24 16:00:26 2015
New Revision: 226165

URL: https://gcc.gnu.org/viewcvs?rev=226165&root=gcc&view=rev
Log:
        Backport from mainline r226158.
        2015-07-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>

        PR target/65711
        * config/aarch64/aarch64-linux.h (LINUX_TARGET_LINK_SPEC): Move
        -dynamic-linker within %{!static %{!shared, and -rdynamic within
        %{!static.

Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/aarch64/aarch64-linux.h

[Bug target/65711] arm*-linux* "link" spec passes '-dynamic-linker' even for '-shared'

[nsz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711

--- Comment #10 from nsz at gcc dot gnu.org ---
Author: nsz
Date: Fri Jul 24 16:12:58 2015
New Revision: 226169

URL: https://gcc.gnu.org/viewcvs?rev=226169&root=gcc&view=rev
Log:
        Backported from mainline r226158.
        2015-07-24  Szabolcs Nagy  <szabolcs.nagy@arm.com>

        PR target/65711
        * config/aarch64/aarch64-linux.h (LINUX_TARGET_LINK_SPEC): Move
        -dynamic-linker within %{!static %{!shared, and -rdynamic within
        %{!static.


Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/aarch64/aarch64-linux.h