From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91246 invoked by alias); 16 Apr 2015 18:14:38 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 80999 invoked by uid 48); 16 Apr 2015 18:14:34 -0000 From: "law at redhat dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/65780] [5/6 Regression] Uninitialized common handling in executables Date: Thu, 16 Apr 2015 18:14:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: law at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-04/txt/msg01375.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65780 --- Comment #29 from Jeffrey A. Law --- Oh how I wish all this stuff was better documented, both in the GCC sources and at a higher level in some linkers/loaders documentation. ix86_binds_local_p needs a function comment. I think with a function comment, no comments would be needed in the function body. I think it's also advisable to get a function comment for the default_binds_local* that don't currently have one. What I'm trying to wrap my head around is what "defined_locally" really means. Is it a "must" or "maybe" property when it gets set in default_binds_local_p_3? If it's a must property, then "common_maybe_local" seems mis-named and/or mis-used (the former seems most likely to me). If it's a maybe property, then why is a common uninit local filtered out? At this point we don't know if a common uninit local will be defined locally or not, so it's a maybe. I can probably go forward with an approval or specific change recommendations that would lead to approval once someone can tell me if defined_locally is a maybe or must property.