public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/65780] [5/6 Regression] Uninitialized common handling in executables Date: Thu, 16 Apr 2015 18:36:00 -0000 [thread overview] Message-ID: <bug-65780-4-DgX3oqDf9f@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-65780-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65780 --- Comment #31 from H.J. Lu <hjl.tools at gmail dot com> --- (In reply to Jeffrey A. Law from comment #29) > Oh how I wish all this stuff was better documented, both in the GCC sources > and at a higher level in some linkers/loaders documentation. > > ix86_binds_local_p needs a function comment. I think with a function > comment, no comments would be needed in the function body. Updated. > I think it's also advisable to get a function comment for the > default_binds_local* that don't currently have one. That can be done in a flow-up patch. > What I'm trying to wrap my head around is what "defined_locally" really > means. Is it a "must" or "maybe" property when it gets set in > default_binds_local_p_3? > > If it's a must property, then "common_maybe_local" seems mis-named and/or > mis-used (the former seems most likely to me). > > If it's a maybe property, then why is a common uninit local filtered out? > At this point we don't know if a common uninit local will be defined locally > or not, so it's a maybe. > > I can probably go forward with an approval or specific change > recommendations that would lead to approval once someone can tell me if > defined_locally is a maybe or must property. A common symbol in PIC will never be local, for any targets, unless it has hidden/internal visibility.
next prev parent reply other threads:[~2015-04-16 18:36 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-15 22:29 [Bug target/65780] New: [5 " jakub at gcc dot gnu.org 2015-04-15 22:30 ` [Bug target/65780] " jakub at gcc dot gnu.org 2015-04-15 23:01 ` james410 at cowgill dot org.uk 2015-04-15 23:13 ` hjl.tools at gmail dot com 2015-04-15 23:41 ` hjl.tools at gmail dot com 2015-04-16 0:37 ` amodra at gmail dot com 2015-04-16 2:10 ` hjl.tools at gmail dot com 2015-04-16 2:38 ` hjl.tools at gmail dot com 2015-04-16 3:22 ` [Bug target/65780] [5 Regression] Uninitialized common handling in PIE hjl.tools at gmail dot com 2015-04-16 3:28 ` [Bug target/65780] [5 Regression] Uninitialized common handling in executables amodra at gmail dot com 2015-04-16 4:32 ` hjl.tools at gmail dot com 2015-04-16 7:33 ` jakub at gcc dot gnu.org 2015-04-16 7:39 ` [Bug target/65780] [5/6 " rguenth at gcc dot gnu.org 2015-04-16 7:46 ` jakub at gcc dot gnu.org 2015-04-16 11:09 ` jakub at gcc dot gnu.org 2015-04-16 11:12 ` hjl.tools at gmail dot com 2015-04-16 11:20 ` hjl.tools at gmail dot com 2015-04-16 11:40 ` hjl.tools at gmail dot com 2015-04-16 11:44 ` jakub at gcc dot gnu.org 2015-04-16 11:46 ` hjl.tools at gmail dot com 2015-04-16 11:53 ` hjl.tools at gmail dot com 2015-04-16 12:12 ` jakub at gcc dot gnu.org 2015-04-16 12:33 ` hjl.tools at gmail dot com 2015-04-16 12:41 ` jakub at gcc dot gnu.org 2015-04-16 13:08 ` hjl.tools at gmail dot com 2015-04-16 13:10 ` jakub at gcc dot gnu.org 2015-04-16 13:16 ` hjl.tools at gmail dot com 2015-04-16 15:36 ` jakub at gcc dot gnu.org 2015-04-16 16:09 ` hjl.tools at gmail dot com 2015-04-16 18:14 ` law at redhat dot com 2015-04-16 18:33 ` hjl.tools at gmail dot com 2015-04-16 18:36 ` hjl.tools at gmail dot com [this message] 2015-04-16 19:20 ` law at redhat dot com 2015-04-16 19:28 ` hjl.tools at gmail dot com 2015-04-16 21:03 ` jakub at gcc dot gnu.org 2015-04-16 22:02 ` hjl.tools at gmail dot com 2015-04-17 16:12 ` law at redhat dot com 2015-04-17 16:26 ` [Bug target/65780] [5 " hjl.tools at gmail dot com 2015-04-17 16:30 ` jakub at gcc dot gnu.org 2015-04-17 16:36 ` hjl at gcc dot gnu.org 2015-04-17 16:37 ` hjl.tools at gmail dot com 2015-04-17 21:14 ` dominiq at lps dot ens.fr 2015-04-17 21:54 ` hjl at gcc dot gnu.org 2015-04-17 21:55 ` hjl at gcc dot gnu.org 2015-04-17 23:16 ` howarth.at.gcc at gmail dot com 2015-04-18 5:36 ` jakub at gcc dot gnu.org 2015-04-21 14:14 ` evstupac at gmail dot com 2015-04-21 14:18 ` jakub at gcc dot gnu.org 2015-05-11 7:09 ` jakub at gcc dot gnu.org 2015-05-11 7:14 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-65780-4-DgX3oqDf9f@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).