public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wdijkstr at arm dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/65862] [MIPS] IRA/LRA issue: integers spilled to floating-point registers
Date: Mon, 27 Apr 2015 17:13:00 -0000	[thread overview]
Message-ID: <bug-65862-4-TVhbwbJqYE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65862-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65862

--- Comment #4 from Wilco <wdijkstr at arm dot com> ---
(In reply to Vladimir Makarov from comment #3)

But I can not just revert the patch making ALL_REGS available
> to make
coloring heuristic more fotunate for your particular case, as it
> reopens the old PR for which the patch was created and i have no other
> solutions for the old PR.

I tried reverting the ALL_REGS patch and I don't see any regressions - in fact
allocations are slightly better (fewer registers with ALL_REGS preference which
is what we need - a strong decision to allocate to either FP or int regs). So
what was the motivation for it?

Note that it would be trivial to prefer ALL_REGS for some operands if
necessary. The only case I can imagine is load and store which on some targets
are quite orthogonal. I tried doing m=r#w and m=w#r on AArch64 and that works
fine (this tells the preferencing code that ALL_REGS is best but it still keeps
a clear INT/FP separation in the patterns which you may need for disassembly
etc).

IMHO that is a better solution than to automatically change the patterns r=r+r;
w=w+w into rw=rw+rw and assume that ALL_REGS preference on all operands has
zero cost eventhough the cost calculation explicitly states otherwise.


  parent reply	other threads:[~2015-04-27 17:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 16:04 [Bug rtl-optimization/65862] New: " robert.suchanek at imgtec dot com
2015-04-23 16:09 ` [Bug rtl-optimization/65862] " pinskia at gcc dot gnu.org
2015-04-23 16:54 ` robert.suchanek at imgtec dot com
2015-04-27 16:17 ` vmakarov at gcc dot gnu.org
2015-04-27 17:13 ` wdijkstr at arm dot com [this message]
2015-05-06 16:13 ` robert.suchanek at imgtec dot com
2015-05-06 16:21 ` matthew.fortune at imgtec dot com
2015-05-07 18:55 ` vmakarov at gcc dot gnu.org
2015-05-08 18:29 ` vmakarov at gcc dot gnu.org
2015-05-12 20:38 ` vmakarov at gcc dot gnu.org
2015-05-13  7:53 ` robert.suchanek at imgtec dot com
2015-05-14 14:20 ` wdijkstr at arm dot com
2015-05-14 20:41 ` vmakarov at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65862-4-TVhbwbJqYE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).