[Bug libstdc++/65883] New: numeric_limits<unsigned __int128>::max() returns incorrect value

[Bug libstdc++/65883] New: numeric_limits<unsigned __int128>::max() returns incorrect value

[john at johnmaddock dot co.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65883

            Bug ID: 65883
           Summary: numeric_limits<unsigned __int128>::max() returns
                    incorrect value
           Product: gcc
           Version: 5.1.0
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: john at johnmaddock dot co.uk

std::numeric_limits<unsigned __int128>::max() returns
0x7fffffffffffffffffffffffffffffff which is definitely not 2^128-1.  Looks like
a cut and paste error from numeric_limits<__int128>?

This is on Xubuntu 64-bit.

This is a showstopper for Boost.Multiprecision which has asserts that are
incorrectly triggered by the bug.

Regards, John Maddock.

[Bug libstdc++/65883] [5/6 Regression] numeric_limits<unsigned __int128>::max() returns incorrect value

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65883

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-04-25
            Summary|numeric_limits<unsigned     |[5/6 Regression]
                   |__int128>::max() returns    |numeric_limits<unsigned
                   |incorrect value             |__int128>::max() returns
                   |                            |incorrect value
     Ever confirmed|0                           |1

--- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> ---
Indeed, the specialization for struct numeric_limits<unsigned TYPE> uses TYPE
instead of unsigned TYPE for max :-(

[Bug libstdc++/65883] [5/6 Regression] numeric_limits<unsigned __int128>::max() returns incorrect value

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65883

--- Comment #2 from Marc Glisse <glisse at gcc dot gnu.org> ---
Author: glisse
Date: Tue Apr 28 19:35:49 2015
New Revision: 222540

URL: https://gcc.gnu.org/viewcvs?rev=222540&root=gcc&view=rev
Log:
2015-04-28  Marc Glisse  <marc.glisse@inria.fr>

        PR libstdc++/65883
        * include/std/limits (numeric_limits): Add missing unsigned.


Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/std/limits

[Bug libstdc++/65883] [5 Regression] numeric_limits<unsigned __int128>::max() returns incorrect value

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65883

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
      Known to work|                            |4.9.2, 6.0
   Target Milestone|---                         |5.2
            Summary|[5/6 Regression]            |[5 Regression]
                   |numeric_limits<unsigned     |numeric_limits<unsigned
                   |__int128>::max() returns    |__int128>::max() returns
                   |incorrect value             |incorrect value
      Known to fail|                            |5.1.0

--- Comment #3 from Marc Glisse <glisse at gcc dot gnu.org> ---
Fixed on trunk. This needs to be backported to 5, but I don't have time to do
it right now, anyone feel free...

[Bug libstdc++/65883] [5 Regression] numeric_limits<unsigned __int128>::max() returns incorrect value

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65883

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Mon May  4 18:20:10 2015
New Revision: 222772

URL: https://gcc.gnu.org/viewcvs?rev=222772&root=gcc&view=rev
Log:
        Backported from mainline
        2015-04-28  Marc Glisse  <marc.glisse@inria.fr>

        PR libstdc++/65883
        * include/std/limits (numeric_limits): Add missing unsigned.

Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/include/std/limits

[Bug libstdc++/65883] [5 Regression] numeric_limits<unsigned __int128>::max() returns incorrect value

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65883

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Done now.