[Bug fortran/65903] New: Line continuation followed by comment character in string fails to compile

[Bug fortran/65903] New: Line continuation followed by comment character in string fails to compile

[laurent.chardon at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

            Bug ID: 65903
           Summary: Line continuation followed by comment character in
                    string fails to compile
           Product: gcc
           Version: 5.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: laurent.chardon at gmail dot com
  Target Milestone: ---

Created attachment 35405
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35405&action=edit
Test case that fails when zero or more blank characters separate an & and a !
in a string

The fix implemented for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64506 has
introduced a new bug. Now when a string contains the characters "&!" next to
each other, the scanner erroneously deletes the rest of the line.

The attached test case shows the problem.

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-04-29
            Summary|Line continuation followed  |[5/6 Regression] Line
                   |by comment character in     |continuation followed by
                   |string fails to compile     |comment character in string
                   |                            |fails to compile
     Ever confirmed|0                           |1

--- Comment #2 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
This is a regression.

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

--- Comment #3 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Possible path here:

https://gcc.gnu.org/ml/fortran/2015-05/msg00071.html

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[laurent.chardon at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

--- Comment #4 from Laurent Chardon <laurent.chardon at gmail dot com> ---
Thanks for the fix. If I may suggest a modification of the testcase in order to
check also when there are no blanks between the & and !. I know in Fortran it
shouldn't matter, but I don't see any harm in making sure... 

! { dg-do run }
! { dg-options "-std=gnu" }
! 
character(20) :: astring

100 format ("& notblank !")
200 format ("&          !")
300 format ("&!")

write(astring,100)
if (astring.ne."& notblank !") call abort
!print *, astring
write(astring,200)
if (astring.ne."&          !") call abort
!print *, astring
write(astring,300)
if (astring.ne."&!") call abort
!print *, astring

end

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

--- Comment #7 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sat May 16 17:51:41 2015
New Revision: 223249

URL: https://gcc.gnu.org/viewcvs?rev=223249&root=gcc&view=rev
Log:
2015-05-16  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/65903
        * gfortran.dg/continuation_13.f90: Update test.
        * gfortran.dg/pr65903.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr65903.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/continuation_13.f90

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

--- Comment #8 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Wed May 20 01:50:34 2015
New Revision: 223428

URL: https://gcc.gnu.org/viewcvs?rev=223428&root=gcc&view=rev
Log:
2015-05-19  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/65903
        * io.c (format_lex): Change to NONSTRING when checking for
        possible doubled quote.
        * scanner.c (gfc_next_char_literal): Revert change from 64506
        and add a check for quotes and return.

Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/io.c
    branches/gcc-5-branch/gcc/fortran/scanner.c

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

--- Comment #9 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Wed May 20 01:51:50 2015
New Revision: 223429

URL: https://gcc.gnu.org/viewcvs?rev=223429&root=gcc&view=rev
Log:
2015-05-19  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/65903
        * gfortran.dg/continuation_13.f90: Update test.
        * gfortran.dg/pr65903.f90: New test.

Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr65903.f90
Modified:
    branches/gcc-5-branch/gcc/testsuite/ChangeLog
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/continuation_13.f90

[Bug fortran/65903] [5/6 Regression] Line continuation followed by comment character in string fails to compile

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65903

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Fixed on trunk and 5.1.  closing