[Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen

[Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

            Bug ID: 65911
           Summary: [6 Regression] r222508 breaks clang-tblgen
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
                CC: tbsaunde at gcc dot gnu.org
  Target Milestone: ---

Starting with r222508 LLVM doesn't build anymore on ppc64le:

trippels@gcc2-power8 llvm_build % ./bin/clang-tblgen -gen-clang-attr-impl -I
/home/trippels/llvm/tools/clang/include/clang/AST/../../ -I
/home/trippels/llvm/tools/clang/include/clang/AST -I
/home/trippels/llvm/lib/Target -I /home/trippels/llvm/include
/home/trippels/llvm/tools/clang/include/clang/AST/../Basic/Attr.td -o
/home/trippels/llvm_build/tools/clang/include/clang/AST/AttrImpl.inc.tmp
Program received signal SIGSEGV, Segmentation fault.
0x00003fffb79d1ee4 in __strcmp_power7 () from /lib64/libc.so.6
(gdb) bt
#0  0x00003fffb79d1ee4 in __strcmp_power7 () from /lib64/libc.so.6
#1  0x000000001005c504 in llvm::cl::generic_parser_base::findOption(char
const*) ()
#2  0x0000000010004f9c in _GLOBAL__sub_I_TableGen.cpp ()

[Bug other/65911] [6 Regression] r222508 breaks clang-tblgen

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-04-28
     Ever confirmed|0                           |1

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
It's the ternary operator that causes the issue. 
The following patch works fine:

diff --git a/gcc/function.c b/gcc/function.c
index d1a2c0a..0930bb0 100644
--- a/gcc/function.c
+++ b/gcc/function.c
@@ -4195,9 +4195,9 @@ pad_to_arg_alignment (struct args_size *offset_ptr, int
boundary,
       else
        {
          offset_ptr->constant = -sp_offset +
-           ARGS_GROW_DOWNWARD ?
+           (ARGS_GROW_DOWNWARD ?
            FLOOR_ROUND (offset_ptr->constant + sp_offset, boundary_in_bytes) :
-           CEIL_ROUND (offset_ptr->constant + sp_offset, boundary_in_bytes);
+           CEIL_ROUND (offset_ptr->constant + sp_offset, boundary_in_bytes));

            if (boundary > PARM_BOUNDARY)
              alignment_pad->constant = offset_ptr->constant - save_constant;

[Bug other/65911] [6 Regression] r222508 breaks clang-tblgen

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
pre-approved.

[Bug other/65911] [6 Regression] r222508 breaks clang-tblgen

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The formatting is also wrong, both ? and : shouldn't be at the end of lines,
but at the start.  Patch with the formatting fixes included preapproved for
trunk.

[Bug other/65911] [6 Regression] r222508 breaks clang-tblgen

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

--- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Author: trippels
Date: Tue Apr 28 10:09:43 2015
New Revision: 222521

URL: https://gcc.gnu.org/viewcvs?rev=222521&root=gcc&view=rev
Log:
Fix PR65911

2015-04-28  Markus Trippelsdorf  <markus@trippelsdorf.de>

        PR other/65911
        * function.c (pad_to_arg_alignment): Add parentheses.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/function.c

[Bug other/65911] [6 Regression] r222508 breaks clang-tblgen

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Fixed.

[Bug other/65911] [6 Regression] r222508 breaks clang-tblgen

[tbsaunde at tbsaunde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911

--- Comment #6 from tbsaunde at tbsaunde dot org ---
On Tue, Apr 28, 2015 at 03:59:05AM +0000, trippels at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
> 
> Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |NEW
>    Last reconfirmed|                            |2015-04-28
>      Ever confirmed|0                           |1
> 
> --- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
> It's the ternary operator that causes the issue. 
> The following patch works fine:

huh, thanks for figuring it out!

Trev