* [Bug other/65911] [6 Regression] r222508 breaks clang-tblgen
2015-04-28 8:22 [Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen trippels at gcc dot gnu.org
@ 2015-04-28 9:29 ` trippels at gcc dot gnu.org
2015-04-28 9:36 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-04-28 9:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-04-28
Ever confirmed|0 |1
--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
It's the ternary operator that causes the issue.
The following patch works fine:
diff --git a/gcc/function.c b/gcc/function.c
index d1a2c0a..0930bb0 100644
--- a/gcc/function.c
+++ b/gcc/function.c
@@ -4195,9 +4195,9 @@ pad_to_arg_alignment (struct args_size *offset_ptr, int
boundary,
else
{
offset_ptr->constant = -sp_offset +
- ARGS_GROW_DOWNWARD ?
+ (ARGS_GROW_DOWNWARD ?
FLOOR_ROUND (offset_ptr->constant + sp_offset, boundary_in_bytes) :
- CEIL_ROUND (offset_ptr->constant + sp_offset, boundary_in_bytes);
+ CEIL_ROUND (offset_ptr->constant + sp_offset, boundary_in_bytes));
if (boundary > PARM_BOUNDARY)
alignment_pad->constant = offset_ptr->constant - save_constant;
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/65911] [6 Regression] r222508 breaks clang-tblgen
2015-04-28 8:22 [Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen trippels at gcc dot gnu.org
2015-04-28 9:29 ` [Bug other/65911] " trippels at gcc dot gnu.org
@ 2015-04-28 9:36 ` rguenth at gcc dot gnu.org
2015-04-28 9:38 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-04-28 9:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |6.0
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
pre-approved.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/65911] [6 Regression] r222508 breaks clang-tblgen
2015-04-28 8:22 [Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen trippels at gcc dot gnu.org
2015-04-28 9:29 ` [Bug other/65911] " trippels at gcc dot gnu.org
2015-04-28 9:36 ` rguenth at gcc dot gnu.org
@ 2015-04-28 9:38 ` jakub at gcc dot gnu.org
2015-04-28 10:10 ` trippels at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-04-28 9:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The formatting is also wrong, both ? and : shouldn't be at the end of lines,
but at the start. Patch with the formatting fixes included preapproved for
trunk.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/65911] [6 Regression] r222508 breaks clang-tblgen
2015-04-28 8:22 [Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen trippels at gcc dot gnu.org
` (2 preceding siblings ...)
2015-04-28 9:38 ` jakub at gcc dot gnu.org
@ 2015-04-28 10:10 ` trippels at gcc dot gnu.org
2015-04-28 10:21 ` trippels at gcc dot gnu.org
2015-04-28 14:42 ` tbsaunde at tbsaunde dot org
5 siblings, 0 replies; 7+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-04-28 10:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
--- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Author: trippels
Date: Tue Apr 28 10:09:43 2015
New Revision: 222521
URL: https://gcc.gnu.org/viewcvs?rev=222521&root=gcc&view=rev
Log:
Fix PR65911
2015-04-28 Markus Trippelsdorf <markus@trippelsdorf.de>
PR other/65911
* function.c (pad_to_arg_alignment): Add parentheses.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/function.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/65911] [6 Regression] r222508 breaks clang-tblgen
2015-04-28 8:22 [Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen trippels at gcc dot gnu.org
` (3 preceding siblings ...)
2015-04-28 10:10 ` trippels at gcc dot gnu.org
@ 2015-04-28 10:21 ` trippels at gcc dot gnu.org
2015-04-28 14:42 ` tbsaunde at tbsaunde dot org
5 siblings, 0 replies; 7+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-04-28 10:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/65911] [6 Regression] r222508 breaks clang-tblgen
2015-04-28 8:22 [Bug other/65911] New: [6 Regression] r222508 breaks clang-tblgen trippels at gcc dot gnu.org
` (4 preceding siblings ...)
2015-04-28 10:21 ` trippels at gcc dot gnu.org
@ 2015-04-28 14:42 ` tbsaunde at tbsaunde dot org
5 siblings, 0 replies; 7+ messages in thread
From: tbsaunde at tbsaunde dot org @ 2015-04-28 14:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
--- Comment #6 from tbsaunde at tbsaunde dot org ---
On Tue, Apr 28, 2015 at 03:59:05AM +0000, trippels at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65911
>
> Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Status|UNCONFIRMED |NEW
> Last reconfirmed| |2015-04-28
> Ever confirmed|0 |1
>
> --- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
> It's the ternary operator that causes the issue.
> The following patch works fine:
huh, thanks for figuring it out!
Trev
^ permalink raw reply [flat|nested] 7+ messages in thread