From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 480433857C4F; Wed, 28 Jun 2023 11:39:55 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 480433857C4F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1687952395;
	bh=lYrpDd8RMtVCdBRT/vMiZBtyaAC66lEKLEobEAFg/fc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=G7GNyLpreNM6vmdQELGJoV6Q0b/PdQYFSzoJcCy0O/bgLEvFT0k9W3lc+6bfQI2nx
	 8ktigodIfhB65PRAE5gXUOJVIsq8BNkV3pHYFNcjqFWeRPQ55SvfDFiInd2syKCyqW
	 6KC5zsxYuT7Tq8shai6Z4iIY14F74R10IjkEw/a8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/66005] libgomp make check time is excessive
Date: Wed, 28 Jun 2023 11:39:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: openacc, openmp, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: tschwinge at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-66005-4-LesYPDx7ko@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66005-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66005-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D66005

--- Comment #25 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Thomas Schwinge
<tschwinge@gcc.gnu.org>:

https://gcc.gnu.org/g:09124b7ed7709721e86556b4083ef40925d7489b

commit r13-7495-g09124b7ed7709721e86556b4083ef40925d7489b
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Mon May 15 20:00:07 2023 +0200

    Support parallel testing in libgomp: fallback Perl 'flock' [PR66005]

    Follow-up to commit 6c3b30ef9e0578509bdaf59c13da4a212fe6c2ba
    "Support parallel testing in libgomp, part II [PR66005]"
    ("..., and enable if 'flock' is available for serializing execution
testing"),
    where we saw:

    > On my Dell Precision 7530 laptop:
    >
    >     $ uname -srvi
    >     Linux 5.15.0-71-generic #78-Ubuntu SMP Tue Apr 18 09:00:29 UTC 20=
23
x86_64
    >     $ grep '^model name' < /proc/cpuinfo | uniq -c
    >          12 model name      : Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    >     $ nvidia-smi -L
    >     GPU 0: Quadro P1000 (UUID: GPU-e043973b-b52a-d02b-c066-a8fdbf64e8=
ea)
    >
    > ... [...]: case (c) standard configuration, no offloading
    > configured, [...]

    >     $ \time make check-target-libgomp
    >
    > Case (c), baseline; [...]:
    >
    >     1180.98user 110.80system 19:36.40elapsed 109%CPU (0avgtext+0avgda=
ta
505148maxresident)k
    >     1133.22user 111.08system 19:35.75elapsed 105%CPU (0avgtext+0avgda=
ta
505212maxresident)k
    >
    > Case (c), parallelized [using 'flock']:
    >
    > [...]
    >     -j12 GCC_TEST_PARALLEL_SLOTS=3D12
    >     2591.04user 192.64system 4:44.98elapsed 976%CPU (0avgtext+0avgdata
505216maxresident)k
    >     2581.23user 195.21system 4:47.51elapsed 965%CPU (0avgtext+0avgdata
505212maxresident)k

    Quite the same when instead of 'flock' using this fallback Perl 'flock':

        2565.23user 194.35system 4:46.77elapsed 962%CPU (0avgtext+0avgdata
505216maxresident)k
        2549.38user 200.20system 4:46.08elapsed 961%CPU (0avgtext+0avgdata
505216maxresident)k

            PR testsuite/66005
            gcc/
            * doc/install.texi: Document (optional) Perl usage for parallel
            testing of libgomp.
            libgomp/
            * testsuite/lib/libgomp.exp: 'flock' through stdout.
            * testsuite/flock: New.
            * configure.ac (FLOCK): Point to that if no 'flock' available, =
but
            'perl' is.
            * configure: Regenerate.

    (cherry picked from commit 04abe1944d30eb18a2060cfcd9695d085f7b4752)=