public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/66005] libgomp make check time is excessive
Date: Tue, 16 May 2023 07:46:12 +0000	[thread overview]
Message-ID: <bug-66005-4-wap72AoqnM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-66005-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66005

--- Comment #15 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #14 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
> (In reply to Eric Gallager from comment #12)
>> Note that there's a gnulib module for flock:
>> https://www.gnu.org/software/gnulib/manual/html_node/flock.html
>
> I'd see that one -- but it also says: "the replacement function does not really
> work", so I don't think that's useful?

Besides, this only provides a replacement for the system call; we'd
still have to implement flock(1) ourselves and I'd rather not see us go
there.

> (In reply to Jakub Jelinek from comment #13)
>> And fcntl in tclx.
>
> Seen that, too -- but is TclX something that people actually have
> available/installed?  (Rainer?)

It's not available in packaged form on any of the targets I mentioned
(Solaris, macOS, AIX).  Besides, adding something like this feels quite
heavy-handed to me.

>> Anyway, I think choosing between flock(1) and some
>> python file locking would be better than using perl which is only needed in
>> maintainer mode and not otherwise.
>
> Rainer, would a 'python3' variant work for you?

Not really: python3 isn't available on older macOS systems, and again:
adding a python requirement (even for python2 in such a limited case)
seems to go overboard to me.

While I personally don't have a problem with requiring perl (it's needed
to support shared library versioning on Solaris), the same argument
applies.

My strong preference would be to use Tcl core means only, thus adding no
additional requirement.  I found a couple of suggestions on how to do
this:

https://wiki.tcl-lang.org/page/How+do+I+manage+lock+files+in+a+cross+platform+manner+in+Tcl
https://wiki.tcl-lang.org/page/Serializing+things+via+file+locks

effectively matching Jakub's suggestion.

  parent reply	other threads:[~2023-05-16  7:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 13:38 [Bug libgomp/66005] New: " ro at gcc dot gnu.org
2022-01-21 20:42 ` [Bug libgomp/66005] " belyshev at depni dot sinp.msu.ru
2022-02-08 14:15 ` tschwinge at gcc dot gnu.org
2022-05-29  5:05 ` egallager at gcc dot gnu.org
2023-05-04 15:29 ` tschwinge at gcc dot gnu.org
2023-05-05  9:05 ` tschwinge at gcc dot gnu.org
2023-05-15 10:11 ` cvs-commit at gcc dot gnu.org
2023-05-15 10:12 ` cvs-commit at gcc dot gnu.org
2023-05-15 10:31 ` [Bug testsuite/66005] " tschwinge at gcc dot gnu.org
2023-05-15 11:15 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-05-15 11:38 ` jakub at gcc dot gnu.org
2023-05-15 14:22 ` tschwinge at gcc dot gnu.org
2023-05-15 18:35 ` tschwinge at gcc dot gnu.org
2023-05-15 20:06 ` egallager at gcc dot gnu.org
2023-05-15 20:22 ` jakub at gcc dot gnu.org
2023-05-15 20:42 ` tschwinge at gcc dot gnu.org
2023-05-16  7:46 ` ro at CeBiTec dot Uni-Bielefeld.DE [this message]
2023-05-16  7:57 ` jakub at gcc dot gnu.org
2023-06-02  7:51 ` cvs-commit at gcc dot gnu.org
2023-06-02 10:07 ` tschwinge at gcc dot gnu.org
2023-06-02 10:16 ` iains at gcc dot gnu.org
2023-06-05 14:52 ` tschwinge at gcc dot gnu.org
2023-06-23 12:51 ` tschwinge at gcc dot gnu.org
2023-06-23 13:42 ` jakub at gcc dot gnu.org
2023-06-28 11:39 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:39 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:39 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:40 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:41 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:41 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:42 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:42 ` cvs-commit at gcc dot gnu.org
2023-06-28 11:42 ` cvs-commit at gcc dot gnu.org
2024-06-20 13:28 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-66005-4-wap72AoqnM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).