[Bug target/66015] New: align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[Bug target/66015] New: align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[chrbr at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

            Bug ID: 66015
           Summary: align directives not propagated after __attribute__
                    ((__optimize__ ("O2")))
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chrbr at gcc dot gnu.org
  Target Milestone: ---

When attribute optimize is used, the alignment flags are not reevaluated.

Consequently, the functions are not aligned as if they were with the same
global flag

for example:
__attribute__ ((__optimize__ ("O2")))
void
hooray ()
{
}

is not aligned 

The second consequence is that can_inline_edge_p fails because opts_for_fn
(caller->decl) != opts_for_fn (callee->decl)) even-though they are compiled
with the same optimization level.

[Bug target/66015] align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[chrbr at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

--- Comment #1 from chrbr at gcc dot gnu.org ---
Author: chrbr
Date: Wed May  6 10:54:40 2015
New Revision: 222847

URL: https://gcc.gnu.org/viewcvs?rev=222847&root=gcc&view=rev
Log:
2015-05-06  Christian Bruel  <christian.bruel@st.com>

        PR target/66015
        * config/aarch64/aarch64.c (aarch64_override_options): Move
align_loops,
        align_jumps, align_functions into
aarch64_override_options_after_change.


Added:
    trunk/gcc/testsuite/gcc.target/aarch64/iinline-attr-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/aarch64/aarch64.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/66015] align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[chrbr at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

--- Comment #2 from chrbr at gcc dot gnu.org ---
Author: chrbr
Date: Wed May  6 11:19:56 2015
New Revision: 222848

URL: https://gcc.gnu.org/viewcvs?rev=222848&root=gcc&view=rev
Log:
2015-05-06  Christian Bruel  <christian.bruel@st.com>

        PR target/66015
        * config/aarch64/aarch64.c (aarch64_override_options): Move
align_loops,
        align_jumps, align_functions into
aarch64_override_options_after_change.


Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.target/aarch64/iinline-attr-1.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/aarch64/aarch64.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug target/66015] align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

--- Comment #3 from uros at gcc dot gnu.org ---
Author: uros
Date: Thu May  7 07:34:29 2015
New Revision: 222870

URL: https://gcc.gnu.org/viewcvs?rev=222870&root=gcc&view=rev
Log:
        PR target/66015
        * config/alpha/alpha.c (alpha_override_options_after_change): New.
        (TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE): New.
        (alpha_override_options): Move align_loops, align_jumps and
        align_functions handling into alpha_override_options_after_change.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/alpha/alpha.c

[Bug target/66015] align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

--- Comment #4 from uros at gcc dot gnu.org ---
Author: uros
Date: Thu May  7 19:35:45 2015
New Revision: 222888

URL: https://gcc.gnu.org/viewcvs?rev=222888&root=gcc&view=rev
Log:
        PR target/66015
        * config/alpha/alpha.c (alpha_override_options_after_change): New.
        (TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE): New.
        (alpha_override_options): Move align_loops, align_jumps and
        align_functions handling into alpha_override_options_after_change.


Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/alpha/alpha.c

[Bug target/66015] align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |ramana at gcc dot gnu.org
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.2

--- Comment #5 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed - presumably.

[Bug target/66015] align directives not propagated after __attribute__ ((__optimize__ ("O2")))

[chrbr at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66015

chrbr at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|aarch64, alpha              |aarch64, alpha,ia64

--- Comment #6 from chrbr at gcc dot gnu.org ---
yes, although the patch still not approved/applied for ia64.

https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00312.html