[Bug libstdc++/66030] New: [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[Bug libstdc++/66030] New: [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[sailer at sailer dot dynip.lugs.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

            Bug ID: 66030
           Summary: [5.1.0] std::codecvt_byname missing from libstdc++ DLL
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sailer at sailer dot dynip.lugs.ch
  Target Milestone: ---

Created attachment 35470
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35470&action=edit
testcase

Compiling the attached simple test case fails linking for mingw32, because
libstdc++ DLL misses codecvt_byname symbols. This test case works with mingw32
gcc 4.9.2.

$ i686-w64-mingw32-g++ -o x.exe x.c 
/tmp/ccIXAXf0.o:x.c:(.text+0x74): undefined reference to
`std::codecvt_byname<wchar_t, char, int>::codecvt_byname(char const*, unsigned
int)'
collect2: error: ld returned 1 exit status


$ i686-w64-mingw32-gcc -v
Using built-in specs.
COLLECT_GCC=i686-w64-mingw32-gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/i686-w64-mingw32/5.1.0/lto-wrapper
Target: i686-w64-mingw32
Configured with: ../configure --prefix=/usr --bindir=/usr/bin
--includedir=/usr/include --mandir=/usr/share/man --infodir=/usr/share/info
--datadir=/usr/share --build=x86_64-redhat-linux-gnu
--host=x86_64-redhat-linux-gnu --with-gnu-as --with-gnu-ld --verbose
--without-newlib --disable-multilib --disable-plugin --with-system-zlib
--disable-nls --without-included-gettext --disable-win32-registry
--enable-languages=c,c++,objc,obj-c++,fortran
--with-bugurl=http://bugzilla.redhat.com/bugzilla --with-cloog
--enable-threads=posix --enable-libgomp --target=i686-w64-mingw32
--with-sysroot=/usr/i686-w64-mingw32/sys-root
--with-gxx-include-dir=/usr/i686-w64-mingw32/sys-root/mingw/include/c++
Thread model: posix
gcc version 5.1.0 20150422 (Fedora MinGW 5.1.0-1.fc23) (GCC)

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[sailer at sailer dot dynip.lugs.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #1 from Thomas Sailer <sailer at sailer dot dynip.lugs.ch> ---
Created attachment 35471
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35471&action=edit
preprocessed testcase

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[hamzaalloush at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #2 from Hamza Alloush <hamzaalloush at live dot com> ---
with gcc 5.1, i also have this bug, whenever i try to cross compile boost with
mingw, as it tries to define codecvt_byname for
${BOOST_DIR}/libs/locale/src/std/codecvt.cpp

##
undefined reference to `std::codecvt_byname<char, char,
int>::codecvt_byname(char const*, unsigned int)'
##

i use gcc 4.9.3 and i don't have this problem.

http://pastebin.com/HcizTVkg

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-05-27
     Ever confirmed|0                           |1

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[jroivas at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

Jouni Roivas <jroivas at iki dot fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jroivas at iki dot fi

--- Comment #3 from Jouni Roivas <jroivas at iki dot fi> ---
Created attachment 35668
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35668&action=edit
proposed patch

This patch solves this problem for me. However I'm not sure if it covers all
the cases.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jouni Roivas from comment #3)
> Created attachment 35668 [details]
> proposed patch
> 
> This patch solves this problem for me. However I'm not sure if it covers all
> the cases.

This is wrong because it adds the symbols to a frozen symbol version, we need a
new symbol version.

What I don't understand is why the symbols are only missing now, when they've
never been correctly exported, even prior to GCC 5.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Does this work?

--- a/libstdc++-v3/config/abi/pre/gnu.ver
+++ b/libstdc++-v3/config/abi/pre/gnu.ver
@@ -542,6 +542,9 @@ GLIBCXX_3.4 {
     # std::codecvt_byname
     _ZNSt14codecvt_bynameI[cw]c11__mbstate_tEC[12]EPKc[jmy];
     _ZNSt14codecvt_bynameI[cw]c11__mbstate_tED*;
+#if defined (_WIN32) && !defined (__CYGWIN__)
+    _ZNSt14codecvt_bynameI[cw]ciE[CD]*;
+#endif

     # std::collate
     _ZNSt7collateI[cw]*;

This won't affect any targets which use versioned symbols.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[jroivas at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #6 from Jouni Roivas <jroivas at iki dot fi> ---
(In reply to Jonathan Wakely from comment #5)
> Does this work?

Yes, it works.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[jroivas at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #7 from Jouni Roivas <jroivas at iki dot fi> ---
(In reply to Jouni Roivas from comment #6)
> (In reply to Jonathan Wakely from comment #5)
> > Does this work?
> 
> Yes, it works.


Now I found some more missing symbols:

undefined reference to `std::codecvt<char16_t, char, int>::id'
undefined reference to `std::codecvt<char32_t, char, int>::id'

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
OK, thanks for checking. I'll prepare a new patch tomorrow.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[jroivas at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

Jouni Roivas <jroivas at iki dot fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35668|0                           |1
        is obsolete|                            |

--- Comment #9 from Jouni Roivas <jroivas at iki dot fi> ---
Created attachment 35703
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35703&action=edit
Patch to fix further problems

With this patch I was able to cross compile boost library properly.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #10 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Yeah, thanks for working on that.  With extensions shown by Jouni, the patch is
preapproved.  Jonathan, will you take care?

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, I'll deal with it.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think the patch posted at
https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00590.html should be equivalent,
if you have time to check it that would be great.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[jroivas at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #13 from Jouni Roivas <jroivas at iki dot fi> ---
That patch seems to work. Thanks.

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #15 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Jun 15 12:31:15 2015
New Revision: 224478

URL: https://gcc.gnu.org/viewcvs?rev=224478&root=gcc&view=rev
Log:
Backport from mainline
2015-06-09  Jonathan Wakely  <jwakely@redhat.com>

        PR libstdc++/66030
        * config/abi/pre/gnu.ver: Export codecvt_byname and codecvt symbols
        for mingw32.

Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/config/abi/pre/gnu.ver

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
            Version|unknown                     |5.1.0
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.2

--- Comment #16 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 5.2

[Bug libstdc++/66030] [5.1.0] std::codecvt_byname missing from libstdc++ DLL

[hamzaalloush at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66030

--- Comment #17 from Hamza Alloush <hamzaalloush at live dot com> ---
Boost compilling properly now!

Thanks to all involved! :)