From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65124 invoked by alias); 20 May 2015 05:40:52 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 65075 invoked by uid 48); 20 May 2015 05:40:48 -0000 From: "dougmencken at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/66038] [5 regression] (stage 2) build/genmatch segfaults in operand::gen_transform (gcc/hash-table.h:223) Date: Wed, 20 May 2015 05:40:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: bootstrap X-Bugzilla-Version: 5.1.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dougmencken at gmail dot com X-Bugzilla-Status: WAITING X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.2 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-05/txt/msg01594.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D66038 --- Comment #11 from Douglas Mencken --- Causing commit found. It is r218976 (e2afa5c10fd41fe708959121f373fcb5435ef5d6). With reverse-appl= ied=20 r218976's patch, 5.1.0 even reaches "Bootstrap comparison failure!=E2=80=98= =E2=80=98 ;) Maybe patch's author [ Author: hubicka ] can help here. I see in patch: -hashval_t -hash_table_mod1 (hashval_t hash, unsigned int index) -{ - const struct prime_ent *p =3D &prime_tab[index]; -#ifdef UNSIGNED_64BIT_TYPE - if (sizeof (hashval_t) * CHAR_BIT <=3D 32) - return mul_mod (hash, p->prime, p->inv, p->shift); -#endif - return hash % p->prime; -} +inline hashval_t +hash_table_mod1 (hashval_t hash, unsigned int index) +{ + const struct prime_ent *p =3D &prime_tab[index]; + gcc_checking_assert (sizeof (hashval_t) * CHAR_BIT <=3D 32); + return mul_mod (hash, p->prime, p->inv, p->shift); +} Before, when "sizeof (hashval_t) * CHAR_BIT <=3D 32=E2=80=9D, hash % p->pri= me was returned. After, <=3D 32 triggers assert (--> failure). I suggest something like inline hashval_t hash_table_mod1 (hashval_t hash, unsigned int index) { const struct prime_ent *p =3D &prime_tab[index]; if (sizeof (hashval_t) * CHAR_BIT <=3D 32) return mul_mod (hash, p->prime, p->inv, p->shift); else return hash % p->prime; } >>From gcc-bugs-return-486755-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 20 06:23:32 2015 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 46046 invoked by alias); 20 May 2015 06:23:32 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 45982 invoked by uid 48); 20 May 2015 06:23:28 -0000 From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/66038] [5 regression] (stage 2) build/genmatch segfaults in operand::gen_transform (gcc/hash-table.h:223) Date: Wed, 20 May 2015 06:23:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: bootstrap X-Bugzilla-Version: 5.1.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: WAITING X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.2 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-05/txt/msg01595.txt.bz2 Content-length: 514 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66038 Jakub Jelinek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #12 from Jakub Jelinek --- hashval_t should be unsigned int? Is it some other type on your host, or is CHAR_BIT bigger than 8, or do you have 64-bit unsigned int?