[Bug target/66047] New: [5/6 Regression] vlc compilation failure with target attribute

[Bug target/66047] New: [5/6 Regression] vlc compilation failure with target attribute

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

            Bug ID: 66047
           Summary: [5/6 Regression] vlc compilation failure with target
                    attribute
           Product: gcc
           Version: 5.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

__attribute__((target ("sse2"), noinline)) static void
foo (void)
{
  asm volatile ("" : : : "memory");
}

void
bar (void)
{
  foo ();
}

fails to compile with -O2 -m32 -mno-sse starting with r220520.  There is no
user error here, the bug is that the compiler chose to use sseregparm calling
convention when it isn't appropriate (not all callers support it).  Plus, in
this particular case there is no difference between sseregparm and normal
calling convention...

__attribute__((target ("sse2"), noinline)) static float
foo (float x, float y)
{
  return x + y;
}

float
bar (float x, float y)
{
  return foo (x + 1.0f, y) - 1.0f;
}

used to be wrong-code in between introduction of target attribute (supposedly
r138075 if we use -Dtarget=option for older releases) and r220519, now is
similarly rejects-valid.

[Bug target/66047] [5/6 Regression] vlc compilation failure with target attribute

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-05-07
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |5.2
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Is callgraph still usable at the time of expansion?  If yes, perhaps we should
for the can_change_signature case if we're contemplating to switch on
sseregparm calling convention automatically walk all the callers and see if
they support it.
If not, bet somewhere around where we compute can_change_signature we'd need to
also compute target_can_change_signature bit that would be computed using some
target hook (perhaps with a shortcut if target node for both caller and callee
is the same, don't call the hook).

[Bug target/66047] [5/6 Regression] vlc compilation failure with target attribute

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Mine.

[Bug target/66047] [5 Regression] vlc compilation failure with target attribute

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[5/6 Regression] vlc        |[5 Regression] vlc
                   |compilation failure with    |compilation failure with
                   |target attribute            |target attribute

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I managed to get wrong PR marker, but partly fixed on mainline so far by
r223111

https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01230.html

[Bug target/66047] [5 Regression] vlc compilation failure with target attribute

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #3)
> I managed to get wrong PR marker, but partly fixed on mainline so far by
> r223111
> 
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01230.html

You can do:

svn propedit 'svn:log' -r223111 --revprop

to amend it. This is good for the future when someone checks the svn logs, and
it will trigger a message here.
>From gcc-bugs-return-486243-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 13 17:43:17 2015
Return-Path: <gcc-bugs-return-486243-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 91087 invoked by alias); 13 May 2015 17:43:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 91025 invoked by uid 55); 13 May 2015 17:43:13 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66047] [5 Regression] vlc compilation failure with target attribute
Date: Wed, 13 May 2015 17:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.1.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.2
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66047-4-UWzPZBnZ5z@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66047-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66047-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01083.txt.bz2
Content-length: 671

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Revision: 223111
Modified property: svn:log

Modified: svn:log at Wed May 13 17:42:41 2015
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Wed May 13 17:42:41 2015
@@ -1,5 +1,5 @@

-       PR target/pr66047.c
+       PR target/66047
        * i386.c (ix86_function_sseregparm): Only return -1 if local function
        with implied regparm is called from -mno-sse function.
        (init_cumulative_args): Output error if ix86_function_sseregparm
>From gcc-bugs-return-486244-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 13 18:18:02 2015
Return-Path: <gcc-bugs-return-486244-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23408 invoked by alias); 13 May 2015 18:18:02 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23029 invoked by uid 48); 13 May 2015 18:17:58 -0000
From: "emaste at freebsd dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66136] New: AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD
Date: Wed, 13 May 2015 18:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: emaste at freebsd dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-66136-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01084.txt.bz2
Content-length: 2440

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf136

            Bug ID: 66136
           Summary: AArch64 geniterators.sh relies on GNU sed syntax,
                    causing build failure on FreeBSD
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: emaste at freebsd dot org
  Target Milestone: ---

Attempting to build an AArch64 target on FreeBSD fails with:

In file included from ../../gcc/config/aarch64/aarch64-builtins.c:316:
./aarch64-builtin-iterators.h:5:1: warning: extra ';' outside of a function is
a C++11 extension [-Wc++11-extra-semi]
./aarch64-builtin-iterators.h:5:4: error: unknown type name 'Machine'
./aarch64-builtin-iterators.h:5:22: error: expected ';' after top level
declarator
./aarch64-builtin-iterators.h:5:48: warning: extra ';' outside of a function is
a C++11 extension [-Wc++11-extra-semi]
./aarch64-builtin-iterators.h:5:50: error: unknown type name 'Copyrigh'
./aarch64-builtin-iterators.h:5:62: error: expected ';' after top level
declarator
...


and aarch64-builtin-iterators.h looks like:
feynman% head gcc/aarch64-builtin-iterators.h
/* -*- buffer-read-only: t -*- */
/* Generated automatically by geniterators.sh from iterators.md.  */
#ifndef GCC_AARCH64_ITERATORS_H
#define GCC_AARCH64_ITERATORS_H
;; Machine descripion for AArch64 archiecure. ;; Copyrigh (C) 2009-2015 Free
Sofware Foundaion, Inc. ;; Conribued by ARM Ld. ;; ;; This file is par of GCC.
;; ;; GCC is free sofware; you can redisribue i and/or modify i ;; under he
erms of he GNU General Public License as published by ;; he Free Sofware
Foundaion; eiher version 3, or (a your opion) ;; any laer version. ;; ;; GCC is
disribued in he hope ha i will be useful, bu ;; WITHOUT ANY WARRANTY; wihou
even he implied warrany of ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE. See he GNU ;; General Public License for more deails. ;; ;; You should
have received a copy of he GNU General Public License ;; along wih GCC; see he
file COPYING3. If no see ;; <hp://www.gnu.org/licenses/>. ;;
------------------------------------------------------------------- ;;
...

To get past this locally for now I've s/sed/gsed/ in geniterators.sh.

I think we'll want to either change the expressions to work with other sed
implementations, or require GNU sed.

[Bug target/66047] [5 Regression] vlc compilation failure with target attribute

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Sun May 17 19:41:23 2015
New Revision: 223272

URL: https://gcc.gnu.org/viewcvs?rev=223272&root=gcc&view=rev
Log:
        PR target/66047
        * i386.c (ix86_function_sseregparm): Only return -1 if local function
        with implied regparm is called from -mno-sse function.
        (init_cumulative_args): Output error if ix86_function_sseregparm
        return -1 and SSE register would be needed.
        (function_arg_advance_32): Likewise.
        (function_arg_32): Likewise.
        * i386.h (ix86_args): Add decl field.
        * gcc.target/i386/pr66047.c: New testcase.

Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.target/i386/pr66047.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/i386/i386.c
    branches/gcc-5-branch/gcc/config/i386/i386.h
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug target/66047] vlc compilation failure with target attribute

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2
            Summary|[5 Regression] vlc          |vlc compilation failure
                   |compilation failure with    |with target attribute
                   |target attribute            |

--- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
No longer a regression, but it is still a bug about rejecting valid code that
may be quite common for 32bit builds.

[Bug target/66047] vlc compilation failure with target attribute

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.2                         |5.3

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 5.2 is being released, adjusting target milestone to 5.3.

[Bug target/66047] vlc compilation failure with target attribute

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66047

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.5                         |---