public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/66055] New: hash containers missing required reserving constructors
@ 2015-05-07 16:45 ncm at cantrip dot org
  2015-05-07 16:55 ` [Bug libstdc++/66055] " ncm at cantrip dot org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: ncm at cantrip dot org @ 2015-05-07 16:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

            Bug ID: 66055
           Summary: hash containers missing required reserving
                    constructors
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ncm at cantrip dot org
  Target Milestone: ---

Created attachment 35487
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35487&action=edit
missing hash container constructors, provided.

Hash containers in libstdc++ each lack two required reserving constructors from
size_type and other arguments.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libstdc++/66055] hash containers missing required reserving constructors
  2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
@ 2015-05-07 16:55 ` ncm at cantrip dot org
  2015-05-07 17:10 ` redi at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ncm at cantrip dot org @ 2015-05-07 16:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

ncm at cantrip dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35487|0                           |1
        is obsolete|                            |

--- Comment #1 from ncm at cantrip dot org ---
Created attachment 35488
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35488&action=edit
Better fix

Previous patch was incompletely edited for inclusion.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libstdc++/66055] hash containers missing required reserving constructors
  2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
  2015-05-07 16:55 ` [Bug libstdc++/66055] " ncm at cantrip dot org
@ 2015-05-07 17:10 ` redi at gcc dot gnu.org
  2015-05-14 13:47 ` redi at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: redi at gcc dot gnu.org @ 2015-05-07 17:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-05-07
     Ever confirmed|0                           |1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libstdc++/66055] hash containers missing required reserving constructors
  2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
  2015-05-07 16:55 ` [Bug libstdc++/66055] " ncm at cantrip dot org
  2015-05-07 17:10 ` redi at gcc dot gnu.org
@ 2015-05-14 13:47 ` redi at gcc dot gnu.org
  2015-05-14 13:48 ` redi at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: redi at gcc dot gnu.org @ 2015-05-14 13:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu May 14 13:47:19 2015
New Revision: 223198

URL: https://gcc.gnu.org/viewcvs?rev=223198&root=gcc&view=rev
Log:
2015-05-14  Nathan Myers  <ncm@cantrip.org>
            Jonathan Wakely  <jwakely@redhat.com>

        PR libstdc++/66055
        * include/std/unordered_map (unordered_map, unordered_multimap): Add
        missing constructors.
        * include/std/unordered_set (unordered_set, unordered_multiset):
        Likewise.
        * testsuite/23_containers/unordered_map/cons/66055.cc: New.
        * testsuite/23_containers/unordered_multimap/cons/66055.cc: New.
        * testsuite/23_containers/unordered_multiset/cons/66055.cc: New.
        * testsuite/23_containers/unordered_set/cons/66055.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/23_containers/unordered_map/cons/66055.cc
    trunk/libstdc++-v3/testsuite/23_containers/unordered_multimap/cons/66055.cc
    trunk/libstdc++-v3/testsuite/23_containers/unordered_multiset/cons/66055.cc
    trunk/libstdc++-v3/testsuite/23_containers/unordered_set/cons/66055.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/unordered_map.h
    trunk/libstdc++-v3/include/bits/unordered_set.h


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libstdc++/66055] hash containers missing required reserving constructors
  2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
                   ` (2 preceding siblings ...)
  2015-05-14 13:47 ` redi at gcc dot gnu.org
@ 2015-05-14 13:48 ` redi at gcc dot gnu.org
  2015-06-22 15:53 ` redi at gcc dot gnu.org
  2015-06-22 16:32 ` redi at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: redi at gcc dot gnu.org @ 2015-05-14 13:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk so far.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libstdc++/66055] hash containers missing required reserving constructors
  2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
                   ` (3 preceding siblings ...)
  2015-05-14 13:48 ` redi at gcc dot gnu.org
@ 2015-06-22 15:53 ` redi at gcc dot gnu.org
  2015-06-22 16:32 ` redi at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: redi at gcc dot gnu.org @ 2015-06-22 15:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Jun 22 15:53:14 2015
New Revision: 224740

URL: https://gcc.gnu.org/viewcvs?rev=224740&root=gcc&view=rev
Log:
Backport from mainline
2015-05-14  Nathan Myers  <ncm@cantrip.org>
            Jonathan Wakely  <jwakely@redhat.com>

        PR libstdc++/66055
        * include/std/unordered_map (unordered_map, unordered_multimap): Add
        missing constructors.
        * include/std/unordered_set (unordered_set, unordered_multiset):
        Likewise.
        * testsuite/23_containers/unordered_map/cons/66055.cc: New.
        * testsuite/23_containers/unordered_multimap/cons/66055.cc: New.
        * testsuite/23_containers/unordered_multiset/cons/66055.cc: New.
        * testsuite/23_containers/unordered_set/cons/66055.cc: New.

Added:
   
branches/gcc-5-branch/libstdc++-v3/testsuite/23_containers/unordered_map/cons/66055.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/23_containers/unordered_multimap/cons/66055.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/23_containers/unordered_multiset/cons/66055.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/23_containers/unordered_set/cons/66055.cc
Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/include/bits/unordered_map.h
    branches/gcc-5-branch/libstdc++-v3/include/bits/unordered_set.h


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug libstdc++/66055] hash containers missing required reserving constructors
  2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
                   ` (4 preceding siblings ...)
  2015-06-22 15:53 ` redi at gcc dot gnu.org
@ 2015-06-22 16:32 ` redi at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: redi at gcc dot gnu.org @ 2015-06-22 16:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66055

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.2

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 5.2


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-06-22 16:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-07 16:45 [Bug libstdc++/66055] New: hash containers missing required reserving constructors ncm at cantrip dot org
2015-05-07 16:55 ` [Bug libstdc++/66055] " ncm at cantrip dot org
2015-05-07 17:10 ` redi at gcc dot gnu.org
2015-05-14 13:47 ` redi at gcc dot gnu.org
2015-05-14 13:48 ` redi at gcc dot gnu.org
2015-06-22 15:53 ` redi at gcc dot gnu.org
2015-06-22 16:32 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).