public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vehre at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/66089] [6 Regression] elemental dependency mishandling when derived types are involved
Date: Fri, 22 May 2015 09:23:00 -0000	[thread overview]
Message-ID: <bug-66089-4-TqhEqYOJFm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-66089-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66089

--- Comment #9 from vehre at gcc dot gnu.org ---
That was a rhetorical question.

In the patch you submitted in comment #2 could you put a comment (in the
source) at:

Index: trans-array.c
===================================================================
--- trans-array.c       (révision 222968)
+++ trans-array.c       (copie de travail)
@@ -2451,7 +2451,8 @@ gfc_scalar_elemental_arg_saved_as_reference (gfc_s
@@ -4465,6 +4466,10 @@ gfc_conv_resolve_dependencies (gfc_loopinfo * loop

            nDepend = gfc_check_dependency (dest_expr, ss_expr, false);

<here>
+         if (ss->info->type == GFC_SS_REFERENCE
+             && gfc_check_dependency (dest_expr, ss_expr, false) == 1)
+           ss->info->data.scalar.need_temporary = 1;
+
          continue;
        }

what the reason for this check and set of the flag is? Now it is clear to us,
but in the future we might be wondering. 

Furthermore is the flag name "need_temporary" correct here? I think, that it
should have the polymorphic nature of its existence in its name. Like
"non_polymorphic_temp" or the like. 

I am still wondering whether there isn't a counterexample where this is not
working, i.e., we have lhs-rhs-dependency that is polymorphic. But because
assignment to (allocatable) polymorphic entities is not allowed, I could not
come up with one.
>From gcc-bugs-return-487049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 22 09:33:23 2015
Return-Path: <gcc-bugs-return-487049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 51858 invoked by alias); 22 May 2015 09:33:20 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 51802 invoked by uid 48); 22 May 2015 09:33:17 -0000
From: "ktkachov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/66241] [6 regression] [ARM] ICE: verify_type failed while building libstdc++ (dwarfout.c: gen_type_die_with_usage())
Date: Fri, 22 May 2015 09:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: ktkachov at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_reconfirmed_on cc
Message-ID: <bug-66241-4-KtDHWTeUPG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66241-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66241-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01889.txt.bz2
Content-length: 491

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf241

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2015-05-21 00:00:00         |2015-5-22
                 CC|                            |ktkachov at gcc dot gnu.org

--- Comment #4 from ktkachov at gcc dot gnu.org ---
I'm seeing this as well (as it is blocking the arm-none-linux-gnueabihf build)


  parent reply	other threads:[~2015-05-22  9:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 18:45 [Bug fortran/66089] New: " mikael at gcc dot gnu.org
2015-05-09 18:47 ` [Bug fortran/66089] " mikael at gcc dot gnu.org
2015-05-10 13:33 ` mikael at gcc dot gnu.org
2015-05-12 12:54 ` [Bug fortran/66089] [6 Regression] " dominiq at lps dot ens.fr
2015-05-21 14:15 ` vehre at gcc dot gnu.org
2015-05-21 15:12 ` mikael at gcc dot gnu.org
2015-05-21 15:19 ` vehre at gcc dot gnu.org
2015-05-22  9:23 ` vehre at gcc dot gnu.org [this message]
2015-10-16  8:29 ` rguenth at gcc dot gnu.org
2015-10-16  8:33 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-66089-4-TqhEqYOJFm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).