* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
@ 2015-05-13 18:33 ` emaste at freebsd dot org
2015-05-15 13:51 ` [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac nszabolcs at gmail dot com
` (13 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: emaste at freebsd dot org @ 2015-05-13 18:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #1 from Ed Maste <emaste at freebsd dot org> ---
It appears this comes from \n newlines in the replacement pattern - I can
partially fix it by using an expression like:
sed 's/(define_mode_iterator \([A-Za-z0-9_]*\) \([]\[A-Z0-9 \t]*\)/\
#define BUILTIN_\1(T, N, MAP) \\ \2\
/g' \
that is, putting literal escaped newlines inside the single-quoted sed
expression. However, since we're already using awk at the end of the pipeline
anyway, the whole thing ought to just be implemented in awk.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
2015-05-13 18:33 ` [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD emaste at freebsd dot org
@ 2015-05-15 13:51 ` nszabolcs at gmail dot com
2015-05-15 14:02 ` emaste at freebsd dot org
` (12 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: nszabolcs at gmail dot com @ 2015-05-15 13:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #2 from Szabolcs Nagy <nszabolcs at gmail dot com> ---
the posix standard does not seem to disallow \n in the replacement string so i
think freebsd sed should be fixed (or report the bug to the austingroup).
meanwhile i will prepare a fix for this in gcc.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
2015-05-13 18:33 ` [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD emaste at freebsd dot org
2015-05-15 13:51 ` [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac nszabolcs at gmail dot com
@ 2015-05-15 14:02 ` emaste at freebsd dot org
2015-05-18 15:13 ` nszabolcs at gmail dot com
` (11 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: emaste at freebsd dot org @ 2015-05-15 14:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #3 from Ed Maste <emaste at freebsd dot org> ---
> the posix standard does not seem to disallow \n in the replacement string so i think freebsd sed should be fixed (or report the bug to the austingroup).
I can't find language that specifies sed must interpret escape sequences in the
replacement string. Anyway, it does seem like it would be a useful thing for
BSD sed to handle, but it's what we've got today. I also just confirmed that
sed on OS X behaves the same way.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2015-05-15 14:02 ` emaste at freebsd dot org
@ 2015-05-18 15:13 ` nszabolcs at gmail dot com
2015-05-19 8:04 ` rearnsha at gcc dot gnu.org
` (10 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: nszabolcs at gmail dot com @ 2015-05-18 15:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #5 from Szabolcs Nagy <nszabolcs at gmail dot com> ---
patch that uses awk:
https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01578.html
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2015-05-18 15:13 ` nszabolcs at gmail dot com
@ 2015-05-19 8:04 ` rearnsha at gcc dot gnu.org
2015-05-19 13:05 ` emaste at freebsd dot org
` (9 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2015-05-19 8:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
--- Comment #6 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Ed,
Could you confirm this works with the standard FreeBSD Awk?
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2015-05-19 8:04 ` rearnsha at gcc dot gnu.org
@ 2015-05-19 13:05 ` emaste at freebsd dot org
2015-05-19 13:23 ` nszabolcs at gmail dot com
` (8 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: emaste at freebsd dot org @ 2015-05-19 13:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #7 from Ed Maste <emaste at freebsd dot org> ---
With the patch in comment 5 I get the same result with FreeBSD awk and GNU awk.
The output is rather different to what the previous (sed) version of
geniterators.sh produced, but that seems intentional.
My output looks like:
---- 8< ----------------------- >8 ----
/* -*- buffer-read-only: t -*- */
/* Generated automatically by geniterators.sh from iterators.md. */
#ifndef GCC_AARCH64_ITERATORS_H
#define GCC_AARCH64_ITERATORS_H
#define BUILTIN_GPI(T, N, MAP) \
VAR2 (T, N, MAP, si, di)
#define BUILTIN_SHORT(T, N, MAP) \
VAR2 (T, N, MAP, qi, hi)
#define BUILTIN_ALLI(T, N, MAP) \
VAR4 (T, N, MAP, qi, hi, si, di)
...
---- 8< ----------------------- >8 ----
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2015-05-19 13:05 ` emaste at freebsd dot org
@ 2015-05-19 13:23 ` nszabolcs at gmail dot com
2015-05-19 13:32 ` emaste at freebsd dot org
` (7 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: nszabolcs at gmail dot com @ 2015-05-19 13:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #8 from Szabolcs Nagy <nszabolcs at gmail dot com> ---
the new awk version is supposed to produce the exact same output as the old
script with gnu sed.
the pasted output fragment looks ok.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2015-05-19 13:23 ` nszabolcs at gmail dot com
@ 2015-05-19 13:32 ` emaste at freebsd dot org
2015-06-02 16:21 ` nsz at gcc dot gnu.org
` (6 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: emaste at freebsd dot org @ 2015-05-19 13:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #9 from Ed Maste <emaste at freebsd dot org> ---
(In reply to Szabolcs Nagy from comment #8)
> the new awk version is supposed to produce the exact same output as the old
> script with gnu sed.
>
> the pasted output fragment looks ok.
Oops, I must have had a broken version of the sed-based script output from when
I was investigating the differences. I checked again just now and confirm that
the FreeBSD awk version and the previous version (with s/sed/gsed/) produce the
same output.
Thank you.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2015-05-19 13:32 ` emaste at freebsd dot org
@ 2015-06-02 16:21 ` nsz at gcc dot gnu.org
2015-06-10 7:45 ` ramana at gcc dot gnu.org
` (5 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: nsz at gcc dot gnu.org @ 2015-06-02 16:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #10 from nsz at gcc dot gnu.org ---
Author: nsz
Date: Tue Jun 2 16:21:18 2015
New Revision: 224031
URL: https://gcc.gnu.org/viewcvs?rev=224031&root=gcc&view=rev
Log:
[AArch64][PR 66136] rewrite geniterators.sh in awk
2015-06-02 Szabolcs Nagy <szabolcs.nagy@arm.com>
PR target/66136
* config/aarch64/geniterators.sh: Rewrite in awk.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/aarch64/geniterators.sh
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2015-06-02 16:21 ` nsz at gcc dot gnu.org
@ 2015-06-10 7:45 ` ramana at gcc dot gnu.org
2015-06-10 9:12 ` nszabolcs at gmail dot com
` (4 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: ramana at gcc dot gnu.org @ 2015-06-10 7:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ramana at gcc dot gnu.org
--- Comment #11 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
(In reply to nsz from comment #10)
> Author: nsz
> Date: Tue Jun 2 16:21:18 2015
> New Revision: 224031
>
> URL: https://gcc.gnu.org/viewcvs?rev=224031&root=gcc&view=rev
> Log:
> [AArch64][PR 66136] rewrite geniterators.sh in awk
>
> 2015-06-02 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> PR target/66136
> * config/aarch64/geniterators.sh: Rewrite in awk.
>
>
> Modified:
> trunk/gcc/ChangeLog
> trunk/gcc/config/aarch64/geniterators.sh
Does this also need to go to the release branches , Szabolcs ?
Ramana
>From gcc-bugs-return-488558-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jun 10 07:45:14 2015
Return-Path: <gcc-bugs-return-488558-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 38050 invoked by alias); 10 Jun 2015 07:45:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 38004 invoked by uid 48); 10 Jun 2015 07:45:11 -0000
From: "ramana at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/66192] C++ static initializer unnecessary __cxa_guard_acquire for TARGET_RELAXED_ORDERING
Date: Wed, 10 Jun 2015 07:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ramana at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution target_milestone
Message-ID: <bug-66192-4-DvuNh0CVb0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66192-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66192-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg00890.txt.bz2
Content-length: 491
https://gcc.gnu.org/bugzilla/show_bug.cgi?idf192
Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |6.0
--- Comment #5 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2015-06-10 7:45 ` ramana at gcc dot gnu.org
@ 2015-06-10 9:12 ` nszabolcs at gmail dot com
2015-06-11 12:48 ` rearnsha at gcc dot gnu.org
` (3 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: nszabolcs at gmail dot com @ 2015-06-10 9:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #12 from Szabolcs Nagy <nszabolcs at gmail dot com> ---
geniterators.sh was new in gcc-5 and the first version of the script already
used \n in the sed replacement pattern (and other gnu extensions too).
shall i backport the new script to the gcc-5 branch?
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2015-06-10 9:12 ` nszabolcs at gmail dot com
@ 2015-06-11 12:48 ` rearnsha at gcc dot gnu.org
2015-06-30 10:07 ` nsz at gcc dot gnu.org
` (2 subsequent siblings)
14 siblings, 0 replies; 15+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2015-06-11 12:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |NEW
--- Comment #13 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
(In reply to Szabolcs Nagy from comment #12)
> geniterators.sh was new in gcc-5 and the first version of the script already
> used \n in the sed replacement pattern (and other gnu extensions too).
>
> shall i backport the new script to the gcc-5 branch?
Now it's had a bit of time to bake on trunk, yes please.
R.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2015-06-11 12:48 ` rearnsha at gcc dot gnu.org
@ 2015-06-30 10:07 ` nsz at gcc dot gnu.org
2015-07-06 10:08 ` nsz at gcc dot gnu.org
2015-07-06 15:20 ` ramana at gcc dot gnu.org
14 siblings, 0 replies; 15+ messages in thread
From: nsz at gcc dot gnu.org @ 2015-06-30 10:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
--- Comment #14 from nsz at gcc dot gnu.org ---
Author: nsz
Date: Tue Jun 30 10:07:03 2015
New Revision: 225170
URL: https://gcc.gnu.org/viewcvs?rev=225170&root=gcc&view=rev
Log:
Backport of r224031 from mainline
2015-06-29 Szabolcs Nagy <szabolcs.nagy@arm.com>
Backport from mainline:
2015-06-02 Szabolcs Nagy <szabolcs.nagy@arm.com>
PR target/66136
* config/aarch64/geniterators.sh: Rewrite in awk.
Modified:
branches/gcc-5-branch/gcc/ChangeLog
branches/gcc-5-branch/gcc/config/aarch64/geniterators.sh
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2015-06-30 10:07 ` nsz at gcc dot gnu.org
@ 2015-07-06 10:08 ` nsz at gcc dot gnu.org
2015-07-06 15:20 ` ramana at gcc dot gnu.org
14 siblings, 0 replies; 15+ messages in thread
From: nsz at gcc dot gnu.org @ 2015-07-06 10:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
nsz at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |nsz at gcc dot gnu.org
Resolution|--- |FIXED
--- Comment #15 from nsz at gcc dot gnu.org ---
fixed in trunk in r224031 and backported to branch 5 in r225170.
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug target/66136] AArch64 geniterators.sh relies on GNU sed syntax, causing build failure on FreeBSD and probably Mac
[not found] <bug-66136-4@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2015-07-06 10:08 ` nsz at gcc dot gnu.org
@ 2015-07-06 15:20 ` ramana at gcc dot gnu.org
14 siblings, 0 replies; 15+ messages in thread
From: ramana at gcc dot gnu.org @ 2015-07-06 15:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66136
Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |5.2
--- Comment #16 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed for 5.2 I believe.
^ permalink raw reply [flat|nested] 15+ messages in thread