From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 60F3F394443E; Thu, 11 Feb 2021 13:29:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60F3F394443E From: "redi at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/66146] call_once not C++11-compliant on ppc64le Date: Thu, 11 Feb 2021 13:29:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Version: 5.1.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: redi at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: redi at gcc dot gnu.org X-Bugzilla-Target-Milestone: 11.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2021 13:29:58 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D66146 --- Comment #40 from Jonathan Wakely --- (In reply to Libor Bukata from comment #39) > (In reply to Libor Bukata from comment #38) > > (In reply to Jonathan Wakely from comment #34) > > > Untested sketch of a solution for Solaris and BSDs: > > > https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557928.html > >=20 > > Thank you for the patch, I will test it on Solaris > > and let you know when I have the results. >=20 > Patched GCC master with Jonathan's patch, but unfortunately it is not > compilable on Solaris 11: > In file included from > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > sparcv9-sun-solaris2.11/bits/c++config.h:568, > from > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > cassert:43, > from > /gcc_nightly/gcc-11.0.0-master/libstdc++-v3/include/precompiled/stdc++.h:= 33: > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > mutex:861:10: error: token "{" is not valid in preprocessor expressions > 861 | || _GLIBCXX_COMPAT_PTHREAD_ONCE_T > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > sparcv9-sun-solaris2.11/bits/c++config.h:568, > from > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > cassert:43, > from > /gcc_nightly/gcc-11.0.0-master/libstdc++-v3/include/precompiled/stdc++.h:= 33: > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > mutex:861:10: error: token "{" is not valid in preprocessor expressions > 861 | || _GLIBCXX_COMPAT_PTHREAD_ONCE_T > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Oops, that should be: || defined _GLIBCXX_COMPAT_PTHREAD_ONCE_T to test if the macro is defined, rather than testing its value. > In file included from > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > future:38, > from > /gcc_nightly/gcc-11.0.0-master/libstdc++-v3/include/precompiled/stdc++.h:= 105: > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > mutex:675:15: error: explicitly defaulted function 'constexpr > std::once_flag::once_flag()' cannot be declared 'constexpr' because the > implicit declaration is not 'constexpr': > 675 | constexpr once_flag() noexcept =3D default; > | ^~~~~~~~~ > /gcc_nightly/build/sparcv9/sparcv9-sun-solaris2.11/libstdc++-v3/include/ > mutex:699:12: note: defaulted constructor calls non-'constexpr' > 'std::once_flag::_Once::_Once()' > 699 | struct _Once _GLIBCXX_COMPAT_PTHREAD_ONCE_T; This one's a bit trickier. The struct needs a default constructor that initializes all its members, but then it can't be used in the union. I'll provide a new patch when I get a chance to look into it.=