[Bug target/66215] [4.8/4.9/5/6 Regression] Wrong after label NOP emission for -mhotpatch

["marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66215

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Following testcase is wrongly compiled event with -O2 optimization level.

$ cat o2-test-case.c
static int a;

int t(int tt)
{
  switch (tt)
  {
    case 1: return a;
  }

  return 0;
}

$ ./xgcc -B. -mhotpatch=2,3 -O2 -fno-inline -o /tmp/test.s -S o2-test-case.c
$ head -n20 /tmp/test.s

        .file   "o2-test-case.c"
.text
        .align  8
.globl t
        .type   t, @function
        nopr    %r7     # pre-label NOPs for hotpatch (2 halfwords)
        nopr    %r7
        # alignment for hotpatch
        .align  8
t:
marxin@marxinbox:~/Programming/gcc2/objdir/gcc> head -n20 /tmp/test.s
        .file   "o2-test-case.c"
.text
        .align  8
.globl t
        .type   t, @function
        nopr    %r7     # pre-label NOPs for hotpatch (2 halfwords)
        nopr    %r7
        # alignment for hotpatch
        .align  8
t:
        # post-label NOPs for hotpatch (3 halfwords)
.LFB0:
        st      %r14,56(%r15)
        nop     0
        nopr    %r7
.LCFI0:
        l       %r4,56(%r15)
        lhi     %r2,0
        l       %r14,56(%r15)
.LCFI1:
>From gcc-bugs-return-486789-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 20 12:31:08 2015
Return-Path: <gcc-bugs-return-486789-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 14136 invoked by alias); 20 May 2015 12:31:08 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10259 invoked by uid 48); 20 May 2015 12:31:04 -0000
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66215] [4.8/4.9/5/6 Regression] Wrong after label NOP emission for -mhotpatch
Date: Wed, 20 May 2015 12:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: marxin at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66215-4-dZyXcDwFbM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66215-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66215-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01629.txt.bz2
Content-length: 1204

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66215

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #1)
> Following testcase is wrongly compiled event with -O2 optimization level.
> 
> $ cat o2-test-case.c
> static int a;
> 
> int t(int tt)
> {
>   switch (tt)
>   {
>     case 1: return a;
>   }
> 
>   return 0;
> }
> 
> $ ./xgcc -B. -mhotpatch=2,3 -O2 -fno-inline -o /tmp/test.s -S o2-test-case.c
> $ head -n20 /tmp/test.s
> 
> 	.file	"o2-test-case.c"
> .text
> 	.align	8
> .globl t
> 	.type	t, @function
> 	nopr	%r7	# pre-label NOPs for hotpatch (2 halfwords)
> 	nopr	%r7
> 	# alignment for hotpatch
> 	.align	8
> t:
> marxin@marxinbox:~/Programming/gcc2/objdir/gcc> head -n20 /tmp/test.s
> 	.file	"o2-test-case.c"
> .text
> 	.align	8
> .globl t
> 	.type	t, @function
> 	nopr	%r7	# pre-label NOPs for hotpatch (2 halfwords)
> 	nopr	%r7
> 	# alignment for hotpatch
> 	.align	8
> t:
> 	# post-label NOPs for hotpatch (3 halfwords)
> .LFB0:
> 	st	%r14,56(%r15)
> 	nop	0
> 	nopr	%r7
> .LCFI0:
> 	l	%r4,56(%r15)
> 	lhi	%r2,0
> 	l	%r14,56(%r15)
> .LCFI1:

Sorry, this testcase is invalid as I modified the compiler.

Martin
>From gcc-bugs-return-486791-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 20 12:33:55 2015
Return-Path: <gcc-bugs-return-486791-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21397 invoked by alias); 20 May 2015 12:33:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21345 invoked by uid 48); 20 May 2015 12:33:51 -0000
From: "krebbel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66215] [4.8/4.9/5/6 Regression] Wrong after label NOP emission for -mhotpatch
Date: Wed, 20 May 2015 12:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: krebbel at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-66215-4-5E9ogEEIl7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66215-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66215-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01631.txt.bz2
Content-length: 404

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf215

Andreas Krebbel <krebbel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-05-20
     Ever confirmed|0                           |1