From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-492848-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 112874 invoked by alias); 20 Jul 2015 16:31:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 112815 invoked by uid 55); 20 Jul 2015 16:31:30 -0000
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66217] PowerPC rotate/shift/mask instructions not optimal
Date: Mon, 20 Jul 2015 16:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: segher at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: segher at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66217-4-jFtYxC2Fkw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66217-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66217-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01738.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66217

--- Comment #2 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Author: segher
Date: Mon Jul 20 16:30:56 2015
New Revision: 226005

URL: https://gcc.gnu.org/viewcvs?rev=226005&root=gcc&view=rev
Log:
        PR target/66217
        * config/rs6000/constraints.md ("S", "T", "t"): Delete.  Update
        "available letters" comment.
        * config/rs6000/predicates.md (mask_operand, mask_operand_wrap,
        mask64_operand, mask64_2_operand, any_mask_operand, and64_2_operand,
        and_2rld_operand):  Delete.
        (and_operand): Adjust.
        (rotate_mask_operator): New.
        * config/rs6000/rs6000-protos.h (build_mask64_2_operands,
        includes_lshift_p, includes_rshift_p, includes_rldic_lshift_p,
        includes_rldicr_lshift_p, insvdi_rshift_rlwimi_p, extract_MB,
        extract_ME): Delete.
        (rs6000_is_valid_mask, rs6000_is_valid_and_mask,
        rs6000_is_valid_shift_mask, rs6000_is_valid_insert_mask,
        rs6000_insn_for_and_mask, rs6000_insn_for_shift_mask,
        rs6000_insn_for_insert_mask, rs6000_is_valid_2insn_and,
        rs6000_emit_2insn_and): New.
        * config/rs6000/rs6000.c (num_insns_constant): Adjust.
        (build_mask64_2_operands, includes_lshift_p, includes_rshift_p,
        includes_rldic_lshift_p, includes_rldicr_lshift_p,
        insvdi_rshift_rlwimi_p, extract_MB, extract_ME): Delete.
        (rs6000_is_valid_mask, rs6000_is_valid_and_mask,
        rs6000_insn_for_and_mask, rs6000_is_valid_shift_mask,
        s6000_insn_for_shift_mask, rs6000_is_valid_insert_mask,
        rs6000_insn_for_insert_mask, rs6000_is_valid_2insn_and,
        rs6000_emit_2insn_and): New.
        (print_operand) <'b', 'B', 'm', 'M', 's', 'S', 'W'>: Delete.
        (rs6000_rtx_costs) <CONST_INT>: Delete mask_operand and mask64_operand
        handling.
        <NOT>: Don't fall through to next case.
        <AND>: Handle the various rotate-and-mask cases directly.
        <IOR>: Always cost as one insn.
        * config/rs6000/rs6000.md (splitter for bswap:SI): Adjust.
        (and<mode>3): Adjust expander for the new patterns.
        (and<mode>3_imm, and<mode>3_imm_dot, and<mode>3_imm_dot2,
        and<mode>3_imm_mask_dot, and<mode>3_imm_mask_dot2): Adjust condition.
        (*and<mode>3_imm_dot_shifted): New.
        (*and<mode>3_mask): Delete, rewrite as ...
        (and<mode>3_mask): ... New.
        (*and<mode>3_mask_dot, *and<mode>3_mask_dot): Rewrite.
        (andsi3_internal0_nomc): Delete.
        (*andsi3_internal6): Delete.
        (*and<mode>3_2insn): New.
        (insv, insvsi_internal, *insvsi_internal1, *insvsi_internal2,
        *insvsi_internal3, *insvsi_internal4, *insvsi_internal5,
        *insvsi_internal6, insvdi_internal, *insvdi_internal2,
        *insvdi_internal3): Delete.
        (*rotl<mode>3_mask, *rotl<mode>3_mask_dot, *rotl<mode>3_mask_dot2,
        *rotl<mode>3_insert, *rotl<mode>3_insert_2, *rotl<mode>3_insert_3,
        *rotl<mode>3_insert_4, two splitters for multi-precision shifts,
        *ior<mode>_mask): New.
        (extzv, extzvdi_internal, *extzvdi_internal1, *extzvdi_internal2,
        *rotlsi3_mask, *rotlsi3_mask_dot, *rotlsi3_mask_dot2,
        *ashlsi3_imm_mask, *ashlsi3_imm_mask_dot, *ashlsi3_imm_mask_dot2,
        *lshrsi3_imm_mask, *lshrsi3_imm_mask_dot, *lshrsi3_imm_mask_dot2):
        Delete.
        (ashr<mode>3): Delete expander.
        (*ashr<mode>3): Rename to ...
        (ashr<mode>3): ... This.
        (ashrdi3_no_power, *ashrdisi3_noppc64be): Delete.
        (*rotldi3_internal4, *rotldi3_internal5 and split,
        *rotldi3_internal6 and split, *ashldi3_internal4, ashldi3_internal5
        and split, *ashldi3_internal6 and split, *ashldi3_internal7,
        ashldi3_internal8 and split, *ashldi3_internal9 and split): Delete.
        (*anddi3_2rld, *anddi3_2rld_dot, *anddi3_2rld_dot2): Delete.
        (splitter for loading a mask): Adjust.
        * doc/md.texi (Machine Constraints): Remove q, S, T, t constraints.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/constraints.md
    trunk/gcc/config/rs6000/predicates.md
    trunk/gcc/config/rs6000/rs6000-protos.h
    trunk/gcc/config/rs6000/rs6000.c
    trunk/gcc/config/rs6000/rs6000.md
    trunk/gcc/doc/md.texi