[Bug c/66233] New: internal compiler error: in expand_fix, at optabs.c:5358

[Bug c/66233] New: internal compiler error: in expand_fix, at optabs.c:5358

[usignao at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

            Bug ID: 66233
           Summary: internal compiler error: in expand_fix, at
                    optabs.c:5358
           Product: gcc
           Version: 4.9.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: usignao at gmail dot com
  Target Milestone: ---

Hello! The error is produced by the following (invalid) code

/* oops.c */
unsigned int pData[5];
void f() {
        int i;
        for(i=0; i<5; i++) {
                pData[i] = (float) i;
        }
}

$ gcc -O3 -Wall -Wextra -o oops.o -c oops.c
oops.c: In function ‘f’:
oops.c:6:12: internal compiler error: in expand_fix, at optabs.c:5358
   pData[i] = (float) i;
            ^


No warnings are given. I'm on Linux x64, gcc version is 4.9.2, but according to
the godbolt.org all the versions from 4.8 up to 5.1.0 are also affected.
>From gcc-bugs-return-486874-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 21 06:50:16 2015
Return-Path: <gcc-bugs-return-486874-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 51764 invoked by alias); 21 May 2015 06:50:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 48773 invoked by uid 55); 21 May 2015 06:50:12 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/52952] Wformat location info is bad (wrong column number)
Date: Thu, 21 May 2015 06:50:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-52952-4-DGDDq0Z2Ug@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-52952-4@http.gcc.gnu.org/bugzilla/>
References: <bug-52952-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01714.txt.bz2
Content-length: 2032

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52952

--- Comment #38 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Thu May 21 06:49:38 2015
New Revision: 223470

URL: https://gcc.gnu.org/viewcvs?rev=223470&root=gcc&view=rev
Log:
gcc/testsuite/ChangeLog:

2015-05-21  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR c/52952
        * gcc.dg/redecl-4.c: Update column numbers.
        * gcc.dg/format/bitfld-1.c: Likewise.
        * gcc.dg/format/attr-2.c: Likewise.
        * gcc.dg/format/attr-6.c: Likewise.
        * gcc.dg/format/attr-7.c (baz): Likewise.
        * gcc.dg/format/asm_fprintf-1.c: Likewise.
        * gcc.dg/format/attr-4.c: Likewise.
        * gcc.dg/format/branch-1.c: Likewise.
        * gcc.dg/format/c90-printf-1.c: Likewise. Add tests for column
        locations within strings with embedded escape sequences.

gcc/c-family/ChangeLog:

2015-05-21  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR c/52952
        * c-format.c (location_column_from_byte_offset): New.
        (location_from_offset): New.
        (struct format_wanted_type): Add offset_loc field.
        (check_format_info): Move handling of location for extra arguments
        closer to the point of warning.
        (check_format_info_main): Pass the result of location_from_offset
        to warning_at.
        (format_type_warning): Pass the result of location_from_offset
        to warning_at.


Modified:
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-format.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/format/asm_fprintf-1.c
    trunk/gcc/testsuite/gcc.dg/format/attr-2.c
    trunk/gcc/testsuite/gcc.dg/format/attr-4.c
    trunk/gcc/testsuite/gcc.dg/format/attr-6.c
    trunk/gcc/testsuite/gcc.dg/format/attr-7.c
    trunk/gcc/testsuite/gcc.dg/format/bitfld-1.c
    trunk/gcc/testsuite/gcc.dg/format/branch-1.c
    trunk/gcc/testsuite/gcc.dg/format/c90-printf-1.c
    trunk/gcc/testsuite/gcc.dg/redecl-4.c
>From gcc-bugs-return-486875-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 21 07:06:37 2015
Return-Path: <gcc-bugs-return-486875-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 101899 invoked by alias); 21 May 2015 07:06:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 101824 invoked by uid 48); 21 May 2015 07:06:33 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/52952] Wformat location info is bad (wrong column number)
Date: Thu, 21 May 2015 07:06:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-52952-4-yRNwSDTa6i@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-52952-4@http.gcc.gnu.org/bugzilla/>
References: <bug-52952-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01715.txt.bz2
Content-length: 476

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52952

--- Comment #39 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
A summary of what is still pending:

1. Handle macros

#define c               " %d "
  __builtin_printf(c, 0.5);

2. Handle non-contiguous strings:

  __builtin_printf(" %" "d ", 0.5);

3. Handle const arrays:

  const char a[] = " %d ";
  __builtin_printf(a, 0.5);


I have an idea on how to fix 1 and 2 but no idea how to fix 3.
>From gcc-bugs-return-486876-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 21 07:08:41 2015
Return-Path: <gcc-bugs-return-486876-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 105420 invoked by alias); 21 May 2015 07:08:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 105362 invoked by uid 48); 21 May 2015 07:08:37 -0000
From: "ossman at cendio dot se" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/61955] libsanitizer fails to compile on RHEL4
Date: Thu, 21 May 2015 07:08:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ossman at cendio dot se
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61955-4-eAqrgwVVlL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61955-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61955-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01716.txt.bz2
Content-length: 1010

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida955

Pierre Ossman <ossman at cendio dot se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossman at cendio dot se

--- Comment #4 from Pierre Ossman <ossman at cendio dot se> ---
Unfortunately the git history doesn't go further back than 2.6.12 so I don't
know when aio_abi.h got added. But the code only needs the enum, so something
like this should work:

#include <linux/version.h>
/* aio_abi.h was added in 2.6.10 (FIXME: check this) */
#if LINUX_VERSION_CODE < 132624
enum {
        IOCB_CMD_PREAD = 0,
        IOCB_CMD_PWRITE = 1,
        IOCB_CMD_FSYNC = 2,
        IOCB_CMD_FDSYNC = 3,
        IOCB_CMD_NOOP = 6,
};
#else
#include_next <linux/aio_abi.h>
#endif
/* IOCB_CMD_PREADV/PWRITEV has been added in 2.6.19 */
#if LINUX_VERSION_CODE < 132627
#define IOCB_CMD_PREADV 7
#define IOCB_CMD_PWRITEV 8
#endif

[Bug tree-optimization/66233] [4.8/4.9/5/6 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Sounds like gimple folding issue.
We have:
vect__4.9_31 = (vector(4) float) { 0, 1, 2, 3 };
vect__5.10_32 = (vector(4) unsigned int) vect__4.9_31;
where the first stmt's rhs_code is FLOAT_EXPR and rhs1 is VECTOR_CST vector(4)
int, and the second stmt's rhs_code is FIX_TRUNC_EXPR.
So, for this combined together we should use VIEW_CONVERT_EXPR, but we use
FIX_TRUNC_EXPR.

[Bug tree-optimization/66233] [4.8/4.9/5/6 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Seems this is the
/* Handle cases of two conversions in a row.  */
patterns in match.pd that are causing this.
I'd say the bug is that those simplifications are just handling
{inside,inter,final}_vec the same, no matter if it is vectors of float, ints,
unsigned ints etc.
Supposedly before match.pd has been added the bug was elsewhere, but similarly
didn't take care precisely what kind of vectors it is optimizing.
FLOAT_EXPR is used for conversion of vector {int,unsigned} to vector float,
FIX_TRUNC_EXPR fpr vector float to vector {int,unsigned} and convert
(NOP_EXPR/VIEW_CONVERT_EXPR?) for other conversions.

[Bug tree-optimization/66233] [4.8/4.9/5/6 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Indeed, in 4.9 this is in tree-ssa-forwprop.c (combine_conversions) and in
fold-const.c (fold_unary_loc).
Perhaps we need {inter,inside,final}_vec_{int,float,unsignedp} variables too
and use them?

[Bug tree-optimization/66233] [4.8/4.9/5/6 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu May 21 19:17:28 2015
New Revision: 223500

URL: https://gcc.gnu.org/viewcvs?rev=223500&root=gcc&view=rev
Log:
        PR tree-optimization/66233
        * match.pd (ocvt (icvt@1 @0)): Don't handle vector types.
        Simplify.

        * gcc.c-torture/execute/pr66233.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/pr66233.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/match.pd
    trunk/gcc/testsuite/ChangeLog

[Bug tree-optimization/66233] [4.8/4.9/5/6 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri May 22 08:12:08 2015
New Revision: 223522

URL: https://gcc.gnu.org/viewcvs?rev=223522&root=gcc&view=rev
Log:
        Backported from mainline
        2015-05-21  Jakub Jelinek  <jakub@redhat.com>

        PR tree-optimization/66233
        * match.pd (ocvt (icvt@1 @0)): Don't handle vector types.
        Simplify.

        * gcc.c-torture/execute/pr66233.c: New test.

Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.c-torture/execute/pr66233.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/match.pd
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug tree-optimization/66233] [4.8/4.9/5/6 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doko at gcc dot gnu.org

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 66554 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |5.2.0, 6.0
            Summary|[4.8/4.9/5/6 Regression]    |[4.8/4.9 Regression]
                   |internal compiler error: in |internal compiler error: in
                   |expand_fix, at              |expand_fix, at
                   |optabs.c:5358               |optabs.c:5358

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk/5.

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ok, I'll look at the 4.9/4.8 fix then.

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 35800
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35800&action=edit
gcc49-pr66233.patch

Untested 4.9 version of the fix.

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #11 from Matthias Klose <doko at gcc dot gnu.org> ---
the proposed patch fixes the test case from PR66554 on aarch64-linux-gnu.

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Jun 18 14:03:50 2015
New Revision: 224609

URL: https://gcc.gnu.org/viewcvs?rev=224609&root=gcc&view=rev
Log:
        PR tree-optimization/66233
        * fold-const.c (fold_unary_loc): Don't handle vector types.
        Simplify.
        * tree-ssa-forwprop.c (combine_conversions): Likewise.

        * gcc.c-torture/execute/pr66233.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.c-torture/execute/pr66233.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/fold-const.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/tree-ssa-forwprop.c

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Jun 18 14:06:04 2015
New Revision: 224611

URL: https://gcc.gnu.org/viewcvs?rev=224611&root=gcc&view=rev
Log:
        PR tree-optimization/66233
        * fold-const.c (fold_unary_loc): Don't handle vector types.
        Simplify.
        * tree-ssa-forwprop.c (combine_conversions): Likewise.

        * gcc.c-torture/execute/pr66233.c: New test.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.c-torture/execute/pr66233.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/fold-const.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-ssa-forwprop.c

[Bug tree-optimization/66233] [4.8/4.9 Regression] internal compiler error: in expand_fix, at optabs.c:5358

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66233

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.