public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "lhyatt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/66290] wrong location for -Wunused-macros Date: Tue, 12 Jul 2022 13:40:35 +0000 [thread overview] Message-ID: <bug-66290-4-gYyVna4TUC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-66290-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66290 --- Comment #4 from Lewis Hyatt <lhyatt at gcc dot gnu.org> --- OK, I understand now why done_lexing is necessary, plenty of places call back into libcpp after lexing, e.g. to interpret strings, and this may generate warnings. I think that one line patch is the way to go then. diff --git a/gcc/c-family/c-opts.cc b/gcc/c-family/c-opts.cc index b9f01a65ed7..25a3c50de8e 100644 --- a/gcc/c-family/c-opts.cc +++ b/gcc/c-family/c-opts.cc @@ -1283,6 +1283,7 @@ c_common_finish (void) /* For performance, avoid tearing down cpplib's internal structures with cpp_destroy (). */ + done_lexing = false; cpp_finish (parse_in, deps_stream); if (deps_stream && deps_stream != out_stream && deps_stream != stdout
next prev parent reply other threads:[~2022-07-12 13:40 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-26 12:06 [Bug c++/66290] New: " manu at gcc dot gnu.org 2022-07-11 21:53 ` [Bug c++/66290] " lhyatt at gcc dot gnu.org 2022-07-12 13:40 ` lhyatt at gcc dot gnu.org [this message] 2022-07-28 14:15 ` lhyatt at gcc dot gnu.org 2022-07-31 12:13 ` cvs-commit at gcc dot gnu.org 2022-07-31 12:15 ` lhyatt at gcc dot gnu.org 2022-08-05 16:17 ` lhyatt at gcc dot gnu.org 2023-06-20 22:04 ` cvs-commit at gcc dot gnu.org 2023-06-20 22:05 ` lhyatt at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-66290-4-gYyVna4TUC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).