[Bug c/66314] New: ice in verify_loop_structure

[Bug c/66314] New: ice in verify_loop_structure

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

            Bug ID: 66314
           Summary: ice in verify_loop_structure
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Created attachment 35637
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35637&action=edit
C source code

For trunk gcc dated 20150527

crypto/asymmetric_keys/pkcs7_trust.c: In function ‘pkcs7_validate_trust’:
crypto/asymmetric_keys/pkcs7_trust.c:168:5: error: size of loop 2 should be 36,
not 38
 int pkcs7_validate_trust(struct pkcs7_message *pkcs7,
     ^
crypto/asymmetric_keys/pkcs7_trust.c:168:5: internal compiler error: in
verify_loop_structure, at cfgloop.c:1662
0x7166e3 verify_loop_structure()
        ../../src/trunk/gcc/cfgloop.c:1662
0xa13f47 loop_optimizer_init(unsigned int)
        ../../src/trunk/gcc/loop-init.c:124
0xe4a53a execute_vrp
        ../../src/trunk/gcc/tree-vrp.c:10377
0xe4a53a execute
        ../../src/trunk/gcc/tree-vrp.c:10474
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

Flags -std=gnu89 -Os -fprofile-arcs -fsanitize=kernel-address
required. Code derived from Linux kernel, so probably quite important.
>From gcc-bugs-return-487432-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 27 19:16:28 2015
Return-Path: <gcc-bugs-return-487432-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26065 invoked by alias); 27 May 2015 19:16:28 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26030 invoked by uid 55); 27 May 2015 19:16:23 -0000
From: "andi at firstfloor dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/66305] -ffat-lto-objects create unreproducible objects
Date: Wed, 27 May 2015 19:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 5.1.1
X-Bugzilla-Keywords: lto
X-Bugzilla-Severity: normal
X-Bugzilla-Who: andi at firstfloor dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66305-4-XUQcYqWdja@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66305-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66305-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg02272.txt.bz2
Content-length: 1201

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf305

--- Comment #4 from andi at firstfloor dot org ---
> --- Comment #3 from lunar at debian dot org ---
> Richard Biener:
> > I think they become deterministic with -frandom-seed=0 for example.
> > They are not deterministic to support partial linking of LTO objects as far
> > as I know.
>
> They are indeed reproducible with `-frandom-seed=0`. But I guess there's a
> downside to that, right?

The downside is that incremential linking (ld -r) does not work.
But the random seed is used for other things in gcc too, so you may
have other problems too.

> > similar, which would be a bit more deterministic, but there are still
> > ways this could break (e.g. if someone copies object files around)
>
> Would using a hash over the section content work? In any cases, in the context
> of Debian (this applies for FreeBSD as well), we have a canonical build path
> so it would probably be fine to use it as the source of the hash.
>
> I guess one could already do this without further help by giving the
> build path to `-frandom-seed=`. This only would need some Makefile trickery.

Yes. It would probably be easier in gcc, e.g. with a new option.

[Bug middle-end/66314] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-05-28
          Component|c                           |middle-end
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |5.1.0
   Target Milestone|---                         |6.0
            Summary|ice in                      |[6 Regression] ice in
                   |verify_loop_structure       |verify_loop_structure

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Broken by DOM2.

Can somebody reduce this?

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

--- Comment #3 from ktkachov at gcc dot gnu.org ---
Created attachment 35644
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35644&action=edit
Reduced testcase

Confirmed on aarch64-none-elf with current trunk.
Attaching reduced testcase

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
char *a;
int b, c, d;

static int
fn1 (int b, int c)
{
  while (a)
    if (*a)
      return -126;
  if (b)
    return -12;
  if (c == -12)
    return c;
}

void
fn2 (int b, int c)
{
  for (;;)
    {
      d = fn1 (b, c);
      switch (d)
        {
        case -126:
          continue;
        default:
          return;
        }
    }
}

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #4)
> char *a;
> int b, c, d;

int d;
is enough I guess.

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Fri May 29 10:50:58 2015
New Revision: 223861

URL: https://gcc.gnu.org/viewcvs?rev=223861&root=gcc&view=rev
Log:
2015-05-29  Richard Biener  <rguenther@suse.de>

        PR tree-optimization/66314
        * tree-ssa-threadupdate.c (create_block_for_threading): Add
        parameter that says which loop the new block belongs to.
        (ssa_create_duplicates): Blocks duplicated for the threaded
        path belong to the loop of the thread destination.

        * gcc.dg/asan/pr66314.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/asan/pr66314.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-threadupdate.c

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Mon Jun  1 13:55:12 2015
New Revision: 223979

URL: https://gcc.gnu.org/viewcvs?rev=223979&root=gcc&view=rev
Log:
2015-06-01  Richard Biener  <rguenther@suse.de>

        Revert
        2015-05-29  Richard Biener  <rguenther@suse.de>

        PR tree-optimization/66314
        * tree-ssa-threadupdate.c (create_block_for_threading): Add
        parameter that says which loop the new block belongs to.
        (ssa_create_duplicates): Blocks duplicated for the threaded
        path belong to the loop of the thread destination.

        * gcc.dg/asan/pr66314.c: New testcase.

Removed:
    trunk/gcc/testsuite/gcc.dg/asan/pr66314.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-threadupdate.c

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Reopen.

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Adding         gcc/testsuite/gcc.dg/torture/pr66349.c
Adding         gcc/testsuite/gcc.dg/torture/pr66357.c
Adding         gcc/testsuite/gfortran.fortran-torture/compile/pr66352.f90

were added for the regressions caused by the original fix.

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hpa at zytor dot com

--- Comment #11 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
*** Bug 66899 has been marked as a duplicate of this bug. ***

[Bug middle-end/66314] [6 Regression] ice in verify_loop_structure

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66314

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jeffrey A. Law <law at redhat dot com> ---
Fixed on trunk