public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/66322] Linus Torvalds: -Wswitch-bool produces dubious warnings, fails to notice really bad things Date: Thu, 28 May 2015 09:29:00 -0000 [thread overview] Message-ID: <bug-66322-4-8QvPN3TXq5@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-66322-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66322 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpolacek at gcc dot gnu.org --- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Of course, I don't think switch ((int)boolean) { switch 1: is better or nice, and I wouldn't want to encourage writing such a code, the cast (you don't really have to change true to 1) is only meant as a way to quash the warning. But switch (boolean) seemed to be too obscure that giving a warning there didn't feel too far-fetched; especially if you can use the cast (in C, integer promotions are performed on the controlling expression anyway) if you really want that. To fix this, I think I'll have to defer the warning until c_finish_case and add some flag to c_switch struct and track whether the controlling expression had boolean type there. Then in c_do_switch_warnings decide if we want to warn or not.
next prev parent reply other threads:[~2015-05-28 9:29 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-28 6:51 [Bug preprocessor/66322] New: " t.artem at mailcity dot com 2015-05-28 8:14 ` [Bug c/66322] " manu at gcc dot gnu.org 2015-05-28 9:29 ` mpolacek at gcc dot gnu.org [this message] 2015-05-28 9:38 ` mpolacek at gcc dot gnu.org 2015-05-28 10:31 ` nszabolcs at gmail dot com 2015-05-28 11:37 ` manu at gcc dot gnu.org 2015-06-22 18:16 ` mpolacek at gcc dot gnu.org 2015-06-29 13:13 ` mpolacek at gcc dot gnu.org 2015-10-22 9:14 ` mpolacek at gcc dot gnu.org 2022-01-11 21:00 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-66322-4-8QvPN3TXq5@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).