public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nszabolcs at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/66322] Linus Torvalds: -Wswitch-bool produces dubious warnings, fails to notice really bad things
Date: Thu, 28 May 2015 10:31:00 -0000	[thread overview]
Message-ID: <bug-66322-4-EnybnNWBSC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-66322-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66322

Szabolcs Nagy <nszabolcs at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nszabolcs at gmail dot com

--- Comment #5 from Szabolcs Nagy <nszabolcs at gmail dot com> ---
i don't mind the warning (there are other warnings in gcc with false
positives), but the documentation must not encourage the use of casts for
dealing with it.

that is dangerous and much worse than the original problem: the cast turns off
the type-system so if the type of the expression later changes then anything
goes (pointers, floats, different int types).

so i think this is the real bug:
https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/Warning-Options.html#index-Wswitch-bool-362


  parent reply	other threads:[~2015-05-28 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  6:51 [Bug preprocessor/66322] New: " t.artem at mailcity dot com
2015-05-28  8:14 ` [Bug c/66322] " manu at gcc dot gnu.org
2015-05-28  9:29 ` mpolacek at gcc dot gnu.org
2015-05-28  9:38 ` mpolacek at gcc dot gnu.org
2015-05-28 10:31 ` nszabolcs at gmail dot com [this message]
2015-05-28 11:37 ` manu at gcc dot gnu.org
2015-06-22 18:16 ` mpolacek at gcc dot gnu.org
2015-06-29 13:13 ` mpolacek at gcc dot gnu.org
2015-10-22  9:14 ` mpolacek at gcc dot gnu.org
2022-01-11 21:00 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-66322-4-EnybnNWBSC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).