[Bug libstdc++/66327] New: -fsanitize=nonnull-attribute errors in stl_algobase.h

[Bug libstdc++/66327] New: -fsanitize=nonnull-attribute errors in stl_algobase.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66327

            Bug ID: 66327
           Summary: -fsanitize=nonnull-attribute errors in stl_algobase.h
           Product: gcc
           Version: 5.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org
  Target Milestone: ---

#include <vector>
#include <array>

int main()
{
   std::vector<unsigned> a;
   std::vector<unsigned> b;
   std::array<unsigned char, 0> aa, bb;
   a == b;
   a < b;
   aa == bb;
   aa < bb;
}

/home/jwakely/gcc/5.1.0/include/c++/5.1.0/bits/stl_algobase.h:825:28: runtime
error: null pointer passed as argument 1, which is declared to never be null
/home/jwakely/gcc/5.1.0/include/c++/5.1.0/bits/stl_algobase.h:825:28: runtime
error: null pointer passed as argument 2, which is declared to never be null
/home/jwakely/gcc/5.1.0/include/c++/5.1.0/bits/stl_algobase.h:825:28: runtime
error: null pointer passed as argument 1, which is declared to never be null
/home/jwakely/gcc/5.1.0/include/c++/5.1.0/bits/stl_algobase.h:825:28: runtime
error: null pointer passed as argument 2, which is declared to never be null
/home/jwakely/gcc/5.1.0/include/c++/5.1.0/bits/stl_algobase.h:931:31: runtime
error: null pointer passed as argument 1, which is declared to never be null
/home/jwakely/gcc/5.1.0/include/c++/5.1.0/bits/stl_algobase.h:931:31: runtime
error: null pointer passed as argument 2, which is declared to never be null

[Bug libstdc++/66327] -fsanitize=nonnull-attribute errors in stl_algobase.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66327

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-05-28
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug libstdc++/66327] -fsanitize=nonnull-attribute errors in stl_algobase.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66327

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri May 29 13:28:54 2015
New Revision: 223865

URL: https://gcc.gnu.org/viewcvs?rev=223865&root=gcc&view=rev
Log:
        PR libstdc++/66327
        * include/bits/stl_algobase.h (__equal<true>::equal): Do not call
        memcmp with null pointers.
        (__lexicographical_compare<true>::__lc): Do not call memcmp for empty
        ranges.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/stl_algobase.h

[Bug libstdc++/66327] -fsanitize=nonnull-attribute errors in stl_algobase.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66327

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Jun  8 14:19:10 2015
New Revision: 224230

URL: https://gcc.gnu.org/viewcvs?rev=224230&root=gcc&view=rev
Log:
        PR libstdc++/66354
        * include/bits/stl_algobase.h (__fill_a): Check length before calling
        memset.

        PR libstdc++/66327
        * include/bits/stl_algobase.h (__equal<true>::equal): Do not call
        memcmp for empty ranges.
        (__lexicographical_compare<true>::__lc): Likewise.

Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/include/bits/stl_algobase.h

[Bug libstdc++/66327] -fsanitize=nonnull-attribute errors in stl_algobase.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66327

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Jun  8 14:42:02 2015
New Revision: 224233

URL: https://gcc.gnu.org/viewcvs?rev=224233&root=gcc&view=rev
Log:
        PR libstdc++/66354
        * include/bits/stl_algobase.h (__fill_a): Check length before calling
        memset.

        PR libstdc++/66327
        * include/bits/stl_algobase.h (__equal<true>::equal): Do not call
        memcmp for empty ranges.
        (__lexicographical_compare<true>::__lc): Likewise.

Modified:
    branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_9-branch/libstdc++-v3/include/bits/stl_algobase.h

[Bug libstdc++/66327] -fsanitize=nonnull-attribute errors in stl_algobase.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66327

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.3

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 4.9.3, 5.2 and 6.0