public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vmakarov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/66334] cleanup block fails to initialize EBX
Date: Fri, 03 Jul 2015 21:04:00 -0000	[thread overview]
Message-ID: <bug-66334-4-GBUraIfdiN@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-66334-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66334

--- Comment #9 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #8)
> (In reply to Vladimir Makarov from comment #7)
> > I've looked at this.  Insn 34 is transformed into
> > 
> > ebx=ebx
> > 
> > as pseudo 87 gets ebx.  At the very end. LRA removes the useless insn.  
> > Therefore there is no insn setting ebx.
> > 
> > H.J., is it really a problem?
> 
> The problem is although ebx, which is used for PIC, is callee saved, but
> ebx has junk when called from BUILT_IN_UNWIND_RESUME.  LRA should
> reinitialize it.

I see.  It would be nice that eh machinary saved ebx.  But even if it is done,
we would have compatibility problem with already existing code.  So there is no
other way than fixing it GCC.

I guess it is a continuation of work to use PIC hard reg by introducing PIC
pseudo.  PIC pseudo should conflict with PIC hard reg because ebx can be
corrupted in this case.  So in general your solution proposal is right but it
needs more details.

I will work on the patch and commit it on next week.

Thanks.


  parent reply	other threads:[~2015-07-03 21:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  2:50 [Bug middle-end/66334] New: " hjl.tools at gmail dot com
2015-05-29  2:56 ` [Bug middle-end/66334] " hjl.tools at gmail dot com
2015-05-29 20:37 ` hjl.tools at gmail dot com
2015-05-29 21:54 ` hjl.tools at gmail dot com
2015-05-29 21:55 ` hjl.tools at gmail dot com
2015-05-31 13:16 ` hjl.tools at gmail dot com
2015-06-01 14:21 ` hjl.tools at gmail dot com
2015-07-03 17:25 ` vmakarov at gcc dot gnu.org
2015-07-03 18:42 ` hjl.tools at gmail dot com
2015-07-03 21:04 ` vmakarov at gcc dot gnu.org [this message]
2015-07-04 13:57 ` hjl.tools at gmail dot com
2015-07-07 19:35 ` vmakarov at gcc dot gnu.org
2015-07-08 15:05 ` vmakarov at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-66334-4-GBUraIfdiN@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).