[Bug libstdc++/66354] New: [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[Bug libstdc++/66354] New: [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[dimhen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

            Bug ID: 66354
           Summary: [UBSAN] stl_algobase.h:708:7: runtime error: null
                    pointer passed as argument
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dimhen at gmail dot com
  Target Milestone: ---

Sorry, I have no compact testcase.

/usr/local/gcc_current/include/c++/6.0.0/bits/stl_algobase.h:708:7: runtime
error: null pointer passed as argument 1, which is declared to never be null

$ /usr/local/gcc_current/bin/g++ -v
Using built-in specs.
COLLECT_GCC=/usr/local/gcc_current/bin/g++
COLLECT_LTO_WRAPPER=/usr/local/gcc_current/libexec/gcc/x86_64-unknown-linux-gnu/6.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /home/dimhen/src/gcc_current/configure
--prefix=/usr/local/gcc_current --enable-static
--enable-checking=yes,df,fold,rtl --enable-languages=c,c++,lto --enable-plugin
--disable-libstdcxx-dual-abi --disable-multilib
Thread model: posix
gcc version 6.0.0 20150531 (experimental) [trunk revision 223898] (GCC)

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Dmitry G. Dyachenko from comment #0)
> Sorry, I have no compact testcase.

Could you at least use -fno-sanitize-recover=undefined and look at the stack
trace where it happens?

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-05-31
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
#include <vector>

int main()
{
  std::vector<unsigned char> v;
  v.assign(0, 'a');
}

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Sun May 31 22:42:17 2015
New Revision: 223906

URL: https://gcc.gnu.org/viewcvs?rev=223906&root=gcc&view=rev
Log:
        PR libstdc++/66354
        * include/bits/stl_algobase.h (__fill_a): Check length before calling
        memset.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/stl_algobase.h

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[dimhen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

Dmitry G. Dyachenko <dimhen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Dmitry G. Dyachenko <dimhen at gmail dot com> ---
r223920 PASS for me

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Jun  8 14:19:10 2015
New Revision: 224230

URL: https://gcc.gnu.org/viewcvs?rev=224230&root=gcc&view=rev
Log:
        PR libstdc++/66354
        * include/bits/stl_algobase.h (__fill_a): Check length before calling
        memset.

        PR libstdc++/66327
        * include/bits/stl_algobase.h (__equal<true>::equal): Do not call
        memcmp for empty ranges.
        (__lexicographical_compare<true>::__lc): Likewise.

Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/include/bits/stl_algobase.h

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Jun  8 14:42:02 2015
New Revision: 224233

URL: https://gcc.gnu.org/viewcvs?rev=224233&root=gcc&view=rev
Log:
        PR libstdc++/66354
        * include/bits/stl_algobase.h (__fill_a): Check length before calling
        memset.

        PR libstdc++/66327
        * include/bits/stl_algobase.h (__equal<true>::equal): Do not call
        memcmp for empty ranges.
        (__lexicographical_compare<true>::__lc): Likewise.

Modified:
    branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_9-branch/libstdc++-v3/include/bits/stl_algobase.h

[Bug libstdc++/66354] [UBSAN] stl_algobase.h:708:7: runtime error: null pointer passed as argument

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66354

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.3

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 4.9.3, 5.2 and 6.0