[Bug fortran/66380] New: ICE for intrinsic reshape with insufficient number of array elements

[Bug fortran/66380] New: ICE for intrinsic reshape with insufficient number of array elements

[gerhard.steinmetz.fortran@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66380

            Bug ID: 66380
           Summary: ICE for intrinsic reshape with insufficient number of
                    array elements
           Product: gcc
           Version: 5.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gerhard.steinmetz.fortran@t-online.de
  Target Milestone: ---

This code with less array elements than requested via shape sh :

   program p
      integer, parameter :: sh(2) = [2, 3]
      integer, parameter :: a(2,2) = reshape([1, 2, 3, 4], sh)
      print *, a
   end

yields :
f951: internal compiler error: in gfc_simplify_reshape, at
fortran/simplify.c:5177

---

Whereas this version :

   program p
      integer, parameter :: sh(2) = [2, 1]
      integer, parameter :: a(2,2) = reshape([1, 2, 3, 4], sh)
      print *, a
   end

flags an error :

    integer, parameter :: a(2,2) = reshape([1, 2, 3, 4], sh)
                               1
Error: Different shape for array assignment at (1) on dimension 2 (2 and 1)

[Bug fortran/66380] ICE for intrinsic reshape with insufficient number of array elements

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66380

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #1 from kargl at gcc dot gnu.org ---
Created attachment 35681
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35681&action=edit
patch to fix ICE

[Bug fortran/66380] ICE for intrinsic reshape with insufficient number of array elements

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66380

--- Comment #2 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
The problem is that an assertion is triggered for
a PAD size that is less than or equal to zero.  
The assertion should be an error condition.  The
patch that I attached does this.

[Bug fortran/66380] ICE for intrinsic reshape with insufficient number of array elements

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66380

--- Comment #3 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Tue Jun  2 23:02:05 2015
New Revision: 224049

URL: https://gcc.gnu.org/viewcvs?rev=224049&root=gcc&view=rev
Log:
2015-06-02  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/66380
        * simplify.c (gfc_simplify_reshape): Convert assert into returning
        NULL, which triggers an error condition.

2015-06-02  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/66380
        * gfortran.dg/reshape_7.f90: New test.

Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/reshape_7.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/simplify.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug fortran/66380] ICE for intrinsic reshape with insufficient number of array elements

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66380

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from kargl at gcc dot gnu.org ---
Fixed on trunk and 5-branch.  Thanks for the bug report.