[Bug libfortran/66385] New: ICE: FORALL writing multiple elements of one array

[Bug libfortran/66385] New: ICE: FORALL writing multiple elements of one array

[wangmianzhi1 at linuxmail dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

            Bug ID: 66385
           Summary: ICE: FORALL writing multiple elements of one array
           Product: gcc
           Version: 4.9.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: wangmianzhi1 at linuxmail dot org
  Target Milestone: ---

The ICE is triggered when compiling the following code with -O1 or higher -O
levels.

program test
  double precision::a(30)

  forall(i=1:10)
    a(10*[0,1,2]+i)=1d0
  end forall
end program

[Bug libfortran/66385] ICE: FORALL writing multiple elements of one array

[wangmianzhi1 at linuxmail dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

--- Comment #1 from Mianzhi Wang <wangmianzhi1 at linuxmail dot org> ---
The bug is bypassed by -fno-frontend-optimize, same as in the case of 66050 and
66386.

[Bug fortran/66385] ICE: FORALL writing multiple elements of one array

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 66386 has been marked as a duplicate of this bug. ***

[Bug fortran/66385] [4.9/5/6 Regression] ICE: FORALL writing multiple elements of one array

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |4.8.4
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|                            |2015-06-03
                 CC|                            |tkoenig at gcc dot gnu.org
     Ever confirmed|0                           |1
            Summary|ICE: FORALL writing         |[4.9/5/6 Regression] ICE:
                   |multiple elements of one    |FORALL writing multiple
                   |array                       |elements of one array
      Known to fail|                            |4.9.2, 5.1.0, 6.0

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The ICE appeared between revisions r197010 (2013-03-23, OK) and r197238
(2013-03-29, ICE), likely r197216 (pr55806) or r197217 (pr45159).

[Bug fortran/66385] [4.9/5/6 Regression] ICE: FORALL writing multiple elements of one array

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

--- Comment #4 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
*** Bug 66050 has been marked as a duplicate of this bug. ***

[Bug fortran/66385] [4.9/5/6 Regression] ICE: FORALL writing multiple elements of one array

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |36854

--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
As I wrote in the other PR, BLOCKs created by front-end optimization and FORALL
don't mix well.

The solution is not to attempt that particular optimization within a FORALL.

Index: frontend-passes.c
===================================================================
--- frontend-passes.c   (Revision 223876)
+++ frontend-passes.c   (Arbeitskopie)
@@ -1243,6 +1243,10 @@ combine_array_constructor (gfc_expr *e)
   if (in_assoc_list)
     return false;

+  /* With FORALL, the BLOCKS created by create_var will cause an ICE.  */
+  if (forall_level > 0)
+    return false;
+
   op1 = e->value.op.op1;
   op2 = e->value.op.op2;


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36854
[Bug 36854] [meta-bug] fortran front-end optimization

[Bug fortran/66385] [4.9/5/6 Regression] ICE: FORALL writing multiple elements of one array

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

--- Comment #6 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Fri Jun  5 20:51:08 2015
New Revision: 224172

URL: https://gcc.gnu.org/viewcvs?rev=224172&root=gcc&view=rev
Log:
2015-06-05  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/66385
        * frontend-passes.c (combine_array_constructor): Return early if
        inside a FORALL loop.

2015-06-05  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/66385
        * gfortran.dg/forall_17.f90:  New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/forall_17.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/frontend-passes.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/66385] [4.9/5/6 Regression] ICE: FORALL writing multiple elements of one array

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

--- Comment #7 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Sun Jun 14 10:08:00 2015
New Revision: 224465

URL: https://gcc.gnu.org/viewcvs?rev=224465&root=gcc&view=rev
Log:
2015-06-14  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/66385
        Backport from trunk
        * frontend-passes.c (combine_array_constructor): Return early if
        inside a FORALL loop.

2015-06-14  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/66385
        * gfortran.dg/forall_17.f90:  New test.



Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/forall_17.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/frontend-passes.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug fortran/66385] [4.9/5/6 Regression] ICE: FORALL writing multiple elements of one array

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.4

[Bug fortran/66385] [4.9 Regression] ICE: FORALL writing multiple elements of one array

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fixed on all affected branches, closing.

[Bug fortran/66385] [4.9 Regression] ICE: FORALL writing multiple elements of one array

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66385

--- Comment #8 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Sun Oct 18 11:29:37 2015
New Revision: 228943

URL: https://gcc.gnu.org/viewcvs?rev=228943&root=gcc&view=rev
Log:
2015-10-18  Thomas Koenig  <tkoenig@gcc.gnu.org>

        Backport from trunk
        PR fortran/66385
        * frontend-passes.c (combine_array_constructor): Return early if
        inside a FORALL loop.

2015-10-18  Thomas Koenig  <tkoenig@gcc.gnu.org>

        Backport from trunk
        PR fortran/66385
        * gfortran.dg/forall_17.f90:  New test.


Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/forall_17.f90
Modified:
    branches/gcc-4_9-branch/gcc/fortran/ChangeLog
    branches/gcc-4_9-branch/gcc/fortran/frontend-passes.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog