public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE
       [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
@ 2015-06-05 10:19 ` vries at gcc dot gnu.org
  2015-06-05 22:11 ` vries at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2015-06-05 10:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66429

--- Comment #1 from vries at gcc dot gnu.org ---
ICE still reproduces with command line:
...
$ gcc for-2.c -fopenmp -O2 -S
..

and pruned for-2.c:
...
float b[10][15][10];

__attribute__((noreturn)) void
noreturn (void)
{
  for (;;);
}

__attribute__((noinline, noclone)) void
f12_pf_simd_static32 (int n)
{
  int i;

#pragma omp parallel for simd schedule(static, 32) collapse(3)
  for (i = 0; i < 10; i++)
    for (int j = n; j < 8; j++)
      for (long k = -10; k < 10; k++)
 {
   b[i][j][k] += 16;
   noreturn ();
   b[i][j][k] -= 32;
 }
}
...


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE
       [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
  2015-06-05 10:19 ` [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE vries at gcc dot gnu.org
@ 2015-06-05 22:11 ` vries at gcc dot gnu.org
  2015-06-15 12:49 ` jakub at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2015-06-05 22:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66429

--- Comment #2 from vries at gcc dot gnu.org ---
submitted patches for superfluous std and fopenmp options:
- https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00486.html
- https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00487.html


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE
       [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
  2015-06-05 10:19 ` [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE vries at gcc dot gnu.org
  2015-06-05 22:11 ` vries at gcc dot gnu.org
@ 2015-06-15 12:49 ` jakub at gcc dot gnu.org
  2015-06-17 18:10 ` [Bug middle-end/66429] " jakub at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-15 12:49 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66429

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-06-15
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 35784
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35784&action=edit
gcc6-pr66429.patch

Untested fix.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/66429] ICE in expand_GOMP_SIMD_LAST_LANE
       [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2015-06-15 12:49 ` jakub at gcc dot gnu.org
@ 2015-06-17 18:10 ` jakub at gcc dot gnu.org
  2015-06-17 18:12 ` jakub at gcc dot gnu.org
  2015-06-17 19:04 ` jakub at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-17 18:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66429

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Jun 17 18:10:23 2015
New Revision: 224570

URL: https://gcc.gnu.org/viewcvs?rev=224570&root=gcc&view=rev
Log:
2015-06-17  Jakub Jelinek  <jakub@redhat.com>

        PR middle-end/66429
        * omp-low.c (expand_omp_taskreg, expand_omp_target): Use child_cfun
        instead of DECL_STRUCT_FUNCTION (child_fn).  Or in has_simduid_loops
        and has_force_vectorize_loops flags from cfun into
        child_cfun.
        (expand_omp_simd): For broken loop, set cfun->has_simduid_loops
        if simduid is non-NULL.
        * tree-pass.h (make_pass_simduid_cleanup): New prototype.
        * passes.def (pass_simduid_cleanup): Add new pass after loop
        passes.
        * tree-vectorizer.c (adjust_simduid_builtins): Remove one unnecessary
        indirection from htab argument's type.
        (shrink_simd_arrays): New function.
        (vectorize_loops): Use it.  Adjust adjust_simduid_builtins caller.
        Don't call adjust_simduid_builtins if there are no loops.
        (pass_data_simduid_cleanup, pass_simduid_cleanup): New variables.
        (pass_simduid_cleanup::execute): New method.
        (make_pass_simduid_cleanup): New function.

Added:
    branches/gcc-5-branch/gcc/testsuite/c-c++-common/gomp/pr66429.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/omp-low.c
    branches/gcc-5-branch/gcc/passes.def
    branches/gcc-5-branch/gcc/testsuite/ChangeLog
    branches/gcc-5-branch/gcc/tree-pass.h
    branches/gcc-5-branch/gcc/tree-vectorizer.c


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/66429] ICE in expand_GOMP_SIMD_LAST_LANE
       [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2015-06-17 18:10 ` [Bug middle-end/66429] " jakub at gcc dot gnu.org
@ 2015-06-17 18:12 ` jakub at gcc dot gnu.org
  2015-06-17 19:04 ` jakub at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-17 18:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66429

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Jun 17 18:11:42 2015
New Revision: 224571

URL: https://gcc.gnu.org/viewcvs?rev=224571&root=gcc&view=rev
Log:
        PR middle-end/66429
        * omp-low.c (expand_omp_taskreg, expand_omp_target): Use child_cfun
        instead of DECL_STRUCT_FUNCTION (child_fn).  Or in has_simduid_loops
        and has_force_vectorize_loops flags from cfun into
        child_cfun.
        (expand_omp_simd): For broken loop, set cfun->has_simduid_loops
        if simduid is non-NULL.
        * tree-pass.h (make_pass_simduid_cleanup): New prototype.
        * passes.def (pass_simduid_cleanup): Add new pass after loop
        passes.
        * tree-vectorizer.c (adjust_simduid_builtins): Remove one unnecessary
        indirection from htab argument's type.
        (shrink_simd_arrays): New function.
        (vectorize_loops): Use it.  Adjust adjust_simduid_builtins caller.
        Don't call adjust_simduid_builtins if there are no loops.
        (pass_data_simduid_cleanup, pass_simduid_cleanup): New variables.
        (pass_simduid_cleanup::execute): New method.
        (make_pass_simduid_cleanup): New function.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/66429] ICE in expand_GOMP_SIMD_LAST_LANE
       [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2015-06-17 18:12 ` jakub at gcc dot gnu.org
@ 2015-06-17 19:04 ` jakub at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-17 19:04 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66429

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-06-17 19:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-66429-4@http.gcc.gnu.org/bugzilla/>
2015-06-05 10:19 ` [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE vries at gcc dot gnu.org
2015-06-05 22:11 ` vries at gcc dot gnu.org
2015-06-15 12:49 ` jakub at gcc dot gnu.org
2015-06-17 18:10 ` [Bug middle-end/66429] " jakub at gcc dot gnu.org
2015-06-17 18:12 ` jakub at gcc dot gnu.org
2015-06-17 19:04 ` jakub at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).