[Bug target/66483] New: [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[Bug target/66483] New: [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

            Bug ID: 66483
           Summary: [4.9 Regression] ICE (in add_stores, at
                    var-tracking.c:6000) on arm-linux-gnueabihf
           Product: gcc
           Version: 4.9.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
  Target Milestone: ---

Created attachment 35737
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35737&action=edit
reduced file

seen with the 4.9 branch on arm-linux-gnueabihf. lowering optimization to -O1
or omitting -g works around the issue. works with the 4.8 branch and the trunk.

$ g++ -c -std=c++11 -g -O2 -fPIC -fstack-protector-strong -ffunction-sections
-fno-exceptions -frandom-seed=0 qxml.ii 
qxml.ii: In member function 'bool
QXmlSimpleReaderPrivate::isExpandedEntityValueTooLarge(QString*)':
qxml.ii:268:1: internal compiler error: in add_stores, at var-tracking.c:6000
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabihf/4.9/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion='Debian 4.9.2-20'
--with-bugurl=file:///usr/share/doc/gcc-4.9/README.Bugs
--enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-4.9 --enable-shared --enable-linker-build-id
--libexecdir=/usr/lib --without-included-gettext --enable-threads=posix
--with-gxx-include-dir=/usr/include/c++/4.9 --libdir=/usr/lib --enable-nls
--with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug
--enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libitm
--disable-libquadmath --enable-plugin --with-system-zlib
--disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.9-armhf/jre --enable-java-home
--with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.9-armhf
--with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.9-armhf
--with-arch-directory=arm --with-ecj-jar=/usr/share/java/eclipse-ecj.jar
--enable-objc-gc --enable-multiarch --disable-sjlj-exceptions
--with-arch=armv7-a --with-fpu=vfpv3-d16 --with-float=hard --with-mode=thumb
--enable-checking=release --build=arm-linux-gnueabihf
--host=arm-linux-gnueabihf --target=arm-linux-gnueabihf
Thread model: posix
gcc version 4.9.2 (Debian 4.9.2-20)

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #1 from Matthias Klose <doko at gcc dot gnu.org> ---
Created attachment 35738
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35738&action=edit
preprocessed source

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-06-10
                 CC|                            |ktkachov at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from ktkachov at gcc dot gnu.org ---
Confirmed on latest 4.9 with command line options:
-std=c++11 -g -O2 -fPIC -fstack-protector-strong -ffunction-sections
-fno-exceptions -frandom-seed=0 -mfloat-abi=hard -mfpu=vfpv3-d16 -mthumb
-march=armv7-a

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.9.3

--- Comment #3 from ktkachov at gcc dot gnu.org ---
Reducing...

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.4

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #4 from ktkachov at gcc dot gnu.org ---
(In reply to ktkachov from comment #3)
> Reducing...

The initial submission already includes a reduced testcase. Had not noticed
that

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[perezmeyer at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

Lisandro Damián Nicanor Pérez Meyer <perezmeyer at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |perezmeyer at gmail dot com

--- Comment #5 from Lisandro Damián Nicanor Pérez Meyer <perezmeyer at gmail dot com> ---
A very similar problem has been described in [bug] with even a fix which I
believe it's part of gcc5 [fix]

[bug] <http://patchwork.openembedded.org/patch/92055/>
[fix] <https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=212178>
>From gcc-bugs-return-488951-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 14 15:01:37 2015
Return-Path: <gcc-bugs-return-488951-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7104 invoked by alias); 14 Jun 2015 15:01:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7039 invoked by uid 48); 14 Jun 2015 15:01:33 -0000
From: "perezmeyer at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf
Date: Sun, 14 Jun 2015 15:01:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: perezmeyer at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66483-4-6lPO3svM3Y@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66483-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66483-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01283.txt.bz2
Content-length: 199

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #6 from Lisandro Damián Nicanor Pérez Meyer <perezmeyer at gmail dot com> ---
FWIW, it seems fixed in the linaro branch.
>From gcc-bugs-return-488952-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 14 15:28:22 2015
Return-Path: <gcc-bugs-return-488952-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 105208 invoked by alias); 14 Jun 2015 15:28:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 105137 invoked by uid 48); 14 Jun 2015 15:28:18 -0000
From: "thopre01 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf
Date: Sun, 14 Jun 2015 15:28:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: thopre01 at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-66483-4-x3QKW9qEBE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66483-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66483-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01284.txt.bz2
Content-length: 594

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf483

Thomas Preud'homme <thopre01 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joseph at codesourcery dot com,
                   |                            |thopre01 at gcc dot gnu.org

--- Comment #7 from Thomas Preud'homme <thopre01 at gcc dot gnu.org> ---
Hi Joseph,

It seems you already fixed this bug in trunk. Is there any plan to backport to
4.9 branch?

Best regards.

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[joseph at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #8 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
I have no backport plans for this patch.

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[thopre01 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #10 from Thomas Preud'homme <thopre01 at gcc dot gnu.org> ---
There is something strange about this bug. I compiled an arm-linux-gnueabihf
gcc only (using make all-gcc) twice, once with an arm-none-eabi cross binutils
in the PATH and once without. The bug is reproduced with the former case but
not the latter. I checked the objdump of object files in both case and most
files have no difference, with a few showing at first glance only small offset
difference.

Could there be a dangling pointer issue at play? r212178 can be backported
without issue but any full build of gcc for me falls in the latter case so I'm
not confident with the testing.

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.4                       |4.9.3

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[thopre01 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

Thomas Preud'homme <thopre01 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|thopre01 at gcc dot gnu.org        |unassigned at gcc dot gnu.org

--- Comment #11 from Thomas Preud'homme <thopre01 at gcc dot gnu.org> ---
Thinking about this, there cannot be a regression by removing an assert so
having the bug not fully reproducible should not be an issue. I'll continue
looking for the cause of such variance but the backport of r212178 can be made
right now.

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #12 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Tue Jun 23 10:08:11 2015
New Revision: 224833

URL: https://gcc.gnu.org/viewcvs?rev=224833&root=gcc&view=rev
Log:
2015-06-23  Matthias Klose  <doko@ubuntu.com>

        PR target/66483
        Backport from mainline r212178.
        2014-06-30  Joseph Myers  <joseph@codesourcery.com>

        * var-tracking.c (add_stores): Return instead of asserting if old
        and new values for conditional store are the same.

Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/var-tracking.c

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[thopre01 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #13 from Thomas Preud'homme <thopre01 at gcc dot gnu.org> ---
Thanks doko. I meant to do it today but lacked the time. As to the variation
issue I've been experiencing, I'll create a new PR when I isolate the source of
variation.

Best regards.

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Matthias Klose <doko at gcc dot gnu.org> ---
backported, no regressions running the testsuite on x86_64-linux-gnu and
arm-linux-gnueabihf.

[Bug target/66483] [4.9 Regression] ICE (in add_stores, at var-tracking.c:6000) on arm-linux-gnueabihf

[thopre01 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66483

--- Comment #15 from Thomas Preud'homme <thopre01 at gcc dot gnu.org> ---
(In reply to Thomas Preud'homme from comment #13)
> Thanks doko. I meant to do it today but lacked the time. As to the variation
> issue I've been experiencing, I'll create a new PR when I isolate the source
> of variation.

It was just a red herring. Having no compiler in the path lead to
HAVE_COMDAT_GROUP not to be defined which change the result of can_alias_cdtor
and thus the number of times a pass is called. Making HAVE_COMDAT_GROUP be
true, I can see there is still a difference in code generation but I guess it's
likely a similar thing. No issue here.

Best regards.