[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is due to HAVE_AS_IX86_FILDS not being defined.  So basically they made
the clang assembly not backwards compatible with the GNU one.

You can add a check to configure.ac if you want which does the same the check
for the gnu assembly:
    gcc_GAS_CHECK_FEATURE([filds and fists mnemonics],
       gcc_cv_as_ix86_filds,,,
       [filds mem; fists mem],,
       [AC_DEFINE(HAVE_AS_IX86_FILDS, 1,
         [Define if your assembler uses filds and fists mnemonics.])])

Actually on second thought, this should be happening.  Can you attach
config.log form gcc directory.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #2 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Created attachment 35760
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35760&action=edit
gcc/config.log generated against Xcode7

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Jack Howarth from comment #2)
> Created attachment 35760 [details]
> gcc/config.log generated against Xcode7

Wrong one.  This is the one for libevent.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[iains at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 2888 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
could you please also list 
as -v
and 
as --version

it's possible that it no longer contains the string "GNU" which would actually
help us distinguish moving forward (i have some patches in my Q to handle
Darwin assemblers better and to support my prototype GAS port) ….
>From gcc-bugs-return-488757-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jun 11 13:36:41 2015
Return-Path: <gcc-bugs-return-488757-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 79949 invoked by alias); 11 Jun 2015 13:36:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 79849 invoked by uid 48); 11 Jun 2015 13:36:35 -0000
From: "howarth.at.gcc at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32
Date: Thu, 11 Jun 2015 13:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.1.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: howarth.at.gcc at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created
Message-ID: <bug-66509-4-GyT3hy5EgT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66509-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66509-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01089.txt.bz2
Content-length: 551

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf509

Jack Howarth <howarth.at.gcc at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35760|0                           |1
        is obsolete|                            |

--- Comment #5 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Created attachment 35761
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id5761&actioníit
gcc/config.log generated against Xcode7

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The assembly test in configure failed:

configure:24880: checking assembler for filds and fists mnemonics
configure:24889: /usr/bin/as    -o conftest.o conftest.s >&5
clang -cc1as: fatal error: error in backend: 32-bit absolute addressing is not
supported in 64-bit mode
configure:24892: $? = 1
configure: failed program was
filds mem; fists mem


So maybe it is just a matter of changing configure.ac to use a slightly
different test on it.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #9 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Also, testing with in-line assembly using clang 3.7svn, I get the same behavior
for...

% cat conftest.c
asm("filds mem; fists mem");
% clang-3.7 -c conftest.c
fatal error: error in backend: 32-bit absolute addressing is not supported in
64-bit mode
% clang-3.7 -m32 -c conftest.c
%

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #11 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Also changing

fildq mem; fistpq mem

ro 

fildq (%ebp); fistpq (%ebp)

allows the fildq and fistpq mnemonics to pass at -m32/-m64 on the clang-based
assembler.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mikestump at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #12 from Mike Stump <mikestump at comcast dot net> ---
Here is a case where we wish for actual feature testing of all the bits instead
of the coarse grain, are we FSF gas 2.9 or later.  Default should be things
work nicely, and the feature testing should be to identify incomplete or broken
things.  Given the propensity for people to write a test, is this 2.x or later,
that is a direct indication they wrote it wrong in the first place.  Tests
should always be 2.x or earlier to identify broken.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #13 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Also confirmed that using the modified tests of...

filds (%ebp); fists (%ebp)

and

fildq (%ebp); fistpq (%ebp)

allow the GNU legacy assembler from Xcode 6.2 (Apple Inc version cctools-862,
GNU assembler version 1.38) to pass these two gcc/configure tests at both
-m32/-m64.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #14 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Created attachment 35765
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35765&action=edit
proposed fix for PR66509

Confirmed to bootstrap the c,c++,fortran,lto,java on x86_64-apple-darwin15
against Xcode 7's clang-based assembler and c,c++,fortran,lto,objc,obj-c++,java
on x86_64-apple-darwin14 against Xcode 6.2's legacy GNU assembler.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrs at gcc dot gnu.org

--- Comment #15 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
The fix requires that binutils also support the () spelling as the test runs on
all x86 systems.  Also, it will break systems older then when () was first
introduced, if it was after filds itself was supported.  I don't know when each
was new.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #16 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
(In reply to mrs@gcc.gnu.org from comment #15)
> The fix requires that binutils also support the () spelling as the test runs
> on all x86 systems.  Also, it will break systems older then when () was
> first introduced, if it was after filds itself was supported.  I don't know
> when each was new.

Seems like a question for H.J. Lu. Also, it looks like we already have a few
instances of that syntax in current gcc trunk...

% grep " (%" gcc/configure
    $as_echo 'lock xacquire cmpxchg %esi, (%ecx)' > conftest.s
         lock addl %edi, (%eax,%esi)
         lock orl $0, (%esp)' > conftest.s

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #17 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Apple responded on radar as follows...

This issue behaves as intended based on the following:

I think the first diagnostic is reasonable: there's not particular reason to
prefer filds over fildl (or even fildll) so some disambiguation is needed.

The second is debatable: MachO does seem to be able to represent it if we
wanted, and ld64 seems to handle it correctly, but our execution model never
puts any pointers at a location reachable by such a relocation (it's all
PAGEZERO). So I think that one is probably best kept too.

I'd suggest that GCC use either "filds mem(%rip)" or possibly "filds (%ebp)"
(to pick a random example) for something that should assemble in both 64-bit
and 32-bit mode -- sidestepping the relocation issue entirely.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zanpeeters at gmail dot com

--- Comment #18 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 64540 has been marked as a duplicate of this bug. ***

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #19 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Author: mrs
Date: Tue Jun 30 02:10:43 2015
New Revision: 225158

URL: https://gcc.gnu.org/viewcvs?rev=225158&root=gcc&view=rev
Log:
        PR target/66509
        * configure.ac: Fix filds and fildq test for 64-bit.
        * configure: Regenerated.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/configure
    trunk/gcc/configure.ac

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

Jack Howarth <howarth.at.gcc at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #20 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Confirmed as fixed on x86_64-apple-darwin15.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |6.0
   Target Milestone|---                         |6.0
      Known to fail|                            |5.1.0

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #21 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Should we back-port this fix for gcc 5.2.0 as its current gcc/configure
errornously fails the filds and fildq test for 64-bit with both the legacy GNU
assembler and the clang-based assembler?

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #22 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Yes.  It cleanly applies to the 5 branch and the 4.9 branch.  Let me know how a
build and test cycle goes on both, and I propose to drop it into both.

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #23 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Mike, tested back port of...

Author: mrs
Date: Tue Jun 30 02:10:43 2015
New Revision: 225158

URL: https://gcc.gnu.org/viewcvs?rev=225158&root=gcc&view=rev
Log:
PR target/66509
* configure.ac: Fix filds and fildq test for 64-bit.
* configure: Regenerated.

to gcc-5-branch at r225316 with no obvious regression

https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg00300.html

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #24 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Author: mrs
Date: Fri Jul  3 17:00:49 2015
New Revision: 225386

URL: https://gcc.gnu.org/viewcvs?rev=225386&root=gcc&view=rev
Log:
2015-07-03  Jack Howarth  <howarth.at.gcc@gmail.com>

        PR target/66509
        * configure.ac: Fix filds and fildq test for 64-bit.
        * configure: Regenerated.

Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/configure
    branches/gcc-5-branch/gcc/configure.ac

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #25 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Author: mrs
Date: Fri Jul  3 17:50:48 2015
New Revision: 225400

URL: https://gcc.gnu.org/viewcvs?rev=225400&root=gcc&view=rev
Log:
2015-07-03  Jack Howarth  <howarth.at.gcc@gmail.com>

        PR target/66509
        * configure.ac: Fix filds and fildq test for 64-bit.
        * configure: Regenerated.

Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/configure
    branches/gcc-4_9-branch/gcc/configure.ac

[Bug target/66509] the new clang-based assembler in Xcode 7 on 10.11 fails on the libjava/java/lang/reflect/natArray.cc file from FSF gcc 5.1 at -m32

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66509

--- Comment #26 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
FYI, test results for back port onto gcc-4_9-branch is posted at...

https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg00400.html