[Bug tree-optimization/66510] gcc.target/arm/pr53636.c FAILs after r224221

[Bug tree-optimization/66510] gcc.target/arm/pr53636.c FAILs after r224221

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

James Greenhalgh <jgreenhalgh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-06-11
     Ever confirmed|0                           |1

[Bug tree-optimization/66510] [6 Regression] gcc.target/arm/pr53636.c FAILs after r224221

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |6.0
            Summary|gcc.target/arm/pr53636.c    |[6 Regression]
                   |FAILs after r224221         |gcc.target/arm/pr53636.c
                   |                            |FAILs after r224221

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/66510] [6 Regression] gcc.target/arm/pr53636.c FAILs after r224221

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com

--- Comment #2 from Uroš Bizjak <ubizjak at gmail dot com> ---
FTR, r224221 also caused following testsuite FAIL for x86:

FAIL: gcc.target/i386/pr61403.c scan-assembler blend
>From gcc-bugs-return-488857-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jun 12 10:25:01 2015
Return-Path: <gcc-bugs-return-488857-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 38882 invoked by alias); 12 Jun 2015 10:25:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 38786 invoked by uid 48); 12 Jun 2015 10:24:58 -0000
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/66448] [6 Regression] Bootstrap fails on darwin after r224161
Date: Fri, 12 Jun 2015 10:25:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66448-4-pO0H0D984Z@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66448-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66448-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01189.txt.bz2
Content-length: 499

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf448

--- Comment #25 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #24)
> I still see

> with the patches in comments 17 and 20. What am I missing?

IIRC, the patch at comment #17 includes the original "lazy creation" of the
external ref. which breaks objc++.

The DWARF fixes are now in trunk, and I have bootstrapped 244409 + comment #20
on darwin12 and x86-64-linux .. so should be posting it soon.

[Bug tree-optimization/66510] [6 Regression] gcc.target/arm/pr53636.c FAILs after r224221

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Reproduces on x86_64 with -O -ftree-loop-vectorize -march=corei7 as well.

[Bug tree-optimization/66510] [6 Regression] gcc.target/arm/pr53636.c FAILs after r224221

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Ok, so we don't limit group sizes to multiples of nunits which means
vect_transform_slp_perm_load misses an early out.  This is then also a missed
optimization as we don't consider the three SLP loads permutes of the single
group load.

Index: gcc/tree-vect-slp.c
===================================================================
--- gcc/tree-vect-slp.c (revision 224514)
+++ gcc/tree-vect-slp.c (working copy)
@@ -3306,6 +3276,10 @@ vect_transform_slp_perm_load (slp_tree n
                      return false;
                    }

+                 if (need_next_vector
+                     && vec_index >= (vf * group_size) / nunits)
+                   return false;
+
                   if (!analyze_only)
                     {
                      int l;

[Bug tree-optimization/66510] [6 Regression] gcc.target/arm/pr53636.c FAILs after r224221

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Thu Jun 18 09:39:13 2015
New Revision: 224598

URL: https://gcc.gnu.org/viewcvs?rev=224598&root=gcc&view=rev
Log:
2015-06-18  Richard Biener  <rguenther@suse.de>

        PR tree-optimization/66510
        * tree-vect-stmts.c (vectorizable_load): Properly compute the
        number of vector loads for SLP permuted loads.
        * tree-vect-data-refs.c (vect_compute_data_ref_alignment): Also
        check the stride for loop vectorization.
        (vect_enhance_data_refs_alignment): Deal with SLP adjusted
        vectorization factor.
        (vect_analyze_group_access): If the group size is not a power
        of two require a epilogue loop.
        * tree-vect-loop.c (vect_analyze_loop_2): Move alignment
        compute and optimizing and alias test pruning after final
        vectorization factor computation.
        * tree-vect-slp.c (vect_build_slp_tree_1): Remove check on
        vector alignment.
        (vect_transform_slp_perm_load): Properly compute the original
        number of vector load stmts.

        * gcc.dg/vect/slp-perm-12.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/vect/slp-perm-12.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-data-refs.c
    trunk/gcc/tree-vect-loop.c
    trunk/gcc/tree-vect-slp.c
    trunk/gcc/tree-vect-stmts.c

[Bug tree-optimization/66510] [6 Regression] gcc.target/arm/pr53636.c FAILs after r224221

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.