[Bug preprocessor/66527] New: incorrect line number in diagnostics for multiline initializers

[Bug preprocessor/66527] New: incorrect line number in diagnostics for multiline initializers

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66527

            Bug ID: 66527
           Summary: incorrect line number in diagnostics for multiline
                    initializers
           Product: gcc
           Version: 5.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: preprocessor
          Assignee: unassigned at gcc dot gnu.org
          Reporter: msebor at gcc dot gnu.org
  Target Milestone: ---

In a diagnostic message pointing to an initializer that spans multiple lines,
instead of pointing to the offending construct gcc points to the line withe the
terminating semicolon or closing brace (when the initializer is an aggregate).

For example:

$ cat t.c && /build/gcc-66516/gcc/xgcc -B /build/gcc-66516/gcc -S -o/dev/null
t.c
/* 1 */ void f (register int i) {
/* 2 */ int* a =
/* 3 */     &i
/* 4 */ ;
/* 5 */ }
t.c: In function ‘f’:
t.c:4:9: error: address of register variable ‘i’ requested
 /* 4 */ ;
         ^

(I haven't seen this mentioned on the
https://gcc.gnu.org/wiki/Better_Diagnostics Wiki; sorry if this is another
known issue and I missed it.)
>From gcc-bugs-return-488902-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jun 12 22:24:37 2015
Return-Path: <gcc-bugs-return-488902-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 109488 invoked by alias); 12 Jun 2015 22:24:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 109463 invoked by uid 48); 12 Jun 2015 22:24:33 -0000
From: "wilson at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/66271] -Os generates incorrect code on ARM possibly due to IPA
Date: Fri, 12 Jun 2015 22:24:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.1.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: wilson at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-66271-4-ukDCm3I5RN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66271-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66271-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01234.txt.bz2
Content-length: 459

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf271

Jim Wilson <wilson at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Jim Wilson <wilson at gcc dot gnu.org> ---
This is the same kernel string bug as in 65932.

[Bug c/66527] incorrect line number in diagnostics for multiline initializers

[manu at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 2846 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66527

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-06-14
                 CC|                            |manu at gcc dot gnu.org
          Component|preprocessor                |c
     Ever confirmed|0                           |1

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
This probably requires passing an explicit location to c_mark_addressable and
using error_at everywhere.
>From gcc-bugs-return-488956-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 14 16:12:42 2015
Return-Path: <gcc-bugs-return-488956-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 28068 invoked by alias); 14 Jun 2015 16:12:42 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 28024 invoked by uid 48); 14 Jun 2015 16:12:38 -0000
From: "vries at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/66429] ICE in expand_GOMP_SIMD_LAST_LANE
Date: Sun, 14 Jun 2015 16:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libgomp
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: ice-on-valid-code, openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-66429-4-J6Q8ChNANd@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66429-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66429-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01288.txt.bz2
Content-length: 296

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf429

--- Comment #3 from vries at gcc dot gnu.org ---
Created attachment 35777
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id5777&actioníit
tentative patch

Using this patch, we avoid the ICE. Not sure if this is the right way to fix
it.

[Bug c/66527] incorrect line number in diagnostics for multiline initializers

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66527

--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
Here's a slightly different test case showing a similar problem and pointing
out that the issue isn't specific to initializers.  Also, the warning at the
end is incorrect (probably the fallout from the prior errors).

int foo (register int a, register int b)
{
    return
    *
    (
    a
    ?
    &
    a
    :
    &
    b
    );
}
u.c: In function ‘foo’:
u.c:10:5: error: address of register variable ‘a’ requested
     :
     ^
u.c:13:5: error: address of register variable ‘b’ requested
     );
     ^
u.c:14:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
>From gcc-bugs-return-489142-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jun 16 23:21:32 2015
Return-Path: <gcc-bugs-return-489142-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23968 invoked by alias); 16 Jun 2015 23:21:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23755 invoked by uid 48); 16 Jun 2015 23:21:27 -0000
From: "dave.gittins at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/55805] Empty brace-init-list causes warning "missing initializer for member" in C++11
Date: Tue, 16 Jun 2015 23:21:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.7.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dave.gittins at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: INVALID
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-55805-4-vmsLLM6SX2@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-55805-4@http.gcc.gnu.org/bugzilla/>
References: <bug-55805-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01474.txt.bz2
Content-length: 561

https://gcc.gnu.org/bugzilla/show_bug.cgi?idU805

--- Comment #11 from Gubbins <dave.gittins at gmail dot com> ---
(In reply to Jonathan Wakely from comment #10)
> (In reply to Gubbins from comment #9)
> > I see, thanks. Will there be no more releases on the 4.9 branch?
>
> There will be more. https://gcc.gnu.org/ml/gcc/2015-06/msg00163.html

OK. If it hasn't already happened, I think it would be good to back-port that
change to 4.9. I guess I should go and read up on the right way to submit that
proposal to the maintainers.

Thanks for the responses