From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-489131-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 106577 invoked by alias); 16 Jun 2015 18:14:21 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 106525 invoked by uid 55); 16 Jun 2015 18:14:16 -0000
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug jit/66539] Missing parentheses in jit dumps
Date: Tue, 16 Jun 2015 18:14:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: jit
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dmalcolm at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66539-4-YbpvJoxyOW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66539-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66539-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg01463.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66539

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Author: dmalcolm
Date: Tue Jun 16 18:13:44 2015
New Revision: 224531

URL: https://gcc.gnu.org/viewcvs?rev=224531&root=gcc&view=rev
Log:
PR jit/66539: Add parentheses as needed to gcc_jit_object_get_debug_string

gcc/jit/ChangeLog:
        PR jit/66539
        * jit-recording.c: Within namespace gcc::jit::recording::
        (rvalue::get_debug_string_parens): New function.
        (binary_op::make_debug_string): Update to mimic C precedence
        rules.
        (binary_op_precedence): New array.
        (binary_op::get_precedence): New function.
        (comparison::make_debug_string): Update to mimic C precedence
        rules.
        (comparison_precedence): New array.
        (comparison::get_precedence): New function.
        (cast::make_debug_string): Update to mimic C precedence rules.
        (call::make_debug_string): Likewise.
        (call_through_ptr::make_debug_string): Likewise.
        (array_access::make_debug_string): Likewise.
        (access_field_of_lvalue::make_debug_string): Likewise.
        (access_field_rvalue::make_debug_string): Likewise.
        (dereference_field_rvalue::make_debug_string): Likewise.
        (dereference_rvalue::make_debug_string): Likewise.
        (get_address_of_lvalue::make_debug_string): Likewise.
        * jit-recording.h: Within namespace gcc::jit::recording::
        (precedence): New enum.
        (rvalue::rvalue): Initialize field "m_parenthesized_string".
        (rvalue::get_debug_string_parens): New method.
        (rvalue::get_precedence): New pure virtual function.
        (rvalue::m_parenthesized_string): New field.
        (param::get_precedence): New function.
        (global::get_precedence): New function.
        (memento_of_new_rvalue_from_const::get_precedence): New function.
        (memento_of_new_string_literal::get_precedence): New function.
        (unary_op::get_precedence): New function.
        (binary_op::get_precedence): New function.
        (comparison::get_precedence): New function.
        (cast::get_precedence): New function.
        (call::get_precedence): New function.
        (call_through_ptr::get_precedence): New function.
        (array_access::get_precedence): New function.
        (access_field_of_lvalue::get_precedence): New function.
        (access_field_rvalue::get_precedence): New function.
        (dereference_field_rvalue::get_precedence): New function.
        (dereference_rvalue::get_precedence): New function.
        (get_address_of_lvalue::get_precedence): New function.
        (local::get_precedence): New function.

gcc/testsuite/ChangeLog:
        PR jit/66539
        * jit.dg/all-non-failing-tests.h: Add test-debug-strings.c.
        * jit.dg/test-debug-strings.c: New test case.
        * jit.dg/test-quadratic.c (make_calc_discriminant): Verify that
        the discriminant has a sane debug string.


Added:
    trunk/gcc/testsuite/jit.dg/test-debug-strings.c
Modified:
    trunk/gcc/jit/ChangeLog
    trunk/gcc/jit/jit-recording.c
    trunk/gcc/jit/jit-recording.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/jit.dg/all-non-failing-tests.h
    trunk/gcc/testsuite/jit.dg/test-quadratic.c