[Bug fortran/66549] New: ICE on valid in OMP parallel region

[Bug fortran/66549] New: ICE on valid in OMP parallel region

[abensonca at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

            Bug ID: 66549
           Summary: ICE on valid in OMP parallel region
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: abensonca at gmail dot com
  Target Milestone: ---

The following causes an ICE with gfortran 6.0 (r224494):

module smfa
  type :: sgc
   contains
     procedure :: sla => sa
  end type sgc
  class(sgc), pointer :: sg_
  double precision, allocatable, dimension(:) :: vni 
contains
  double precision function sa(self,i)
    class(sgc), intent(in   ) :: self
  end function sa
  subroutine cvn(sg_,vn)
    class(sgc), intent(inout) :: sg_
    double precision, intent(  out), dimension(:) :: vn
    integer :: i
    do i=1,2
       vn(i)= sg_%sla(i)
    end do
  end subroutine cvn
  subroutine clwf()
    !$omp parallel
    call cvn(sg_,vni)
    !$omp end parallel
  end subroutine clwf
end module smfa

$ gfortran -v
Using built-in specs.
COLLECT_GCC=/opt/gcc-trunk/bin/gfortran
COLLECT_LTO_WRAPPER=/opt/gcc-trunk/libexec/gcc/x86_64-unknown-linux-gnu/6.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-trunk/configure --prefix=/opt/gcc-trunk
--enable-languages=c,c++,fortran --disable-multilib
Thread model: posix
gcc version 6.0.0 20150615 (experimental) (GCC)

$ gfortran -c test2.F90 -O2 -fopenmp
test2.F90:12:0:

   subroutine cvn(sg_,vn)
^
internal compiler error: in create_component_ref_by_pieces_1, at
tree-ssa-pre.c:2585
0xcfb5bf create_component_ref_by_pieces_1
        ../../gcc-trunk/gcc/tree-ssa-pre.c:2585
0xcfb02f create_component_ref_by_pieces_1
        ../../gcc-trunk/gcc/tree-ssa-pre.c:2538
0xcfacb0 create_component_ref_by_pieces_1
        ../../gcc-trunk/gcc/tree-ssa-pre.c:2594
0xcfa40e create_component_ref_by_pieces
        ../../gcc-trunk/gcc/tree-ssa-pre.c:2735
0xcfa40e create_expression_by_pieces
        ../../gcc-trunk/gcc/tree-ssa-pre.c:2826
0xcfb875 insert_into_preds_of_block
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3025
0xcff1de do_regular_insertion
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3353
0xcff1de insert_aux
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3563
0xcfe807 insert_aux
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3573
0xcfe807 insert_aux
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3573
0xcfe807 insert_aux
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3573
0xd0126d insert
        ../../gcc-trunk/gcc/tree-ssa-pre.c:3596
0xd0126d execute
        ../../gcc-trunk/gcc/tree-ssa-pre.c:4864
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

If compiled with -O1 instead of -O2 a different ICE occurs:

$ gfortran -c test2.F90 -O1 -fopenmp
test2.F90:16:0:

     do i=1,2
^
internal compiler error: in make_decl_rtl, at varasm.c:1320
0xe3f385 make_decl_rtl(tree_node*)
        ../../gcc-trunk/gcc/varasm.c:1316
0x854c93 expand_expr_real_1(tree_node*, rtx_def*, machine_mode,
expand_modifier, rtx_def**, bool)
        ../../gcc-trunk/gcc/expr.c:9489
0x861bbe expand_expr
        ../../gcc-trunk/gcc/expr.h:255
0x861bbe expand_assignment(tree_node*, tree_node*, bool)
        ../../gcc-trunk/gcc/expr.c:5130
0x755a95 expand_gimple_stmt_1
        ../../gcc-trunk/gcc/cfgexpand.c:3318
0x755a95 expand_gimple_stmt
        ../../gcc-trunk/gcc/cfgexpand.c:3414
0x757ebc expand_gimple_basic_block
        ../../gcc-trunk/gcc/cfgexpand.c:5426
0x75e846 execute
        ../../gcc-trunk/gcc/cfgexpand.c:6045
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

If compiled without -fopenmp compilation is successful.

[Bug fortran/66549] [Regression] ICE on valid in OMP parallel region

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-06-16
                 CC|                            |kargl at gcc dot gnu.org
      Known to work|                            |4.8.5, 4.9.3
            Summary|ICE on valid in OMP         |[Regression] ICE on valid
                   |parallel region             |in OMP parallel region
     Ever confirmed|0                           |1
      Known to fail|                            |5.1.1, 6.0

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[Regression] ICE on valid   |[5/6 Regression] ICE on
                   |in OMP parallel region      |valid in OMP parallel
                   |                            |region

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The regression appeared between revisions r221569 (2015-03-22, OK) and r221610
(2015-03-23, ICE).

Note that the ICE on x86_64-apple-darwin14 is

internal compiler error: in make_decl_rtl, at varasm.c:1313

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org
          Component|libgomp                     |fortran
   Target Milestone|---                         |5.2

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
r221586 in particular.

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

--- Comment #3 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> r221586 in particular.
There is no openmp change in that revision. :-/

--- comment_0.f90.003t.original.good    2015-06-17 21:29:00.667012376 +0200
+++ comment_0.f90.003t.original.bad     2015-06-17 21:31:28.013012840 +0200
@@ -6,7 +6,7 @@

 clwf ()
 {
-  #pragma omp parallel
+  #pragma omp parallel private(i)
     {
       {
         struct __class_smfa_Sgc_t sg_.0;
@@ -20,7 +20,6 @@

 cvn (struct __class_smfa_Sgc_t & restrict sg_, struct array1_real(kind=8) &
restrict vn)
 {
-  integer(kind=4) i;
   integer(kind=8) ubound.1;
   integer(kind=8) stride.2;
   integer(kind=8) offset.3;

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

--- Comment #4 from Mikael Morin <mikael at gcc dot gnu.org> ---
Created attachment 35796
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35796&action=edit
Draft patch

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

--- Comment #5 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Fri Jun 19 12:50:00 2015
New Revision: 224648

URL: https://gcc.gnu.org/viewcvs?rev=224648&root=gcc&view=rev
Log:
Fix openmp global state fortran regression

        PR fortran/66549
gcc/fortran/
        * resolve.c (resolve_global_procedure): Don't save and restore
        OpenMP state around the call to gfc_resolve.
        (gfc_resolve): Save OpenMP state on entry and restore it on return.
gcc/testsuite/
        * gfortran.dg/gomp/omp_parallel_1.f90: New file.


Added:
    trunk/gcc/testsuite/gfortran.dg/gomp/omp_parallel_1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mikael at gcc dot gnu.org

[Bug fortran/66549] [5 Regression] ICE on valid in OMP parallel region

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
            Summary|[5/6 Regression] ICE on     |[5 Regression] ICE on valid
                   |valid in OMP parallel       |in OMP parallel region
                   |region                      |

[Bug fortran/66549] [5 Regression] ICE on valid in OMP parallel region

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

--- Comment #6 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Wed Jun 24 09:16:13 2015
New Revision: 224887

URL: https://gcc.gnu.org/viewcvs?rev=224887&root=gcc&view=rev
Log:
Fix openmp global state fortran regression

        PR fortran/66549
gcc/fortran/
        * resolve.c (resolve_global_procedure): Don't save and restore
        OpenMP state around the call to gfc_resolve.
        (gfc_resolve): Save OpenMP state on entry and restore it on return.
gcc/testsuite/
        * gfortran.dg/gomp/omp_parallel_1.f90: New file.


Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/gomp/omp_parallel_1.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/resolve.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug fortran/66549] [5/6 Regression] ICE on valid in OMP parallel region

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66549

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
            Summary|[5 Regression] ICE on valid |[5/6 Regression] ICE on
                   |in OMP parallel region      |valid in OMP parallel
                   |                            |region

--- Comment #7 from Mikael Morin <mikael at gcc dot gnu.org> ---
Fixed on trunk (upcoming 6.1) and 5 branch (upcoming 5.2).