public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "gang.chen.5i5j at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/66620] bfin: bfin.c: (hwloop_optimize): gcc_assert (JUMP_P (insn)) fails. Date: Sun, 28 Jun 2015 13:54:00 -0000 [thread overview] Message-ID: <bug-66620-4-XKKUAzIabi@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-66620-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66620 --- Comment #9 from Chen Gang <gang.chen.5i5j at gmail dot com> --- After check the assembly result for the without "-fno-reorder-block", it is OK. It is for lsetup optimization. And for having "-fno-reorder-block", the insns are also correct, and after skip the related assert(), it can also pass compiling and generate the correct assembly code. The related diff is below, and the related assembly code is in the next attachment. diff --git a/gcc/config/bfin/bfin.c b/gcc/config/bfin/bfin.c index 3b4b54e..91866dd 100644 --- a/gcc/config/bfin/bfin.c +++ b/gcc/config/bfin/bfin.c @@ -3520,7 +3520,13 @@ hwloop_optimize (hwloop_info loop) if (vec_safe_length (loop->incoming) > 1 || !(loop->incoming->last ()->flags & EDGE_FALLTHRU)) { - gcc_assert (JUMP_P (insn)); + if (!JUMP_P (insn)) + { + if (dump_file) + fprintf (dump_file, ";; loop %d lsetup may already inserted\n", + loop->loop_no); + return false; + } insn = PREV_INSN (insn); }
next prev parent reply other threads:[~2015-06-28 13:54 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-22 1:54 [Bug target/66620] New: " gang.chen.5i5j at gmail dot com 2015-06-22 7:55 ` [Bug target/66620] " miyuki at gcc dot gnu.org 2015-06-27 2:08 ` gang.chen.5i5j at gmail dot com 2015-06-27 2:17 ` gang.chen.5i5j at gmail dot com 2015-06-27 2:18 ` gang.chen.5i5j at gmail dot com 2015-06-27 2:20 ` gang.chen.5i5j at gmail dot com 2015-06-27 7:32 ` gang.chen.5i5j at gmail dot com 2015-06-28 9:45 ` gang.chen.5i5j at gmail dot com 2015-06-28 9:48 ` gang.chen.5i5j at gmail dot com 2015-06-28 13:54 ` gang.chen.5i5j at gmail dot com [this message] 2015-06-28 13:57 ` gang.chen.5i5j at gmail dot com 2015-06-28 13:58 ` gang.chen.5i5j at gmail dot com 2015-06-28 14:02 ` gang.chen.5i5j at gmail dot com 2015-09-03 2:45 ` gang.chen.5i5j at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-66620-4-XKKUAzIabi@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).