public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
Date: Fri, 26 Jun 2015 09:12:00 -0000	[thread overview]
Message-ID: <bug-66633-4-jMWUz3Ie5c@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-66633-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
The error mark is inserted by omp-low.c:omp_copy_decl for FRAME.1:

spl ()
{
  static real(kind=8) fli (void);
  struct FRAME.spl FRAME.1;

  __builtin_init_trampoline (&FRAME.1.fli, fli, &FRAME.1);
  #pragma omp parallel
    {
      void * D.3392;
      real(kind=8) (*<T8cb>) (void) D.3393;
      integer(kind=4) D.3387;
      struct __st_parameter_dt dt_parm.0;

      try
        {
          dt_parm.0.common.filename = &"pr66633.f90"[1]{lb: 1 sz: 1};
          dt_parm.0.common.line = 5;
          dt_parm.0.common.flags = 128;
          dt_parm.0.common.unit = 0;
          _gfortran_st_write (&dt_parm.0);
          {
            integer(kind=4) D.3386;

            try
              {
                D.3392 = __builtin_adjust_trampoline (&FRAME.1.fli);
                D.3393 = (real(kind=8) (*<T8cb>) (void)) D.3392;
                D.3387 = igrt (D.3393);
                D.3386 = D.3387;
                _gfortran_transfer_integer_write (&dt_parm.0, &D.3386, 4);
              }
            finally
              {
                D.3386 = {CLOBBER};
              }
          }
          _gfortran_st_write_done (&dt_parm.0);
        }
      finally
        {
          dt_parm.0 = {CLOBBER};
        }
    }
}

because the variable is not marked as shared.  For an equivalent C testcase:

void foo (int i)
{
  void nested (char c)
  {
    i = i + c;
  }

  void (*ptr)(char) = &nested;

  #pragma omp parallel
  {
    char a[i];
    ptr (a[0]);
  }
}

the FRAME.3 variable is marked as shared:

foo (int i)
{
  void * D.1866;
  void (*<T3d7>) (char) D.1867;
  static void nested (char);
  void (*<T3d7>) (char) ptr;
  struct FRAME.foo FRAME.3;
  int i [value-expr: FRAME.3.i];

  FRAME.3.i = i;
  __builtin_init_trampoline (&FRAME.3.nested, nested, &FRAME.3);
  D.1866 = __builtin_adjust_trampoline (&FRAME.3.nested);
  D.1867 = (void (*<T3d7>) (char)) D.1866;
  ptr = D.1867;
  #pragma omp parallel shared(FRAME.3) shared(ptr) shared(i)
    {
      int i.0;
      long int D.1841;
      long int D.1842;
      sizetype D.1843;
      sizetype D.1844;
      bitsizetype D.1845;
      bitsizetype D.1846;
      sizetype D.1847;
      sizetype D.1848;
      bitsizetype D.1849;
      bitsizetype D.1850;
      sizetype D.1851;
      char[0:D.1843] * a.1;
      char D.1853;
      int D.1854;
      void * saved_stack.2;

      {
        char a[0:D.1843] [value-expr: *a.1];

        saved_stack.2 = __builtin_stack_save ();
        try
          {
            i.0 = i;
            D.1841 = (long int) i.0;
            D.1842 = D.1841 + -1;
            D.1843 = (sizetype) D.1842;
            D.1844 = (sizetype) i.0;
            D.1845 = (bitsizetype) D.1844;
            D.1846 = D.1845 * 8;
            D.1847 = (sizetype) i.0;
            D.1848 = (sizetype) i.0;
            D.1849 = (bitsizetype) D.1848;
            D.1850 = D.1849 * 8;
            D.1851 = (sizetype) i.0;
            a.1 = __builtin_alloca_with_align (D.1851, 8);
            D.1853 = *a.1[0];
            D.1854 = (int) D.1853;
            ptr (D.1854);
          }
        finally
          {
            __builtin_stack_restore (saved_stack.2);
          }
      }
    }
}


  parent reply	other threads:[~2015-06-26  9:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23  1:23 [Bug fortran/66633] New: " abensonca at gmail dot com
2015-06-23  3:26 ` [Bug fortran/66633] " abensonca at gmail dot com
2015-06-23  9:44 ` mikael at gcc dot gnu.org
2015-06-24  9:30 ` [Bug fortran/66633] [5/6 regression] " mikael at gcc dot gnu.org
2015-06-24  9:50 ` dominiq at lps dot ens.fr
2015-06-25  9:43 ` mikael at gcc dot gnu.org
2015-06-25 14:56 ` ebotcazou at gcc dot gnu.org
2015-06-26  9:12 ` ebotcazou at gcc dot gnu.org [this message]
2015-06-26  9:16 ` ebotcazou at gcc dot gnu.org
2015-06-26  9:27 ` [Bug middle-end/66633] " ebotcazou at gcc dot gnu.org
2015-07-01  8:22 ` ebotcazou at gcc dot gnu.org
2015-07-01  8:26 ` ebotcazou at gcc dot gnu.org
2015-07-01 19:20 ` abensonca at gmail dot com
2015-07-01 20:49 ` ebotcazou at gcc dot gnu.org
2015-07-09 17:46 ` jakub at gcc dot gnu.org
2015-07-09 21:14 ` jakub at gcc dot gnu.org
2015-07-10 14:13 ` jakub at gcc dot gnu.org
2015-07-10 14:14 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-66633-4-jMWUz3Ie5c@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).