[Bug target/66697] Feature request: -mstackrealign and force_align_arg_pointer for x86_64

["ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66697

--- Comment #9 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Justas L from comment #8)
> I applied the first (testing) version of the patch on gcc 5.2.0 release
> source (with slight modifications to make it apply). All new features work
> as expected, as per the test in comment #2. However, compiling Wine with
> either -mstackrealign or -mincoming-stack-boundary=3 fails, throwing this
> error:
> 
> ---------
> ../../../wine/dlls/dxerr8/dxerr8.c:135:1: internal compiler error: in
> ix86_compute_frame_layout, at config/i386/i386.c:10212
> ---------
> 
> which refers to this line in i386.c:
> 
> ---------
> gcc_assert (INCOMING_STACK_BOUNDARY >= 128);
> ---------
> 
> Commenting out the assert allows Wine to compile normally. (I assume the
> correct fix would be to change the number to 64.) And compiling Wine with
> -mincoming-stack-boundary=3 does fix the original issue (or at least the one
> instance of it that I care about). So the gcc side of the issue is almost
> resolved, with just the assert left to address.

Thanks, this assert triggered on target I'm not able to test.

The correct solution is to emit unaligned moves when INCOMING_STACK_BOUNDARY <
128. This is the same problem as HJ is solving for interrupt handler.
>From gcc-bugs-return-498831-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 06 06:43:41 2015
Return-Path: <gcc-bugs-return-498831-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 55622 invoked by alias); 6 Oct 2015 06:43:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 55585 invoked by uid 48); 6 Oct 2015 06:43:37 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/67861] coreutils' wc.c:write_counts is miscompiled since commit 7e3a76de7c496449b187c2688d958631cf21a944
Date: Tue, 06 Oct 2015 06:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc bug_severity
Message-ID: <bug-67861-4-LOWn29jZXP@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67861-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67861-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg00386.txt.bz2
Content-length: 454

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg861

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nathan at gcc dot gnu.org,
                   |                            |trippels at gcc dot gnu.org
           Severity|blocker                     |normal