[Bug c/66747] New: The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[Bug c/66747] New: The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[doug.gilmore at imgtec dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

            Bug ID: 66747
           Summary: The commit r225260 broke the builds of the
                    mips-{mti,img}-linux-gnu tool chains.
           Product: gcc
           Version: 5.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doug.gilmore at imgtec dot com
  Target Milestone: ---

The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool
chains.

To reproduce the problem, configure the binutils build from the directory
/scratch/d/obj-mips-img-linux-gnu/binutils-gdb:


/scratch/d/src/binutils-gdb/configure
--prefix=/scratch/d/install-mips-img-linux-gnu --target=mips-img-linux-gnu
--with-sysroot=/scratch/d/install-mips-img-linux-gnu/sysroot
then run make and make install

Then configure the gcc build from the directory
/scratch/d/obj-mips-img-linux-gnu/initial_gcc:
/scratch/d/src/gcc/configure --prefix=/scratch/d/install-mips-img-linux-gnu
--disable-libssp --disable-libgomp --disable-libmudflap --disable-decimal-float
--with-mips-plt --target=mips-img-linux-gnu --enable-languages=c
--without-headers --disable-shared --disable-threads --disable-libquadmath
--disable-libatomic
running make fails with:

/scratch/d/obj-mips-img-linux-gnu/initial_gcc/./gcc/xgcc
-B/scratch/d/obj-mips-img-linux-gnu/initial_gcc/./gcc/
-B/scratch/d/install-mips-img-linux-gnu/mips-img-linux-gnu/bin/
-B/scratch/d/install-mips-img-linux-gnu/mips-img-linux-gnu/lib/ -isystem
/scratch/d/install-mips-img-linux-gnu/mips-img-linux-gnu/include -isystem
/scratch/d/install-mips-img-linux-gnu/mips-img-linux-gnu/sys-include    -g -O2
-minterlink-mips16 -mips64r6 -O2 -g -O2 -minterlink-mips16 -DIN_GCC 
-DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wwrite-strings -Wcast-qual
-Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem
./include  -I. -I. -I../../../.././gcc -I/scratch/d/src/gcc/libgcc
-I/scratch/d/src/gcc/libgcc/. -I/scratch/d/src/gcc/libgcc/../gcc
-I/scratch/d/src/gcc/libgcc/../include   -g0  -finhibit-size-directive
-fno-inline -fno-exceptions -fno-zero-initialized-in-bss -fno-toplevel-reorder
-fno-tree-vectorize -fbuilding-libgcc -fno-stack-protector  -Dinhibit_libc -I.
-I. -I../../../.././gcc -I/scratch/d/src/gcc/libgcc
-I/scratch/d/src/gcc/libgcc/. -I/scratch/d/src/gcc/libgcc/../gcc
-I/scratch/d/src/gcc/libgcc/../include  -o crtbeginT.o -MT crtbeginT.o -MD -MP
-MF crtbeginT.dep  -c /scratch/d/src/gcc/libgcc/crtstuff.c -DCRT_BEGIN
-DCRTSTUFFT_O
/scratch/d/src/gcc/libgcc/crtstuff.c: In function 'frame_dummy':
/scratch/d/src/gcc/libgcc/crtstuff.c:490:1: error: unrecognizable insn:
 }
 ^
(insn 82 67 8 (sequence [
            (jump_insn 7 67 66 (set (pc)
                    (if_then_else (eq (reg/f:SI 2 $2 [197])
                            (const_int 0 [0]))
                        (label_ref:SI 15)
                        (pc))) /scratch/d/src/gcc/libgcc/crtstuff.c:470 466
{*branch_equalitysi}
                 (expr_list:REG_DEAD (reg/f:SI 2 $2 [197])
                    (int_list:REG_BR_PROB 3017 (nil)))
             -> 15)
            (insn/f 66 7 8 (set (mem/c:DI (plus:SI (reg/f:SI 29 $sp)
                            (const_int 8 [0x8])) [5  S8 A64])
                    (reg:DI 31 $31)) 302 {*movdi_64bit}
                 (expr_list:REG_FRAME_RELATED_EXPR (set/f (mem/c:DI (plus:SI
(reg/f:SI 29 $sp)
                                (const_int 8 [0x8])) [5  S8 A64])
                        (reg:DI 31 $31))
                    (nil)))
        ]) /scratch/d/src/gcc/libgcc/crtstuff.c:470 -1
     (nil))

We are working around the issue by reverting r225260.

[Bug middle-end/66747] [5/6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.2
            Summary|The commit r225260 broke    |[5/6 Regression] The commit
                   |the builds of the           |r225260 broke the builds of
                   |mips-{mti,img}-linux-gnu    |the
                   |tool chains.                |mips-{mti,img}-linux-gnu
                   |                            |tool chains.

[Bug middle-end/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[edlinger at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

Bernd Edlinger <edlinger at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-07-03
            Version|5.2.0                       |6.0
   Target Milestone|5.2                         |6.0
            Summary|[5/6 Regression] The commit |[6 Regression] The commit
                   |r225260 broke the builds of |r225260 broke the builds of
                   |the                         |the
                   |mips-{mti,img}-linux-gnu    |mips-{mti,img}-linux-gnu
                   |tool chains.                |tool chains.
     Ever confirmed|0                           |1

--- Comment #1 from Bernd Edlinger <edlinger at gcc dot gnu.org> ---
confirmed. but it is a gcc-6 regression only.

With that patch we call mips_initial_elimination_offset
from rtx_addr_can_trap_p_1.  And it falls over insn 103:

(insn 103 58 62 (sequence [
            (call_insn 59 58 61 (parallel [
                        (call (mem:SI (reg/f:SI 25 $25 [orig:235 D.3533 ]
[235]) [0 *_13 S4 A32])
                            (const_int 0 [0]))
                        (clobber (reg:SI 31 $31))
                    ]) ../../../../gcc-6-20150614/libgcc/crtstuff.c:707 645
{call_internal}
                 (expr_list:REG_DEAD (reg/f:SI 25 $25 [orig:235 D.3533 ] [235])
                    (expr_list:REG_CALL_DECL (nil)
                        (nil)))
                (expr_list (use (reg:SI 79 $fakec))
                    (nil)))
            (insn 61 59 62 (set (reg/v/f:SI 16 $16 [orig:234 pD.3516 ] [234])
                    (plus:SI (reg/v/f:SI 16 $16 [orig:234 pD.3516 ] [234])
                        (const_int -4 [0xfffffffffffffffc]))) 13 {*addsi3}
                 (nil))
        ]) ../../../../gcc-6-20150614/libgcc/crtstuff.c:707 -1
     (nil))

unrecognizable, in mips_insn_has_flexible_gp_ref_p for whatever reason.



../../../../gcc-6-20150614/libgcc/crtstuff.c:708:1: internal compiler error: in
get_attr_got, at config/mips/mips.md:685
0xa9505a _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        ../../gcc-6-20150614/gcc/rtl-error.c:110
0xa95089 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        ../../gcc-6-20150614/gcc/rtl-error.c:118
0xe1beb5 get_attr_got
        ../../gcc-6-20150614/gcc/config/mips/mips.md:685
0xe1beb5 get_attr_got
        ../../gcc-6-20150614/gcc/config/mips/mips.md:662
0xe07c8a mips_insn_has_flexible_gp_ref_p
        ../../gcc-6-20150614/gcc/config/mips/mips.c:9905
0xe017f9 mips_find_gp_ref
        ../../gcc-6-20150614/gcc/config/mips/mips.c:9836
0xe020ed mips_global_pointer
        ../../gcc-6-20150614/gcc/config/mips/mips.c:9957
0xe020ed mips_compute_frame_info
        ../../gcc-6-20150614/gcc/config/mips/mips.c:10327
0xe0e8d6 mips_initial_elimination_offset(int, int)
        ../../gcc-6-20150614/gcc/config/mips/mips.c:10534
0xa9764d rtx_addr_can_trap_p_1
        ../../gcc-6-20150614/gcc/rtlanal.c:627
0xa97335 rtx_addr_can_trap_p_1
        ../../gcc-6-20150614/gcc/rtlanal.c:697
0xa99f87 may_trap_p_1(rtx_def const*, unsigned int)
        ../../gcc-6-20150614/gcc/rtlanal.c:2836
0xa8d7f7 fill_slots_from_thread
        ../../gcc-6-20150614/gcc/reorg.c:2521
0xa902dd fill_eager_delay_slots
        ../../gcc-6-20150614/gcc/reorg.c:2958
0xa902dd dbr_schedule
        ../../gcc-6-20150614/gcc/reorg.c:3805
0xa902dd rest_of_handle_delay_slots
        ../../gcc-6-20150614/gcc/reorg.c:3944
0xa902dd execute
        ../../gcc-6-20150614/gcc/reorg.c:3975

[Bug middle-end/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[edlinger at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

--- Comment #2 from Bernd Edlinger <edlinger at gcc dot gnu.org> ---
get_attr_got fails when called with a SEQUENCE.
I am not sure if reg_overlap_mentioned_p works with SEQUENCE.


--- gcc/config/mips/mips.c.jj   2015-06-08 23:06:50.000000000 +0200
+++ gcc/config/mips/mips.c      2015-07-03 11:38:48.962336295 +0200
@@ -9902,7 +9902,7 @@ mips_cfun_has_inflexible_gp_ref_p (void)
 static bool
 mips_insn_has_flexible_gp_ref_p (rtx_insn *insn)
 {
-  return (get_attr_got (insn) != GOT_UNSET
+  return ((PATTERN (insn)->code != SEQUENCE && get_attr_got (insn) !=
GOT_UNSET)
          || mips_small_data_pattern_p (PATTERN (insn))
          || reg_overlap_mentioned_p (pic_offset_table_rtx, PATTERN (insn)));
 }

[Bug middle-end/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

--- Comment #3 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
Created attachment 35902
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35902&action=edit
proposed patch

this slightly improved patch should fix it, could you give it a try?

Thanks,
Bernd.

[Bug middle-end/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[doug.gilmore at imgtec dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

--- Comment #4 from Doug Gilmore <doug.gilmore at imgtec dot com> ---
Thanks!

I started up a build with the patch and it got through
the initial_gcc build so that is a good sign.

I'll send an update once the build is done.

[Bug middle-end/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[doug.gilmore at imgtec dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

Doug Gilmore <doug.gilmore at imgtec dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthew.fortune at imgtec dot com

--- Comment #5 from Doug Gilmore <doug.gilmore at imgtec dot com> ---
The build succeeded and the regression test run
showed no regressions.

Bernd: could you send the patch to the list for approval?

Thanks!

[Bug target/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[edlinger at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

Bernd Edlinger <edlinger at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |target
           Assignee|unassigned at gcc dot gnu.org      |edlinger at gcc dot gnu.org

--- Comment #6 from Bernd Edlinger <edlinger at gcc dot gnu.org> ---
patch was posted here: https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00238.html

[Bug target/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[edlinger at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

--- Comment #7 from Bernd Edlinger <edlinger at gcc dot gnu.org> ---
Author: edlinger
Date: Sat Jul  4 19:02:18 2015
New Revision: 225416

URL: https://gcc.gnu.org/viewcvs?rev=225416&root=gcc&view=rev
Log:
2015-07-04  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        PR target/66747
        * config/mips/mips.c (mips_find_gp_ref): Handle instruction sequences.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/mips/mips.c

[Bug target/66747] [6 Regression] The commit r225260 broke the builds of the mips-{mti,img}-linux-gnu tool chains.

[doug.gilmore at imgtec dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66747

--- Comment #9 from Doug Gilmore <doug.gilmore at imgtec dot com> ---
Our nightly builds are now clean with this patch.

Thanks!